search for: d25587

On Mon, Oct 31, 2016 at 3:46 PM Zachary Turner via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi all, > > Tentatively final version is up here: https://reviews.llvm.org/D25587 > > It has a verbal LGTM, but I plan to wait a bit longer just in case anyone > has some additional thoughts. It's a large patch, but if you're > interested, one way you can help without doing a full-blown review is to > look at the large comment blocks in FormatVariadic.h a...

* UDL Syntax is removed in the latest version of the patch <https://reviews.llvm.org/D25587>. * Name changed to `formatv` since `format_string` is too much to type. * Added conversion operators for `std::string` and `llvm::SmallString`. I had some feedback offline (not on this thread, unfortunately) that it might be worth using a printf style syntax instead of this Python-esque syntax...

...5:21 PM, Chandler Carruth via llvm-dev < llvm-dev at lists.llvm.org> wrote: > On Mon, Oct 31, 2016 at 3:46 PM Zachary Turner via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi all, >> >> Tentatively final version is up here: https://reviews.llvm.org/D25587 >> >> It has a verbal LGTM, but I plan to wait a bit longer just in case anyone >> has some additional thoughts. It's a large patch, but if you're >> interested, one way you can help without doing a full-blown review is to >> look at the large comment blocks i...

Hi all, Tentatively final version is up here: https://reviews.llvm.org/D25587 It has a verbal LGTM, but I plan to wait a bit longer just in case anyone has some additional thoughts. It's a large patch, but if you're interested, one way you can help without doing a full-blown review is to look at the large comment blocks in FormatVariadic.h and FormatProviders.h. H...

On 12.10.2016 05:59, Mehdi Amini via llvm-dev wrote: >> If you change a const char * to a StringRef, it can silently succeed >> while passing your StringRef object to printf. It should fail to compile! > > llvm::format now fails to compile as well :) > > However this does not address other issues, like: `format(“%d”, float_var)` This may be a good time to point at

...ptable? On Mon, Oct 31, 2016 at 5:21 PM Chandler Carruth <chandlerc at gmail.com> wrote: > On Mon, Oct 31, 2016 at 3:46 PM Zachary Turner via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > Hi all, > > Tentatively final version is up here: https://reviews.llvm.org/D25587 > > It has a verbal LGTM, but I plan to wait a bit longer just in case anyone > has some additional thoughts. It's a large patch, but if you're > interested, one way you can help without doing a full-blown review is to > look at the large comment blocks in FormatVariadic.h a...