Displaying 5 results from an estimated 5 matches for "d25495".
2017 Sep 06
3
[ThinLTO] static library failure with object files with the same name
...>
> ThinLTOCodeGenerator::addModule is called by the linker, right? (I can't
> find any callers)
> When it is called, we cannot retrieve the offset of the module inside the
> archive, because the linker didn't tell us about it.
See here for the fix.
https://reviews.llvm.org/D25495
You pass the the archive name + offset to `lto::InputFile::create`,
assuming your linker uses the new LTO API (and I'm not sure whether
ld64 already switched).
The linker knows the archive name from which it's fetching the member,
as well as its offset (it asks libArchive about it, for lld)...
2017 Sep 05
2
[ThinLTO] static library failure with object files with the same name
...ap, file ../lib/LTO/ThinLTOCodeGenerator.cpp, line 138.
The error occurs because the buffer identifier uses the filename of the
objects inside the archive, and those are identical for the two files with
different source path.
This problem appears to be fixed for LLD here:
https://reviews.llvm.org/D25495
https://bugs.llvm.org/show_bug.cgi?id=30665
But it persists for linking with the system linker on OSX (while manually
passing libLTO.dylib to the linker).
If I modify lib/LTO/ThinLTOCodeGenerator.cpp to do a poor-man's uniquefying
of the buffer identifier:
```
void ThinLTOCodeGenerator::addMo...
2017 Sep 07
2
[ThinLTO] static library failure with object files with the same name
...ht? (I
>> can't
>> > find any callers)
>> > When it is called, we cannot retrieve the offset of the module inside
>> the
>> > archive, because the linker didn't tell us about it.
>>
>> See here for the fix.
>> https://reviews.llvm.org/D25495
>> You pass the the archive name + offset to `lto::InputFile::create`,
>> assuming your linker uses the new LTO API (and I'm not sure whether
>> ld64 already switched).
>>
>
> AFAIK, no. Mehdi started to look at this awhile back but likely has not
> been able to...
2017 Sep 05
2
[ThinLTO] static library failure with object files with the same name
On Tue, Sep 5, 2017 at 2:09 PM, Teresa Johnson <tejohnson at google.com> wrote:
>
> Hi Johan,
>
> Right, per the bug this is fixed in lld (and was already handled in gold-plugin), but I guess not in ld64. Note that lld and gold-plugin use the new LTO API, while ld64 (and probably other linkers) are still using the legacy libLTO (which is what ThinLTOCodeGenerator.cpp is part of).
2017 Sep 11
2
[ThinLTO] static library failure with object files with the same name
...callers)
>>>> > When it is called, we cannot retrieve the offset of the module inside
>>>> the
>>>> > archive, because the linker didn't tell us about it.
>>>>
>>>> See here for the fix.
>>>> https://reviews.llvm.org/D25495
>>>> You pass the the archive name + offset to `lto::InputFile::create`,
>>>> assuming your linker uses the new LTO API (and I'm not sure whether
>>>> ld64 already switched).
>>>>
>>>
>>> AFAIK, no. Mehdi started to look at this...