search for: d20348

...teresting in general because according to the definition for local_unnamed_addr, the symbol has to be linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. What do you mean that the promotion can break that? The original description I found here: https://reviews.llvm.org/D20348 says that it is possible to exclude a global from the symbol table if three things are true: - This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be broken without being observable by the program by pe...

...because according to the definition for local_unnamed_addr, the symbol has to be linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. > > What do you mean that the promotion can break that? > > The original description I found here: https://reviews.llvm.org/D20348 <https://reviews.llvm.org/D20348> says that it is possible to exclude a global from the symbol table if three things are true: > This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be broken without bein...

...according to the definition > for local_unnamed_addr, the symbol has to be linkonce_odr to be auto hide > as well. ThinLTO promotion can break that as well. > > What do you mean that the promotion can break that? > > The original description I found here: https://reviews.llvm.org/D20348 > says that it is possible to exclude a global from the symbol table if > three things are true: > > - This attribute is present on every instance of the global (which > means that the normal rule that the global must have a unique address can > be broken without being ob...

...ng to the definition for local_unnamed_addr, the symbol has to be linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. >> >> What do you mean that the promotion can break that? >> >> The original description I found here: https://reviews.llvm.org/D20348 <https://reviews.llvm.org/D20348> says that it is possible to exclude a global from the symbol table if three things are true: >> This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be broken without...

...tion >> for local_unnamed_addr, the symbol has to be linkonce_odr to be auto hide >> as well. ThinLTO promotion can break that as well. >> >> What do you mean that the promotion can break that? >> >> The original description I found here: https://reviews.llvm.org/D20348 >> says that it is possible to exclude a global from the symbol table if >> three things are true: >> >> - This attribute is present on every instance of the global (which >> means that the normal rule that the global must have a unique address can >> be...

...nnamed_addr, the symbol has to be linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. >>>> >>>> What do you mean that the promotion can break that? >>>> >>>> The original description I found here: https://reviews.llvm.org/D20348 <https://reviews.llvm.org/D20348> says that it is possible to exclude a global from the symbol table if three things are true: >>>> This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be broken...

...tion for local_unnamed_addr, the symbol has to be linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. >>> >>> What do you mean that the promotion can break that? >>> >>> The original description I found here: https://reviews.llvm.org/D20348 <https://reviews.llvm.org/D20348> says that it is possible to exclude a global from the symbol table if three things are true: >>> This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be broken with...

...cal_unnamed_addr, the symbol has to be linkonce_odr to be auto hide >>> as well. ThinLTO promotion can break that as well. >>> >>> What do you mean that the promotion can break that? >>> >>> The original description I found here: https://reviews.llvm.org/D20348 says >>> that it is possible to exclude a global from the symbol table if three >>> things are true: >>> >>> - This attribute is present on every instance of the global (which >>> means that the normal rule that the global must have a unique addres...

...cal_unnamed_addr, the symbol has to be linkonce_odr to be auto hide >>> as well. ThinLTO promotion can break that as well. >>> >>> What do you mean that the promotion can break that? >>> >>> The original description I found here: https://reviews.llvm.org/D20348 says >>> that it is possible to exclude a global from the symbol table if three >>> things are true: >>> >>> - This attribute is present on every instance of the global (which >>> means that the normal rule that the global must have a unique addres...

...symbol has to be linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. >>>>> >>>>> What do you mean that the promotion can break that? >>>>> >>>>> The original description I found here: https://reviews.llvm.org/D20348 <https://reviews.llvm.org/D20348> says that it is possible to exclude a global from the symbol table if three things are true: >>>>> This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be bro...

...e linkonce_odr to be auto hide as well. ThinLTO promotion can break that as well. >>>>>> >>>>>> What do you mean that the promotion can break that? >>>>>> >>>>>> The original description I found here: https://reviews.llvm.org/D20348 <https://reviews.llvm.org/D20348> says that it is possible to exclude a global from the symbol table if three things are true: >>>>>> This attribute is present on every instance of the global (which means that the normal rule that the global must have a unique address can be...

...e symbol has to be linkonce_odr to be auto hide >>>> as well. ThinLTO promotion can break that as well. >>>> >>>> What do you mean that the promotion can break that? >>>> >>>> The original description I found here: https://reviews.llvm.org/D20348 says >>>> that it is possible to exclude a global from the symbol table if three >>>> things are true: >>>> >>>> - This attribute is present on every instance of the global (which >>>> means that the normal rule that the global must...

...inkonce_odr to be >>>>> auto hide as well. ThinLTO promotion can break that as well. >>>>> >>>>> What do you mean that the promotion can break that? >>>>> >>>>> The original description I found here: https://reviews.llvm.org/D20348 >>>>> says that it is possible to exclude a global from the symbol table >>>>> if three things are true: >>>>> >>>>> - This attribute is present on every instance of the global (which >>>>> means that the normal rule...

We didn't drop unnamed_addr. I just don't think weakodr_addr + unnamed_addr is safe to hide in all cases. I don't know if I interpreted local_unnamed_addr correctly but I think it is mostly the same in thinLTO for ld64. The code generator only looks at the individual module and ld64 will be in charge of merging all the symbols with autohide. It doesn't really help in this case.

Something I haven't seen mentioned: why are we dropping the unnamed_addr? Can't we preserve it with the weak symbol? Would it be OK to add auto-hide in this case (maybe it would already happen)? Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be