search for: d19385

...nk it'd be impractical to assert on > all > > of them. > > * This is where I ended-up asserting function parameters in a > mechanical manner to some extent (as a result of 40+ warnings about > some object pointers being null). Let's take > http://reviews.llvm.org/D19385 > for instance. > The right fix in that case was to pass the non-null parameter by > reference instead of asserting its value, not unlike what you were > discussing in the previous post (sorry I'm not quoting the right > post here). For the cases where using references...

Hi Apelete, Thanks for trying to help cleanup the LLVM codebase of Clang Static Analyzer warnings. But it seems a lot of the fixes that are being proposed are somewhat mechanical and may be doing the wrong thing in a few ways. * Initializing variables that are only used when initialized through some existing codepath - this can make tools like Memory Sanitizer less useful, because now the value