search for: d11532

Folks, The review of patch http://reviews.llvm.org/D11532 is extremely slow due to the number of hacks, left-overs and general undesired changes and style that the submission has. That happens, and it's ok when the overall direction the patch is going was agreed, and is acceptable as generally good. But this is not the case. To wake up the elephant...

On 28 August 2015 at 18:02, Jason Kim <jasonk at codeaurora.org> wrote: > IMO having to disable 2/3 of the tests means the patch isn't ready yet. Dan is absolutely right. > (*) The tests weren’t all stable to begin with. That's not a reason to break them more. If you can't prove they're correct, you can't prove you broken them more, especially on other arches.

On Tue, Aug 18, 2015 at 8:28 PM, Kostya Serebryany <kcc at google.com> wrote: > +dvyukov > > On Mon, Aug 17, 2015 at 8:37 AM, Renato Golin <renato.golin at linaro.org> > wrote: >> >> Folks, >> >> The review of patch http://reviews.llvm.org/D11532 is extremely slow >> due to the number of hacks, left-overs and general undesired changes >> and style that the submission has. That happens, and it's ok when the >> overall direction the patch is going was agreed, and is acceptable as >> generally good. >> >&gt...