search for: d11213

...Mailing List Subject: Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken I've fixed the obvious bugs I spotted in r242281. These should be pure correctness improvements. I've sent the two patches I'm imagining to address the core issue here: http://reviews.llvm.org/D11213 <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=TDTMPyN-BRKio_S9jhFxP6vHW7gAN3F73DTvS3M46go&s=TjLIFmohippEitr9aFYFcADeLJeQ-z2E_LH0fpsL38Q&e=> http://reviews...

Replying here, but several of the questions raised boil down to "couldn't you make the usage of GetUnderlyingObject conservatively correct?". I'll try and address that. I think this *is* the right approach, but I think it is very hard to do without effectively disabling this part of GlobalsModRef. That is, the easy ways are likely to fire very frequently IMO. The core idea is

...Ref (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=TDTMPyN-BRKio_S9jhFxP6vHW7gAN3F73DTvS3M46go&s=TjLIFmohippEitr9aFYFcADeLJeQ-z2E_LH0fpsL38Q&e=> > > h...

...Ref (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=TDTMPyN-BRKio_S9jhFxP6vHW7gAN3F73DTvS3M46go&s=TjLIFmohippEitr9aFYFcADeLJeQ-z2E_LH0fpsL38Q&e=> > > h...

...Ref (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=TDTMPyN-BRKio_S9jhFxP6vHW7gAN3F73DTvS3M46go&s=TjLIFmohippEitr9aFYFcADeLJeQ-z2E_LH0fpsL38Q&e=> > > h...

...> >> >> >> I've fixed the obvious bugs I spotted in r242281. These should be pure >> correctness improvements. >> >> >> >> I've sent the two patches I'm imagining to address the core issue here: >> >> http://reviews.llvm.org/D11213 >> >> http://reviews.llvm.org/D11214 >> >> >> >> Currently, I have the unsafe alias results disabled by default, but with a >> flag that can re-enable them if needed. I don't feel really strongly about >> which way the default is set -- but that m...

...Ref (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=TDTMPyN-BRKio_S9jhFxP6vHW7gAN3F73DTvS3M46go&s=TjLIFmohippEitr9aFYFcADeLJeQ-z2E_LH0fpsL38Q&e=> > > h...