search for: d02d9c9d

Commit d02d9c9d used pthread_mutex to avoid interleaving output. However, the standard provides flockfile() for grouping related FILE* I/O that must not be interleaved; and that may be lighter-weight than rolling our own locking. Signed-off-by: Eric Blake <eblake@redhat.com> --- Pushing this one; as a rela...

...s with 16 threads > nbdkit: nbd[1]: nbdkit: debug: debug: acquire unload prevention lockstarting worker thread file.0 > > nbdkit: nbd[1]: nbdkit: debug: debug: get_sizestarting worker thread file.2 > > nbdkit: nbd[1]: debug: can_write Here, we have a nice demonstration that commid d02d9c9d works for messages from one process (my debugging was worse without the mutex in errors.c), but no difference when interleaving messages from multiple processes. If we're that worried about it, we could make errors.c create the entire message into a single buffer (prologue, body, and \n), and...

This works OK on x86_64, but fails on our fast new Amberwing (aarch64) machine. I've attached the test-suite.log file, but I'm not very sure what's going wrong from that. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to