search for: d020beec

I still need more soak time on testing, to see whether I can: a) reproduce the hang with patch 2 not applied b) feel confident that patch 2 is sufficient to fix the race, or else determine that I also need to augment the loop condition in the reader thread to additionally break out of the loop when the pipe-to-self sees EOF even when nbd_aio_is_dead() has not yet been satisfied I'm also

...appears to be latent as long as the pipe is non-blocking and the write end is not closed. Fixes: e0d32468 Signed-off-by: Eric Blake <eblake@redhat.com> --- plugins/nbd/nbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index d020beec..e5b8f338 100644 --- a/plugins/nbd/nbd.c +++ b/plugins/nbd/nbd.c @@ -332,9 +332,11 @@ nbdplug_reader (void *handle) /* Check if we were kicked because a command was started */ if (fds[1].revents & POLLIN) { - while (read (h->fds[0], &c, 1) == 1) + int r; + + whi...

...gin nbd> will contain +C<libnbd_vsock=1> if this is the case. For more details on AF_VSOCK, +see L<nbdkit-service(1)/AF_VSOCK>. + =item B<tls=>MODE Selects which TLS mode to use with the server. If no other tls option diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index d020beec..0bb5ff9f 100644 --- a/plugins/nbd/nbd.c +++ b/plugins/nbd/nbd.c @@ -46,6 +46,7 @@ #include <semaphore.h> #include <poll.h> #include <fcntl.h> +#include <sys/socket.h> #include <libnbd.h> @@ -56,6 +57,12 @@ #include "cleanup.h" #include "utils.h&...