search for: cxstring

...en *)malloc(sizeof(CXToken) * CXTokens.size()); memmove(*Tokens, CXTokens.data(), sizeof(CXToken) * CXTokens.size()); Since malloc function can return null pointer and there are no checks for this case, memmove invocation leads to segmentation fault. The same case can be found in tools/libclang/CXString.cpp file in function createDup: char *Spelling = static_cast<char *>(malloc(String.size() + 1)); memmove(Spelling, String.data(), String.size()); Could somebody clarify me if I'm wrong? Thanks, Valeriy -------------- next part -------------- An HTML attachment was scrubbed... URL:...

...llVectorImpl<char>&)': /home/ecsardu/LLVM/llvm/tools/clang/tools/libclang/CIndexUSRs.cpp:820:22: warning: cast from type 'const clang::Decl*' to type 'clang::Decl*' casts away qualifiers llvm[4]: Compiling CXCursor.cpp for Release+Asserts build (PIC) llvm[4]: Compiling CXString.cpp for Release+Asserts build (PIC) llvm[4]: Compiling CXType.cpp for Release+Asserts build (PIC) llvm[4]: Compiling IndexBody.cpp for Release+Asserts build (PIC) llvm[4]: Compiling IndexDecl.cpp for Release+Asserts build (PIC) llvm[4]: Compiling IndexTypeSourceInfo.cpp for Release+Asserts build (P...

...54.6% lib/Target/ARM/MCTargetDesc/ARMMachORelocationInfo.cpp 0.46 0.26 -44.1% lib/DebugInfo/DWARF/DWARFExpression.cpp 0.68 0.38 -43.3% lib/LTO/LTOModule.cpp 2.25 1.33 -41.1% lib/Target/TargetMachine.cpp 1.76 1.10 -37.8% Full list: Clang top 10 Filename Old New Delta tools/libclang/CXString.cpp 1.70 0.25 -85.2% lib/Tooling/CommonOptionsParser.cpp 1.69 0.55 -67.3% lib/AST/StmtViz.cpp 1.02 0.44 -57.4% tools/driver/cc1_main.cpp 2.26 0.97 -57.1% unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% unittests/Tooling/Refactorin...

...pp 0.46 0.26 -44.1% > lib/DebugInfo/DWARF/DWARFExpression.cpp 0.68 0.38 -43.3% > lib/LTO/LTOModule.cpp 2.25 1.33 -41.1% > lib/Target/TargetMachine.cpp 1.76 1.10 -37.8% > > Full list: > <llvm.txt> > > > *Clang top 10* > *Filename Old New Delta* > tools/libclang/CXString.cpp 1.70 0.25 -85.2% > lib/Tooling/CommonOptionsParser.cpp 1.69 0.55 -67.3% > lib/AST/StmtViz.cpp 1.02 0.44 -57.4% > tools/driver/cc1_main.cpp 2.26 0.97 -57.1% > unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% > lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% > unittests/Tooli...

...26 -44.1% > lib/DebugInfo/DWARF/DWARFExpression.cpp 0.68 0.38 -43.3% > lib/LTO/LTOModule.cpp 2.25 1.33 -41.1% > lib/Target/TargetMachine.cpp 1.76 1.10 -37.8% > > Full list: > > <llvm.txt> > > > > *Clang top 10* > *Filename Old New Delta* > tools/libclang/CXString.cpp 1.70 0.25 -85.2% > lib/Tooling/CommonOptionsParser.cpp 1.69 0.55 -67.3% > lib/AST/StmtViz.cpp 1.02 0.44 -57.4% > tools/driver/cc1_main.cpp 2.26 0.97 -57.1% > unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% > lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% > unittests/Tooli...

[Sorry about the crosspost. Since this is a clang build question but the build is invoked from the top-level LLVM directory I'm not sure where the question should go.] I've got a clang build against libstdc++ on Linux but I would really like one built against libc++/libc++abi. In other words I'd like to rebuild clang/llvm with clang using libc++ and libc++abi on Linux. I looked at

...xpression.cpp 0.67 0.38 -43.5% 47.4 34.8 -26.7% lib/Transforms/Utils/ASanStackFrameLayout.cpp 0.52 0.32 -38.8% 41.7 33.7 -19.2% tools/llvm-dwp/llvm-dwp.cpp 2.48 1.53 -38.3% 92.5 55.2 -40.3% Full list: Clang top 10 Filename TimeOld TimeNew Delta SizeOld SizeNew SizeDelta tools/libclang/CXString.cpp 2.25 0.30 -86.9% 85.1 31.7 -62.7% lib/Tooling/CommonOptionsParser.cpp 2.33 0.68 -70.6% 87.1 34.4 -60.5% lib/AST/StmtViz.cpp 1.28 0.48 -62.5% 62.4 39.0 -37.5% tools/driver/cc1_main.cpp 3.05 1.29 -57.8% 93.7 58.6 -37.4% unittests/CodeGen/BufferSourceTest.cpp 4.12 2.62 -36.5% 145.8 1...

...Transforms/Utils/ASanStackFrameLayout.cpp 0.52 0.32 -38.8% 41.7 33.7 > -19.2% > tools/llvm-dwp/llvm-dwp.cpp 2.48 1.53 -38.3% 92.5 55.2 -40.3% > > Full list: > <llvm.txt> > > *Clang top 10* > *Filename TimeOld TimeNew Delta SizeOld SizeNew SizeDelta* > tools/libclang/CXString.cpp 2.25 0.30 -86.9% 85.1 31.7 -62.7% > lib/Tooling/CommonOptionsParser.cpp 2.33 0.68 -70.6% 87.1 34.4 -60.5% > lib/AST/StmtViz.cpp 1.28 0.48 -62.5% 62.4 39.0 -37.5% > tools/driver/cc1_main.cpp 3.05 1.29 -57.8% 93.7 58.6 -37.4% > unittests/CodeGen/BufferSourceTest.cpp 4.12 2.62 -36.5% 1...

Hi, I haven't seen those errors. Clang and LLVM both build with no warnings on the 3 versions of GCC I test with. MSVC reports loads of warnings however. Cheers, James ________________________________________ From: Csaba Raduly [rcsaba at gmail.com] Sent: 23 October 2011 18:44 To: James Molloy Cc: Paul Berube; llvmdev at cs.uiuc.edu Subject: Re: [LLVMdev] build warnings On Sat, Oct 22,

...on.cpp 0.68 0.38 -43.3% >> lib/LTO/LTOModule.cpp 2.25 1.33 -41.1% >> lib/Target/TargetMachine.cpp 1.76 1.10 -37.8% >> >> Full list: >> >> <llvm.txt> >> >> >> >> *Clang top 10* >> *Filename Old New Delta* >> tools/libclang/CXString.cpp 1.70 0.25 -85.2% >> lib/Tooling/CommonOptionsParser.cpp 1.69 0.55 -67.3% >> lib/AST/StmtViz.cpp 1.02 0.44 -57.4% >> tools/driver/cc1_main.cpp 2.26 0.97 -57.1% >> unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% >> lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9%...

...>)` would prevent LLVM from propagating information about the body outside of the function, such as by changing attributes. The motivation is to enable some of the work John is doing in prototyping coroutine support for Swift. * Steve O'Brien created an RFC on [correcting string handling in CXString](http://lists.llvm.org/pipermail/cfe-dev/2018-January/056573.html). It currently peeks past the end of the string allocation to try to determine if the StringRef it was given is a NUL-terminated string. * Discussion has [resumed](http://lists.llvm.org/pipermail/cfe-dev/2018-January/056526.html) on...

...ent.cpp.o > CMakeFiles/libclang.dir/CXCursor.cpp.o > CMakeFiles/libclang.dir/CXCompilationDatabase.cpp.o > CMakeFiles/libclang.dir/CXLoadedDiagnostic.cpp.o > CMakeFiles/libclang.dir/CXSourceLocation.cpp.o > CMakeFiles/libclang.dir/CXStoredDiagnostic.cpp.o > CMakeFiles/libclang.dir/CXString.cpp.o CMakeFiles/libclang.dir/CXType.cpp.o > CMakeFiles/libclang.dir/IndexBody.cpp.o > CMakeFiles/libclang.dir/IndexDecl.cpp.o > CMakeFiles/libclang.dir/IndexTypeSourceInfo.cpp.o > CMakeFiles/libclang.dir/Indexing.cpp.o > CMakeFiles/libclang.dir/IndexingContext.cpp.o ../../../../lib/...

On Sat, Oct 22, 2011 at 12:24 AM, James Molloy wrote: > Hi Paul, > > That should be easy enough, because the LLVM build has no warnings in it! > > Some of us build with -Werror, and even with those of us that don't warnings are not tolerated. You're already seeing all the warnings that are coming out of the build :) So, all the "variable might be used

...ression.cpp 0.68 0.38 -43.3% >> lib/LTO/LTOModule.cpp 2.25 1.33 -41.1% >> lib/Target/TargetMachine.cpp 1.76 1.10 -37.8% >> >> Full list: >> <llvm.txt> >> >> >> Clang top 10 >> Filename Old New Delta >> tools/libclang/CXString.cpp 1.70 0.25 -85.2% >> lib/Tooling/CommonOptionsParser.cpp 1.69 0.55 -67.3% >> lib/AST/StmtViz.cpp 1.02 0.44 -57.4% >> tools/driver/cc1_main.cpp 2.26 0.97 -57.1% >> unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% >> lib/CodeGen/CGLoopInfo.cpp...

- We do indeed have a lot of unnecessary includes around in llvm (or pretty much any other C++ project for that matter). - I want faster builds. - The only way to reliably fight this is indeed automatic tools. - Having the right amount of includes also has documentation value and ideally let's you understand the structure of your project. - However relying on transitive includes works contrary