search for: customwidenlowernod

Hi Duncan, > as well as what Eli said, ReplaceNodeResults requires (IIRC) the new node to > have the same type as the old node, which doesn't seem to be the case > here. Are you sure ? I see ReplaceNodeResults being called from functions such as CustomWidenLowerNode and CustomLowerNode. In the former, we are clearly expecting a change in type, aren't we? Even in the latter, ReplaceNodeResults is called only when the type of the result is not legal. Otherwise, the latter calls LowerOperationWrapper. Thanks, Pranav Qualcomm Innovation Center, Inc. is a me...

Hi Pranav, >> as well as what Eli said, ReplaceNodeResults requires (IIRC) the new node > to >> have the same type as the old node, which doesn't seem to be the case >> here. > > Are you sure ? I see ReplaceNodeResults being called from functions such as > CustomWidenLowerNode and CustomLowerNode. > In the former, we are clearly expecting a change in type, aren't we? yes, but in CustomLowerNode the type shouldn't change. It is bad that the same method (ReplaceNodeResults) is being called with different requirements. CustomLowerNode was the original method,...