search for: customize_main

--- customize/customize_main.ml | 5 ++--- dib/dib.ml | 5 ++--- resize/resize.ml | 13 ++----------- sysprep/sysprep_operation.ml | 5 +---- 4 files changed, 7 insertions(+), 21 deletions(-) diff --git a/customize/customize_main.ml b/customize/customize_main.ml index e161e82..13d40bc 100644...

Move --debug-gc as common option for all the OCaml-based tools, even a couple of them which didn't have it previously. As implementation note, make set_debug_gc private to set_standard_options, as it needed to be moved otherwise, and it is no more required as public function. --- customize/customize_main.ml | 1 - mllib/common_utils.ml | 8 ++++---- mllib/common_utils.mli | 3 --- resize/resize.ml | 1 - sparsify/cmdline.ml | 1 - sysprep/main.ml | 1 - v2v/cmdline.ml | 1 - 7 files changed, 4 insertions(+), 12 deletions(-) diff --git a/custom...

Having SELinux enabled (even if not enforcing) in the appliance causes troubles to applications/libraries that read/write SELinux attributes. --- builder/builder.ml | 6 +++++- customize/customize_main.ml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/builder/builder.ml b/builder/builder.ml index a407924..5195cfd 100644 --- a/builder/builder.ml +++ b/builder/builder.ml @@ -633,7 +633,11 @@ let main () = (match smp with None -> () | Some smp -> g#set_smp smp...

Doing this allows us to remove the Customize_utils module completely, since it becomes empty. Rich.

...uestfs handles and manually apply common options (e.g. debug and trace), use the open_guestfs in Common_utils. This also applies the common options to handles which didn't set them before, so we can inspect also their messages if needed. --- builder/builder.ml | 8 ++------ customize/customize_main.ml | 4 +--- dib/dib.ml | 4 +--- get-kernel/get_kernel.ml | 4 +--- resize/resize.ml | 10 +++------- sparsify/cmdline.ml | 2 +- sparsify/copying.ml | 16 +++++----------- sparsify/in_place.ml | 4 +--- sysprep/main.ml | 4 +-...

...troduce and use a new inspect_mount_root function to mount all the mountpoints of a root in the guest, replacing the same code doing that in different tools. inspect_mount_root_ro is inspect_mount_root with readonly mount option. --- builder/builder.ml | 10 +--------- customize/customize_main.ml | 9 +-------- get-kernel/get_kernel.ml | 9 +-------- mllib/common_utils.ml | 18 ++++++++++++++++++ mllib/common_utils.mli | 11 +++++++++++ sysprep/main.ml | 12 +----------- v2v/test-harness/v2v_test_harness.ml | 9 +--...

...nux state (leading to wrong results), selinux_relabel now bails out if SELinux is enabled in the appliance. As a result of this, virt-builder and virt-customize explicitly disable it if the relabel is enabled. --- appliance/packagelist.in | 1 + builder/builder.ml | 5 +- customize/customize_main.ml | 5 +- daemon/selinux.c | 198 ++++++++++++++++++++++++++++++++++++++++---- generator/actions.ml | 7 ++ 5 files changed, 197 insertions(+), 19 deletions(-) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index e4a9c8b..6336048 100644 --- a/appliance/pack...

Just refactoring, no change. --- sparsify/cmdline.ml | 49 +++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/sparsify/cmdline.ml b/sparsify/cmdline.ml index ce2b913..bd49e71 100644 --- a/sparsify/cmdline.ml +++ b/sparsify/cmdline.ml @@ -98,6 +98,7 @@ read the man page virt-sparsify(1). let check_tmpdir = !check_tmpdir in let

...| 2 +- builder/repository_main.ml | 2 +- common/mltools/getopt_tests.ml | 2 +- common/mltools/machine_readable_tests.ml | 2 +- common/mltools/tools_utils.ml | 9 ++++++++- common/mltools/tools_utils.mli | 10 ++++++++-- customize/customize_main.ml | 2 +- dib/cmdline.ml | 2 +- get-kernel/get_kernel.ml | 2 +- resize/resize.ml | 2 +- sparsify/cmdline.ml | 2 +- sysprep/main.ml | 2 +- v2v/cmdline.ml...

Make print_version_and_exit, long_options, display_short_options, and display_long_options private, as set_standard_options now takes care of handling the job for the common command line options. --- mllib/common_utils.mli | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/mllib/common_utils.mli b/mllib/common_utils.mli index 79032bc..24f8f83 100644 --- a/mllib/common_utils.mli +++

Make use of the additional command line arguments, and API needed to decrypt LUKS partitions. This affects only virt-customize, virt-get-kernel, virt-sparsify, and virt-sysprep, as they are the main OCaml tools interacting with user-provided images. --- customize/customize_main.ml | 5 ++++- customize/virt-customize.pod | 12 ++++++++++++ get-kernel/get_kernel.ml | 5 ++++- get-kernel/virt-get-kernel.pod | 12 ++++++++++++ sparsify/cmdline.ml | 2 +- sparsify/copying.ml | 3 +++ sparsify/in_place.ml | 3 +++ sparsify/virt-sp...

...e always sorted, while some tools didn't had them like that previously: because of this, a couple of ditto markers (as descriptions) don't match what's above them anymore, and thus their full description is put instead. --- builder/cmdline.ml | 18 +----------------- customize/customize_main.ml | 18 +----------------- dib/cmdline.ml | 17 +---------------- get-kernel/get_kernel.ml | 12 ++---------- mllib/common_utils.ml | 19 +++++++++++++++++++ mllib/common_utils.mli | 6 ++++++ resize/resize.ml | 14 +++----------- sparsify/cmdline.ml...

...ing it as "secret" parameter for add-drive, and properly readd it when building URLs in the direct backend. Furthmore, to keep curl- and ssh-based qemu drivers working with authenticated resources, make sure they can accept secrets. Reported in comment #1 of RHBZ#1092583. --- customize/customize_main.ml | 5 +++-- fish/options.c | 6 ++++++ fish/options.h | 1 + fish/uri.c | 26 ++++++++++++++++++++++---- fish/uri.h | 1 + mllib/uRI.ml | 1 + mllib/uRI.mli | 1 + mllib/uri-c.c | 13 +++++...

Also turns the --selinux option of guestfish, guestmount and virt-rescue into a no-op -- it didn't work before so this is effectively no change. --- builder/builder.ml | 6 ----- customize/customize_main.ml | 5 ---- dib/dib.ml | 6 ----- fish/fish.c | 5 ++-- fish/guestfish.pod | 2 +- fuse/guestmount.c | 5 ++-- fuse/guestmount.pod | 2 +- generator/actions.ml | 5 ++++ rescue/rescue.c | 5 ++-- rescue/virt-res...

Also turns the --selinux option of guestfish, guestmount and virt-rescue into a no-op -- it didn't work before so this is effectively no change. --- builder/builder.ml | 6 ----- customize/customize_main.ml | 5 ---- dib/dib.ml | 6 ----- fish/fish.c | 5 ++-- fish/guestfish.pod | 2 +- fuse/guestmount.c | 5 ++-- fuse/guestmount.pod | 2 +- generator/actions.ml | 5 ++++ rescue/rescue.c | 5 ++-- rescue/virt-res...

...Instead, add a generic handler for --debug-gc, which installs an at_exit hook to do the GC consistency check, and which can be called right in the command-line parser. Also adjust all users of --debug-gc to use that handler. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- customize/customize_main.ml | 9 ++------- mllib/common_utils.ml | 4 ++++ mllib/common_utils.mli | 3 +++ resize/resize.ml | 13 ++++--------- sparsify/cmdline.ml | 6 ++---- sparsify/sparsify.ml | 7 ++----- sysprep/main.ml | 13 ++++--------- v2v/cmdline.ml...

...RL for qemu. Accept query string only for http and https protocols, for now. --- Possibly it looks like an ad-hoc solution for http(s), although I'm not sure how it could possibly be generalized somehow (maybe "extra params" which would be the query string for http(s)?). customize/customize_main.ml | 4 ++-- fish/options.c | 6 ++++++ fish/options.h | 1 + fish/uri.c | 27 ++++++++++++++++++++++++--- fish/uri.h | 1 + generator/actions.ml | 11 ++++++++++- mllib/uRI.ml | 1 + mllib/uRI.mli...

...for implementation at a later time. Thanks, Pino Toscano (3): fish: move disk decryption helpers in own file mllib: expose disk decrypt functionalities OCaml tools: add crypto support (RHBZ#1362649) align/Makefile.am | 1 + cat/Makefile.am | 1 + customize/customize_main.ml | 5 +- customize/virt-customize.pod | 12 +++++ df/Makefile.am | 1 + diff/Makefile.am | 1 + edit/Makefile.am | 1 + fish/Makefile.am | 1 + fish/decrypt.c | 102 +++++++++++++++++++++++++++++++++++++++++...

...l | 6 ++--- builder/index.ml | 27 +++++++++------------ builder/list_entries.ml | 20 +++++++--------- common/mlstdutils/std_utils.ml | 18 ++++++++++---- common/mlstdutils/std_utils.mli | 15 +++++++++--- common/mltools/tools_utils.ml | 6 ++--- customize/customize_main.ml | 4 ++-- daemon/inspect_types.ml | 52 ++++++++++++++++++++--------------------- dib/dib.ml | 4 ++-- resize/resize.ml | 6 ++--- sysprep/sysprep_operation.ml | 16 ++++++------- v2v/changeuid.ml | 4 ++-- v2v/cmdline.ml...

[ I realized that we were discussing adding this feature, in various private email, IRC, and this long bugzilla thread: https://bugzilla.redhat.com/show_bug.cgi?id=1060423 That's not how we should do things. Let's discuss it on the mailing list. ] One thing that virt-customize/virt-sysprep/virt-builder have to do is relabel SELinux guests. What we do at the moment