search for: curversion

...atches for all the other content. > > <bitcode_example.patch> > > Does this patch make sense, or am I still missing the main concern? > Michael, Ah I see. So this just becomes a matter of interpretation of bits in the optimization flags. Shouldn't need to promote the CurVersion. Nitpick: 80-cols in BitcodeReader.cpp Since Instruction::FastMathFlags is a class, seems like the constructor could take in Record[OpNum] , and assign the flags. Looking forward to the full patch. Joe

On Nov 14, 2012, at 12:47 PM, Chris Lattner <clattner at apple.com> wrote: > > On Nov 14, 2012, at 12:28 PM, Michael Ilseman <milseman at apple.com> wrote: > >> I think I missed what problem we're trying to solve here. >> >> I'm looking at implementing the bitcode now. I have code to successfully read and write out the LLVM IR textual formal

...t; >> <bitcode_example.patch> >> >> Does this patch make sense, or am I still missing the main concern? >> > > Michael, > > Ah I see. So this just becomes a matter of interpretation of bits in the optimization flags. Shouldn't need to promote the CurVersion. > > Nitpick: 80-cols in BitcodeReader.cpp > > Since Instruction::FastMathFlags is a class, seems like the constructor could take in Record[OpNum] , and assign the flags. > I like the intent, but unfortunately Record[OpNum] is just a uint64_t. The agreement of which bit means wha...

On Nov 14, 2012, at 5:23 PM, Michael Ilseman <milseman at apple.com> wrote: >> Ah I see. So this just becomes a matter of interpretation of bits in the optimization flags. Shouldn't need to promote the CurVersion. >> >> Nitpick: 80-cols in BitcodeReader.cpp >> >> Since Instruction::FastMathFlags is a class, seems like the constructor could take in Record[OpNum] , and assign the flags. >> > > I like the intent, but unfortunately Record[OpNum] is just a uint64_t. The ag...

I attached a working patch of changes to the bitcode reader and writer. This patch references other local changes I have to other parts of the code (e.g. "FastMathFlags"), but shows the general idea I'm going for. When I've ironed out all the bugs, I'll attach a series of patches for all the other content. -------------- next part -------------- A non-text attachment was

On Tue, Apr 4, 2017 at 12:36 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > > On 2017-Apr-04, at 12:12, Peter Collingbourne <peter at pcc.me.uk> wrote: > > On Mon, Apr 3, 2017 at 8:13 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Apr 3, 2017, at 7:08 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: >>