search for: curstate

...top_machine.c > +++ b/kernel/stop_machine.c > @@ -194,7 +194,7 @@ static int multi_cpu_stop(void *data) > /* Simple state machine */ > do { > /* Chill out and ensure we re-read multi_stop_state. */ > - cpu_relax(); > + cpu_relax_yield(); > if (msdata->state != curstate) { > curstate = msdata->state; > switch (curstate) { > -- > 2.5.5 >

...top_machine.c > +++ b/kernel/stop_machine.c > @@ -194,7 +194,7 @@ static int multi_cpu_stop(void *data) > /* Simple state machine */ > do { > /* Chill out and ensure we re-read multi_stop_state. */ > - cpu_relax(); > + cpu_relax_yield(); > if (msdata->state != curstate) { > curstate = msdata->state; > switch (curstate) { > -- > 2.5.5 >

...x ec9ab2f..1eb8266 100644 --- a/kernel/stop_machine.c +++ b/kernel/stop_machine.c @@ -194,7 +194,7 @@ static int multi_cpu_stop(void *data) /* Simple state machine */ do { /* Chill out and ensure we re-read multi_stop_state. */ - cpu_relax(); + cpu_relax_yield(); if (msdata->state != curstate) { curstate = msdata->state; switch (curstate) { -- 2.5.5

...p_machine.c > > @@ -194,7 +194,7 @@ static int multi_cpu_stop(void *data) > > /* Simple state machine */ > > do { > > /* Chill out and ensure we re-read multi_stop_state. */ > > - cpu_relax(); > > + cpu_relax_yield(); > > if (msdata->state != curstate) { > > curstate = msdata->state; > > switch (curstate) { > > -- > > 2.5.5 > > This is the only caller of cpu_relax_yield()? As a step to removing cpu_yield_lowlatency this series is nice so I have no objection. But "general" kernel coders sti...

...gt; @@ -194,7 +194,7 @@ static int multi_cpu_stop(void *data) >>> /* Simple state machine */ >>> do { >>> /* Chill out and ensure we re-read multi_stop_state. */ >>> - cpu_relax(); >>> + cpu_relax_yield(); >>> if (msdata->state != curstate) { >>> curstate = msdata->state; >>> switch (curstate) { >>> -- >>> 2.5.5 >>> > > This is the only caller of cpu_relax_yield()? As of today yes. Right now the yielding (call to hypervisor) in cpu_relax is only done for s390. Some...

...the part where the R check gives a Note * checking R code for possible problems ... NOTE Found the following assignments to the global environment: File ?portableParallelSeeds/R/initPortableStreams.R?: assign("currentStream", n, envir = .GlobalEnv) assign("currentStates", curStates, envir = .GlobalEnv) assign("currentStream", 1L, envir = .GlobalEnv) assign("startStates", runSeeds, envir = .GlobalEnv) assign("currentStates", runSeeds, envir = .GlobalEnv) assign("currentStream", as.integer(currentStream), envir = .GlobalEnv)...

...um stopmachine_state newstate) { /* Reset ack counter. */ - atomic_set(&thread_ack, num_threads); + atomic_set(&thread_ack, atomic_read(&num_threads)); smp_wmb(); state = newstate; } @@ -67,6 +70,8 @@ static int stop_cpu(struct stop_machine_data *smdata) enum stopmachine_state curstate = STOPMACHINE_NONE; int uninitialized_var(ret); + cpu_set(smp_processor_id(), prepared_cpus); + /* Simple state machine */ do { /* Chill out and ensure we re-read stopmachine_state. */ @@ -90,6 +95,7 @@ static int stop_cpu(struct stop_machine_data *smdata) } } while (curstate != STO...

...um stopmachine_state newstate) { /* Reset ack counter. */ - atomic_set(&thread_ack, num_threads); + atomic_set(&thread_ack, atomic_read(&num_threads)); smp_wmb(); state = newstate; } @@ -67,6 +70,8 @@ static int stop_cpu(struct stop_machine_data *smdata) enum stopmachine_state curstate = STOPMACHINE_NONE; int uninitialized_var(ret); + cpu_set(smp_processor_id(), prepared_cpus); + /* Simple state machine */ do { /* Chill out and ensure we re-read stopmachine_state. */ @@ -90,6 +95,7 @@ static int stop_cpu(struct stop_machine_data *smdata) } } while (curstate != STO...

...um stopmachine_state newstate) { /* Reset ack counter. */ - atomic_set(&thread_ack, num_threads); + atomic_set(&thread_ack, atomic_read(&num_threads)); smp_wmb(); state = newstate; } @@ -67,6 +70,8 @@ static int stop_cpu(struct stop_machine_data *smdata) enum stopmachine_state curstate = STOPMACHINE_NONE; int uninitialized_var(ret); + cpu_set(smp_processor_id(), prepared_cpus); + /* Simple state machine */ do { /* Chill out and ensure we re-read stopmachine_state. */ @@ -90,6 +95,7 @@ static int stop_cpu(struct stop_machine_data *smdata) } } while (curstate != STO...

...um stopmachine_state newstate) { /* Reset ack counter. */ - atomic_set(&thread_ack, num_threads); + atomic_set(&thread_ack, atomic_read(&num_threads)); smp_wmb(); state = newstate; } @@ -67,6 +70,8 @@ static int stop_cpu(struct stop_machine_data *smdata) enum stopmachine_state curstate = STOPMACHINE_NONE; int uninitialized_var(ret); + cpu_set(smp_processor_id(), prepared_cpus); + /* Simple state machine */ do { /* Chill out and ensure we re-read stopmachine_state. */ @@ -90,6 +95,7 @@ static int stop_cpu(struct stop_machine_data *smdata) } } while (curstate != STO...

...ces Waiman mentioned, are we also in need of smp_mb() here and/or native_queue_unlock()?. Interestingly I see other cpu stuck at multi_cpu_stop(). (gdb) thr 1 [Switching to thread 1 (Thread 1)]#0 multi_cpu_stop (data=0xffff8802140d1da0) at kernel/stop_machine.c:192 192 if (msdata->state != curstate) { Or is it I am missing something. please let me know if .config need to be shared. > + local_irq_save(flags); > + > + /* > + * check again make sure it didn't become free while > + * we weren't looking. > + */ > + if (ACCESS_ONCE(*ptr) != val) > + goto out;...

...ces Waiman mentioned, are we also in need of smp_mb() here and/or native_queue_unlock()?. Interestingly I see other cpu stuck at multi_cpu_stop(). (gdb) thr 1 [Switching to thread 1 (Thread 1)]#0 multi_cpu_stop (data=0xffff8802140d1da0) at kernel/stop_machine.c:192 192 if (msdata->state != curstate) { Or is it I am missing something. please let me know if .config need to be shared. > + local_irq_save(flags); > + > + /* > + * check again make sure it didn't become free while > + * we weren't looking. > + */ > + if (ACCESS_ONCE(*ptr) != val) > + goto out;...

Peter, here is v2 with some improved patch descriptions and some fixes. The previous version has survived one day of linux-next and I only changed small parts. So unless there is some other issue, feel free to pull (or to apply the patches) to tip/locking. The following changes since commit 07d9a380680d1c0eb51ef87ff2eab5c994949e69: Linux 4.9-rc2 (2016-10-23 17:10:14 -0700) are available in

Peter, here is v2 with some improved patch descriptions and some fixes. The previous version has survived one day of linux-next and I only changed small parts. So unless there is some other issue, feel free to pull (or to apply the patches) to tip/locking. The following changes since commit 07d9a380680d1c0eb51ef87ff2eab5c994949e69: Linux 4.9-rc2 (2016-10-23 17:10:14 -0700) are available in

...a0cad0 "messenger.hotmail.com", server=0, myaddr=0x0, myport=0, async=1) at /build/buildd/tcl8.5-8.5.7/unix/../unix/tclUnixChan.c:2290 status = <value optimized out> sock = <value optimized out> asyncConnect = <value optimized out> curState = <value optimized out> sockaddr = {sin_family = 0, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\000\000\b\000\vp", <incomplete sequence \344\267>} mysockaddr = {sin_family = 51858, sin_port = 47066, sin_addr = { s_addr = 12}, sin_z...

Since Waiman seems incapable of doing simple things; here's my take on the paravirt crap. The first few patches are taken from Waiman's latest series, but the virt support is completely new. Its primary aim is to not mess up the native code. I've not stress tested it, but the virt and paravirt (kvm) cases boot on simple smp guests. I've not done Xen, but the patch should be

Since Waiman seems incapable of doing simple things; here's my take on the paravirt crap. The first few patches are taken from Waiman's latest series, but the virt support is completely new. Its primary aim is to not mess up the native code. I've not stress tested it, but the virt and paravirt (kvm) cases boot on simple smp guests. I've not done Xen, but the patch should be