search for: currentloop

...bug by using > '-verify-dom-info - verify' flags. This happens because, when we fully > unroll a loop, we remove it from the LPM loop queue along with all > analyses related to it. Here is the code responsible for it: > > { > PassManagerPrettyStackEntry X(P, *CurrentLoop->getHeader()); > TimeRegion PassTimer(getPassTimer(P)); > > Changed |= P->runOnLoop(CurrentLoop, *this); > } > LoopWasDeleted = CurrentLoop->isInvalid(); > > if (Changed) > dumpPassInfo(P, MODIFICATION_MSG, ON_LOOP_MSG, >...

...:54 AM, Igor Laevsky <igor at azulsystems.com<mailto:igor at azulsystems.com>> wrote: Hi Michael, Hi Igor, Hi Michael, Hi Michael, What I was referring to is that we can write something like this inside LPPassManager iteration: if (getAnalaysisIfAvaliable<LCSSAVerifier>()) { CurrentLoop->verifyLCSSA(); ) This will have less impact but feels a bit wrong. Originally I didn’t like this idea, but the more I think about it the more I like it. Currently all loop passes use (or should use) getLoopAnalysisUsage to record their pass requirements, so all of them should operate on the sam...

...for all loop passes. It will also require separate verifyPreservedLoopAnalysis(Loop *L). This seems like a cleanest solution. What do you think? What I was referring to is that we can write something like this inside LPPassManager iteration: if (getAnalaysisIfAvaliable<LCSSAVerifier>()) { CurrentLoop->verifyLCSSA(); ) This will have less impact but feels a bit wrong. > > Thanks, > Michael > >> >> — Igor >> >> On 14 Oct 2016, at 01:57, Mikhail Zolotukhin <mzolotukhin at apple.com> wrote: >> >>> Hi Igor, >>> >>>...

Hi Michael, +CC llvm-dev My guess is that it would be rather error prone to pinpoint exact places where we start populating new LPPassManager since it’s created lazily via LoopPass::assignPassManager. So we are risking to miss adding verifiers in some of the LPPassManager’s. One similar idea is to introduce LCSSAVerifier function pass and make LCSSA pass to be dependant on it. That will allow