search for: curlcleanup

...pointer object, add it to the preserved list, and set an on-exit finalizer to clean up the curl multi-handle? As far as I can tell, the internet module is not supposed to be unloaded, so this would not introduce an opportunity to jump to an unmapped address. This makes it possible to avoid adding a CurlCleanup() function to the internet module: Index: src/modules/internet/libcurl.c =================================================================== --- src/modules/internet/libcurl.c (revision 86484) +++ src/modules/internet/libcurl.c (working copy) @@ -55,6 +55,47 @@ static int current_timeout = 0;...

...list, and set an on-exit finalizer to clean up > > the curl multi-handle? As far as I can tell, the internet module is not > > supposed to be unloaded, so this would not introduce an opportunity to > > jump to an unmapped address. This makes it possible to avoid adding a > > CurlCleanup() function to the internet module: > > Cleaning up this way in principle would probably be fine, but R already > has support for re-using connections. Even more, R can download files in > parallel (in a single thread), which particularly helps with bigger > latencies (e.g. typically...

...it to the preserved list, and set an on-exit finalizer to clean up > the curl multi-handle? As far as I can tell, the internet module is not > supposed to be unloaded, so this would not introduce an opportunity to > jump to an unmapped address. This makes it possible to avoid adding a > CurlCleanup() function to the internet module: Cleaning up this way in principle would probably be fine, but R already has support for re-using connections. Even more, R can download files in parallel (in a single thread), which particularly helps with bigger latencies (e.g. typically users connecting from...

...t an on-exit finalizer to clean up >>> the curl multi-handle? As far as I can tell, the internet module is not >>> supposed to be unloaded, so this would not introduce an opportunity to >>> jump to an unmapped address. This makes it possible to avoid adding a >>> CurlCleanup() function to the internet module: >> Cleaning up this way in principle would probably be fine, but R already >> has support for re-using connections. Even more, R can download files in >> parallel (in a single thread), which particularly helps with bigger >> latencies (e.g....

I'd like to raise this again now that 4.4 is out. Below is a more complete patch which includes a function to properly cleanup libcurl when R quits. Implementing this is a little tricky because libcurl is a separate "module" in R, perhaps there is a better way, but this works: view: https://github.com/r-devel/r-svn/pull/166/files patch: