search for: cur_speed

.../subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h index 1fdf3098..b23793a2 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -26,8 +26,9 @@ struct nvkm_pci { } agp; struct { - enum nvkm_pcie_speed speed; - u8 width; + enum nvkm_pcie_speed cur_speed; + enum nvkm_pcie_speed def_speed; + u8 cur_width; } pcie; bool msi; diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c index ee2431a7..b6ebee6f 100644 --- a/drm/nouveau/nvkm/subdev/pci/base.c +++ b/drm/nouveau/nvkm/subdev/pci/base.c @@ -100,6 +100,8 @@ nvk...

...i.h > index 1fdf3098..b23793a2 100644 > --- a/drm/nouveau/include/nvkm/subdev/pci.h > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > @@ -26,8 +26,9 @@ struct nvkm_pci { > } agp; > > struct { > - enum nvkm_pcie_speed speed; > - u8 width; > + enum nvkm_pcie_speed cur_speed; > + enum nvkm_pcie_speed def_speed; > + u8 cur_width; > } pcie; > > bool msi; > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > index ee2431a7..d9fb5a83 100644 > --- a/drm/nouveau/nvkm/subdev/pci/base.c > +++ b/drm/nouveau/n...

...gp100.c +++ b/drm/nouveau/nvkm/subdev/pci/gp100.c @@ -35,6 +35,16 @@ gp100_pci_func = { .wr08 = nv40_pci_wr08, .wr32 = nv40_pci_wr32, .msi_rearm = gp100_pci_msi_rearm, + + .pcie.init = gk104_pcie_init, + .pcie.set_link = gk104_pcie_set_link, + + .pcie.max_speed = gk104_pcie_max_speed, + .pcie.cur_speed = g84_pcie_cur_speed, + + .pcie.set_version = gf100_pcie_set_version, + .pcie.version = gf100_pcie_version, + .pcie.version_supported = gk104_pcie_version_supported, }; int diff --git a/drm/nouveau/nvkm/subdev/pci/priv.h b/drm/nouveau/nvkm/subdev/pci/priv.h index 7009aad86..162ed5dc6 100644 ---...

.../subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h index 1fdf3098..b23793a2 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -26,8 +26,9 @@ struct nvkm_pci { } agp; struct { - enum nvkm_pcie_speed speed; - u8 width; + enum nvkm_pcie_speed cur_speed; + enum nvkm_pcie_speed def_speed; + u8 cur_width; } pcie; bool msi; diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c index ee2431a7..d9fb5a83 100644 --- a/drm/nouveau/nvkm/subdev/pci/base.c +++ b/drm/nouveau/nvkm/subdev/pci/base.c @@ -90,6 +90,8 @@ nvkm_...

While investigating the runpm issues on my GP107 I noticed that something inside devinit makes runpm break. If Nouveau loads up to the point right before doing devinit, runpm works without any issues, if devinit is ran, not anymore. Out of curiousity I even tried to "bisect" devinit by not running it on vbios provided signed PMU image, but on the devinit parser we have inside Nouveau.

CCing linux-pci and Bjorn Helgaas. Maybe we could get better insights on how a reasonable fix would look like. Anyway, to me this entire issue looks like something which has to be fixed on a PCI level instead of inside a driver, so it makes sense to ask the pci folks if they have any better suggestions. Original cover letter: While investigating the runpm issues on my GP107 I noticed that

...bdev/pci.h > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > } agp; > > > > struct { > > - enum nvkm_pcie_speed speed; > > - u8 width; > > + enum nvkm_pcie_speed cur_speed; > > + enum nvkm_pcie_speed def_speed; > > + u8 cur_width; > > } pcie; > > > > bool msi; > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > > index ee2431a7..d9fb5a83 100644 > &g...

...eau/include/nvkm/subdev/pci.h > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > } agp; > > > > > > struct { > > > - enum nvkm_pcie_speed speed; > > > - u8 width; > > > + enum nvkm_pcie_speed cur_speed; > > > + enum nvkm_pcie_speed def_speed; > > > + u8 cur_width; > > > } pcie; > > > > > > bool msi; > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > > > inde...

not much changed since the last time I sent those patches out, but there are a couple of annoying bug fixes, which users would probably never hit unless they do rmmod/modprobe nouveau cycles. Biggest change is that I force the link to a 8.0 speed rather than the speed the GPU came up with. Also this series depends on the PCIe improvement patches I sent out recently. Karol Herbst (4): pci:

...@@ struct nvkm_pci { > > > > > } agp; > > > > > > > > > > struct { > > > > > - enum nvkm_pcie_speed speed; > > > > > - u8 width; > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > + enum nvkm_pcie_speed def_speed; > > > > > + u8 cur_width; > > > > > } pcie; > > > > > > > > > > bool msi; > > > > > diff --git a/drm/nouveau/nvkm/subdev/pci/bas...

...> > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > } agp; > > > > > > > > struct { > > > > - enum nvkm_pcie_speed speed; > > > > - u8 width; > > > > + enum nvkm_pcie_speed cur_speed; > > > > + enum nvkm_pcie_speed def_speed; > > > > + u8 cur_width; > > > > } pcie; > > > > > > > > bool msi; > > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/...

overall the same as the old stuff, but with better namings and tirivialy improved code here and there Karol Herbst (9): pci: add gk104 variant pci: add gf106 variant pci: implement generic code for PCIe speed change pci: implement pcie speed change for tesla pci: implement pcie speed change on Fermi pci: implement PCIe speed change for kepler+ bios/perf: parse the pci speed from the

First three patches are removing ACPI workarounds which should have never landed. The last four are adding a workaround to nouveau which seem to help quite a lot with the RTD3 issues with Nouveau, so let's discuss and get wider testing of those and see if there is any fallout or laptops where the issues don't get fixed. Karol Herbst (7): Revert "ACPI / OSI: Add OEM _OSI string to

...> > > > } agp; > > > > > > > > > > > > struct { > > > > > > - enum nvkm_pcie_speed speed; > > > > > > - u8 width; > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > + u8 cur_width; > > > > > > } pcie; > > > > > > > > > > > > bool msi; > > > > > > diff --git a/d...

overall it is for the most part the same as my older version. I cleaned up some copyright things, so that it is more like the others. Also I moved the print about the max speed supported into preinit and did some other minor cleanups in the 3rd commit. Happy testing (and performance for prime offloading setups) Karol Herbst (9): pci: add gk104 variant pci: add gf106 variant pci: implement

...alarm(0); - atomicio(write, fileno(stdout), "\n", 1); - statbytes = 0; - } +void progressmeter(int flag) +{ + static const char indicator[] = "|/-\\"; + static struct timeval lastupdate; + static off_t lastsize; + struct timeval now, td, wait; + static off_t cursize, cur_speed = 1; + static double temp = 1; + static char speed[MAX_PREFIXLEN] = "0 B"; + double elapsed; + static int ind_value = 0; + float ratio; + int hours, mins, secs, remaining; + char buf[512], eta[20], buf_gauge[MAX_GAUGELEN] = "", filename[512]; + char pre_cursize[M...

Date: Sun, 16 Apr 2023 11:22:23 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (9): debugfs: Move an expression into a function call parameter in nouveau_debugfs_pstate_set() debugfs: Move a variable assignment behind a null pointer check in nouveau_debugfs_pstate_get() debugfs: Use seq_putc() in

...pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width) > +nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width, > + bool save) > { > struct nvkm_subdev *subdev = &pci->subdev; > enum nvkm_pcie_speed cur_speed, max_speed; > @@ -154,8 +171,10 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width) > speed = max_speed; > } > > - pci->pcie.speed = speed; > - pci->pcie.width = width; > + if (save) { > +...

...} agp; > > > > > > > > > > > > > > struct { > > > > > > > - enum nvkm_pcie_speed speed; > > > > > > > - u8 width; > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > + u8 cur_width; > > > > > > > } pcie; > > > > > > > > > > > > > > bool msi; > > > >...

.../pci/pcie.c +++ b/drm/nouveau/nvkm/subdev/pci/pcie.c @@ -163,3 +163,11 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width) return ret; } + +enum nvkm_pcie_speed +nvkm_pcie_get_speed(struct nvkm_pci *pci) +{ + if (!pci || !pci_is_pcie(pci->pdev) || !pci->pcie.cur_speed) + return -ENOSYS; + return pci->func->pcie.cur_speed(pci); +} -- 2.20.1