Displaying 20 results from an estimated 25 matches for "css_init_done".
2019 Jun 12
1
[PATCH v5 4/8] s390/airq: use DMA memory for adapter interrupts
...nit css_bus_init(void)
> ret = cio_dma_pool_init();
> if (ret)
> goto out_unregister_pmn;
> + airq_init();
Ignoring the return code here does not really hurt right now, but we
probably want to change that if we want to consider failures in css
initialization to be fatal.
> css_init_done = 1;
>
> /* Enable default isc for I/O subchannels. */
On the whole, not really anything that needs changes right now, so have
a
Reviewed-by: Cornelia Huck <cohuck at redhat.com>
2019 Jun 11
2
[PATCH v4 4/8] s390/airq: use DMA memory for adapter interrupts
...> @@ -1182,6 +1182,7 @@ static int __init css_bus_init(void)
> ret = cio_dma_pool_init();
> if (ret)
> goto out_unregister_pmn;
> + airq_init();
...but don't check the return code here. Probably a pathological case,
but shouldn't you handle that error as well?
> css_init_done = 1;
>
> /* Enable default isc for I/O subchannels. */
2019 Jun 11
2
[PATCH v4 4/8] s390/airq: use DMA memory for adapter interrupts
...> @@ -1182,6 +1182,7 @@ static int __init css_bus_init(void)
> ret = cio_dma_pool_init();
> if (ret)
> goto out_unregister_pmn;
> + airq_init();
...but don't check the return code here. Probably a pathological case,
but shouldn't you handle that error as well?
> css_init_done = 1;
>
> /* Enable default isc for I/O subchannels. */
2019 Jun 11
0
[PATCH v4 4/8] s390/airq: use DMA memory for adapter interrupts
...k if the
airq_iv_cache is NULL and fail the allocation if it is (to preserve
previous behavior).
I would prefer having a separate discussion on eventually changing
the behavior (e.g. fail css initialization).
Connie, would that work with you? Thanks for spotting this!
Regards,
Halil
> > css_init_done = 1;
> >
> > /* Enable default isc for I/O subchannels. */
>
2019 Jun 03
5
[PATCH v3 2/8] s390/cio: introduce DMA pools to cio
...ister;
> - }
> + if (ret)
> + goto out_unregister_rn;
> + ret = cio_dma_pool_init();
> + if (ret)
> + goto out_unregister_rn;
Don't you also need to unregister the pm notifier on failure here?
Other than that, I noticed only cosmetic issues; seems reasonable to me.
> css_init_done = 1;
>
> /* Enable default isc for I/O subchannels. */
> isc_register(IO_SCH_ISC);
>
> return 0;
> +out_unregister_rn:
> + unregister_reboot_notifier(&css_reboot_notifier);
> out_unregister:
> while (i-- > 0) {
> struct channel_subsystem *css = c...
2019 Jun 03
5
[PATCH v3 2/8] s390/cio: introduce DMA pools to cio
...ister;
> - }
> + if (ret)
> + goto out_unregister_rn;
> + ret = cio_dma_pool_init();
> + if (ret)
> + goto out_unregister_rn;
Don't you also need to unregister the pm notifier on failure here?
Other than that, I noticed only cosmetic issues; seems reasonable to me.
> css_init_done = 1;
>
> /* Enable default isc for I/O subchannels. */
> isc_register(IO_SCH_ISC);
>
> return 0;
> +out_unregister_rn:
> + unregister_reboot_notifier(&css_reboot_notifier);
> out_unregister:
> while (i-- > 0) {
> struct channel_subsystem *css = c...
2019 Jun 03
0
[PATCH v3 2/8] s390/cio: introduce DMA pools to cio
...ool_init();
>> + if (ret)
>> + goto out_unregister_rn;
>
> Don't you also need to unregister the pm notifier on failure here?
Mmh, that was the original intention. Thanks!
>
> Other than that, I noticed only cosmetic issues; seems reasonable to me.
>
>> css_init_done = 1;
>>
>> /* Enable default isc for I/O subchannels. */
>> isc_register(IO_SCH_ISC);
>>
>> return 0;
>> +out_unregister_rn:
>> + unregister_reboot_notifier(&css_reboot_notifier);
>> out_unregister:
>> while (i-- > 0)...
2019 May 23
0
[PATCH v2 4/8] s390/airq: use DMA memory for adapter interrupts
...onsole(void);
diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
index 789f6ecdbbcc..f09521771a32 100644
--- a/drivers/s390/cio/css.c
+++ b/drivers/s390/cio/css.c
@@ -1173,6 +1173,7 @@ static int __init css_bus_init(void)
goto out_unregister;
}
cio_dma_pool_init();
+ airq_init();
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
--
2.13.4
2019 Jun 06
0
[PATCH v4 4/8] s390/airq: use DMA memory for adapter interrupts
...f --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
index 6fc91d534af1..7901c8ed3597 100644
--- a/drivers/s390/cio/css.c
+++ b/drivers/s390/cio/css.c
@@ -1182,6 +1182,7 @@ static int __init css_bus_init(void)
ret = cio_dma_pool_init();
if (ret)
goto out_unregister_pmn;
+ airq_init();
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
--
2.17.1
2019 Apr 09
0
[RFC PATCH 04/12] s390/cio: introduce cio DMA pool
...we can setup our channel subsystem.
> * The struct subchannel's are created during probing.
> @@ -1063,6 +1119,7 @@ static int __init css_bus_init(void)
> unregister_reboot_notifier(&css_reboot_notifier);
> goto out_unregister;
> }
> + cio_dma_pool_init();
> css_init_done = 1;
>
> /* Enable default isc for I/O subchannels. */
2019 Jun 12
0
[PATCH v5 4/8] s390/airq: use DMA memory for adapter interrupts
...f --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
index e0f19f1e82a0..1b867c941b86 100644
--- a/drivers/s390/cio/css.c
+++ b/drivers/s390/cio/css.c
@@ -1184,6 +1184,7 @@ static int __init css_bus_init(void)
ret = cio_dma_pool_init();
if (ret)
goto out_unregister_pmn;
+ airq_init();
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
--
2.17.1
2019 May 29
0
[PATCH v3 4/8] s390/airq: use DMA memory for adapter interrupts
...ff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
index b97618497848..f079c34ab036 100644
--- a/drivers/s390/cio/css.c
+++ b/drivers/s390/cio/css.c
@@ -1173,6 +1173,7 @@ static int __init css_bus_init(void)
ret = cio_dma_pool_init();
if (ret)
goto out_unregister_rn;
+ airq_init();
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
--
2.13.4
2019 May 23
0
[PATCH v2 2/8] s390/cio: introduce DMA pools to cio
...w that the driver core is running, we can setup our channel subsystem.
* The struct subchannel's are created during probing.
@@ -1063,6 +1172,7 @@ static int __init css_bus_init(void)
unregister_reboot_notifier(&css_reboot_notifier);
goto out_unregister;
}
+ cio_dma_pool_init();
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
--
2.13.4
2019 Apr 26
0
[PATCH 05/10] s390/cio: introduce DMA pools to cio
...w that the driver core is running, we can setup our channel subsystem.
* The struct subchannel's are created during probing.
@@ -1063,6 +1163,7 @@ static int __init css_bus_init(void)
unregister_reboot_notifier(&css_reboot_notifier);
goto out_unregister;
}
+ cio_dma_pool_init();
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
--
2.16.4
2019 May 29
0
[PATCH v3 2/8] s390/cio: introduce DMA pools to cio
...oid)
if (ret)
goto out_unregister;
ret = register_pm_notifier(&css_power_notifier);
- if (ret) {
- unregister_reboot_notifier(&css_reboot_notifier);
- goto out_unregister;
- }
+ if (ret)
+ goto out_unregister_rn;
+ ret = cio_dma_pool_init();
+ if (ret)
+ goto out_unregister_rn;
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
isc_register(IO_SCH_ISC);
return 0;
+out_unregister_rn:
+ unregister_reboot_notifier(&css_reboot_notifier);
out_unregister:
while (i-- > 0) {
struct channel_subsystem *css = channel_subsystems[i];
--
2.13.4
2019 Jun 06
0
[PATCH v4 2/8] s390/cio: introduce DMA pools to cio
...id)
if (ret)
goto out_unregister;
ret = register_pm_notifier(&css_power_notifier);
- if (ret) {
- unregister_reboot_notifier(&css_reboot_notifier);
- goto out_unregister;
- }
+ if (ret)
+ goto out_unregister_rn;
+ ret = cio_dma_pool_init();
+ if (ret)
+ goto out_unregister_pmn;
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
isc_register(IO_SCH_ISC);
return 0;
+out_unregister_pmn:
+ unregister_pm_notifier(&css_power_notifier);
+out_unregister_rn:
+ unregister_reboot_notifier(&css_reboot_notifier);
out_unregister:
while (i-- > 0) {
struct chan...
2019 Jun 12
0
[PATCH v5 2/8] s390/cio: introduce DMA pools to cio
...id)
if (ret)
goto out_unregister;
ret = register_pm_notifier(&css_power_notifier);
- if (ret) {
- unregister_reboot_notifier(&css_reboot_notifier);
- goto out_unregister;
- }
+ if (ret)
+ goto out_unregister_rn;
+ ret = cio_dma_pool_init();
+ if (ret)
+ goto out_unregister_pmn;
css_init_done = 1;
/* Enable default isc for I/O subchannels. */
isc_register(IO_SCH_ISC);
return 0;
+out_unregister_pmn:
+ unregister_pm_notifier(&css_power_notifier);
+out_unregister_rn:
+ unregister_reboot_notifier(&css_reboot_notifier);
out_unregister:
while (i-- > 0) {
struct chan...
2019 Jun 06
15
[PATCH v4 0/8] s390: virtio: support protected virtualization
Enhanced virtualization protection technology may require the use of
bounce buffers for I/O. While support for this was built into the virtio
core, virtio-ccw wasn't changed accordingly.
Some background on technology (not part of this series) and the
terminology used.
* Protected Virtualization (PV):
Protected Virtualization guarantees, that non-shared memory of a guest
that operates in PV
2019 Jun 06
15
[PATCH v4 0/8] s390: virtio: support protected virtualization
Enhanced virtualization protection technology may require the use of
bounce buffers for I/O. While support for this was built into the virtio
core, virtio-ccw wasn't changed accordingly.
Some background on technology (not part of this series) and the
terminology used.
* Protected Virtualization (PV):
Protected Virtualization guarantees, that non-shared memory of a guest
that operates in PV
2019 May 29
16
[PATCH v3 0/8] s390: virtio: support protected virtualization
Enhanced virtualization protection technology may require the use of
bounce buffers for I/O. While support for this was built into the virtio
core, virtio-ccw wasn't changed accordingly.
Some background on technology (not part of this series) and the
terminology used.
* Protected Virtualization (PV):
Protected Virtualization guarantees, that non-shared memory of a guest
that operates in PV