search for: cs04

...the virtio spec [1]? At the > moment, I can't see a working draft that includes the new bit. Having it > in the spec would help convince implementors that it's not just a Linux > thing. > > Thanks, > > Will > > [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html Absolutely. Want to contribute a patch? -- MST

...the virtio spec [1]? At the > moment, I can't see a working draft that includes the new bit. Having it > in the spec would help convince implementors that it's not just a Linux > thing. > > Thanks, > > Will > > [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html Absolutely. Want to contribute a patch? -- MST

The spec says: after writing 0 to device_status, the driver MUST wait for a read of device_status to return 0 before reinitializing the device. Cc: stable at vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_modern.c

The spec says: after writing 0 to device_status, the driver MUST wait for a read of device_status to return 0 before reinitializing the device. Cc: stable at vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_modern.c

...he patch accordingly. > > > But I believe the specification says VIRTIO_BLK_T_OUT means direction, so > > OR the two bits together should compliance with the specification. > > I cannot find that in the specification: > > http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1- > 2020002 > > and it would contradict the "The type of the request is either ... or > ..." wording that I quoted from the spec above. > > If you do find something in the spec, please let me know and we can > figure out how to make the spec...

...he patch accordingly. > > > But I believe the specification says VIRTIO_BLK_T_OUT means direction, so > > OR the two bits together should compliance with the specification. > > I cannot find that in the specification: > > http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1- > 2020002 > > and it would contradict the "The type of the request is either ... or > ..." wording that I quoted from the spec above. > > If you do find something in the spec, please let me know and we can > figure out how to make the spec...

...ncludes the new bit. Having it > > > in the spec would help convince implementors that it's not just a Linux > > > thing. > > > > > > Thanks, > > > > > > Will > > > > > > [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html > > > > Absolutely. Want to contribute a patch? > > I could have a look. Is there a git repo for the sources to the working > draft? > > Will Yes, though unfortunately it's svn :( git svn clone --stdlayout https://tools.oasis-open.org/versio...

...ncludes the new bit. Having it > > > in the spec would help convince implementors that it's not just a Linux > > > thing. > > > > > > Thanks, > > > > > > Will > > > > > > [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html > > > > Absolutely. Want to contribute a patch? > > I could have a look. Is there a git repo for the sources to the working > draft? > > Will Yes, though unfortunately it's svn :( git svn clone --stdlayout https://tools.oasis-open.org/versio...

> -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha at redhat.com] > Sent: Thursday, May 31, 2018 6:31 PM > To: Liu, Changpeng <changpeng.liu at intel.com> > Cc: virtualization at lists.linux-foundation.org; cavery at redhat.com; > jasowang at redhat.com; pbonzini at redhat.com; Wang, Wei W > <wei.w.wang at intel.com> > Subject: Re: [PATCH v4]

> -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha at redhat.com] > Sent: Thursday, May 31, 2018 6:31 PM > To: Liu, Changpeng <changpeng.liu at intel.com> > Cc: virtualization at lists.linux-foundation.org; cavery at redhat.com; > jasowang at redhat.com; pbonzini at redhat.com; Wang, Wei W > <wei.w.wang at intel.com> > Subject: Re: [PATCH v4]

...skb->csum_offset); - } else if (skb->ip_summed == CHECKSUM_UNNECESSARY) { - hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID; - } /* else everything is zero */ + } return 0; } and it fixes the issue. [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.pdf

...skb->csum_offset); - } else if (skb->ip_summed == CHECKSUM_UNNECESSARY) { - hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID; - } /* else everything is zero */ + } return 0; } and it fixes the issue. [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.pdf

..., I can't see a working draft that includes the new bit. Having it > > in the spec would help convince implementors that it's not just a Linux > > thing. > > > > Thanks, > > > > Will > > > > [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html > > Absolutely. Want to contribute a patch? I could have a look. Is there a git repo for the sources to the working draft? Will

...cpu_to_virtio32(vblk->vdev, VIRTIO_BLK_T_OUT); ... > But I believe the specification says VIRTIO_BLK_T_OUT means direction, so > OR the two bits together should compliance with the specification. I cannot find that in the specification: http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-2020002 and it would contradict the "The type of the request is either ... or ..." wording that I quoted from the spec above. If you do find something in the spec, please let me know and we can figure out how to make the spec consistent. -------------- next part...

...Changpeng wrote: >>> But I believe the specification says VIRTIO_BLK_T_OUT means direction, so >>> OR the two bits together should compliance with the specification. >> I cannot find that in the specification: >> >> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1- >> 2020002 >> >> and it would contradict the "The type of the request is either ... or >> ..." wording that I quoted from the spec above. >> >> If you do find something in the spec, please let me know and we can >> figure...

...>ip_summed == CHECKSUM_UNNECESSARY) { > - hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID; > - } /* else everything is zero */ > + } > > return 0; > } > and it fixes the issue. > > > [1] http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.pdf I'm inclined to agree with your patch. Could you pls re-submit in a standard way? I'll ack.

...S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Gabriel Somlo (1): firmware: qemu_fw_cfg.c: hold ACPI global lock during device access Michael S. Tsirkin (3): qemu_fw_cfg: don't leak kobj on init error virtio: virtio 1.0 cs04 spec compliance for reset MAINTAINERS: add entry for QEMU Stefan Hajnoczi (1): virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit include/uapi/linux/virtio_config.h | 2 ++ drivers/firmware/qemu_fw_cfg.c | 24 +++++++++++++++++++++++- drivers/virtio/virtio_pci_modern.c |...

...S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Gabriel Somlo (1): firmware: qemu_fw_cfg.c: hold ACPI global lock during device access Michael S. Tsirkin (3): qemu_fw_cfg: don't leak kobj on init error virtio: virtio 1.0 cs04 spec compliance for reset MAINTAINERS: add entry for QEMU Stefan Hajnoczi (1): virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit include/uapi/linux/virtio_config.h | 2 ++ drivers/firmware/qemu_fw_cfg.c | 24 +++++++++++++++++++++++- drivers/virtio/virtio_pci_modern.c |...