search for: crypto_alg

On 12/15/2016 03:03 AM, Gonglei wrote: [...] > + > +static struct crypto_alg virtio_crypto_algs[] = { { > + .cra_name = "cbc(aes)", > + .cra_driver_name = "virtio_crypto_aes_cbc", > + .cra_priority = 501, This is still higher than the hardware-accelerators (like intel aesni or the s390 cpacf functions or the arm hw). aesni and s390/cpacf are s...

On 12/15/2016 03:03 AM, Gonglei wrote: [...] > + > +static struct crypto_alg virtio_crypto_algs[] = { { > + .cra_name = "cbc(aes)", > + .cra_driver_name = "virtio_crypto_aes_cbc", > + .cra_priority = 501, This is still higher than the hardware-accelerators (like intel aesni or the s390 cpacf functions or the arm hw). aesni and s390/cpacf are s...

...ower the priority of virtio-crypto's algorithm, make it's higher than sofeware implimentations but lower than the hardware ones. Suggested-by: Christian Borntraeger <borntraeger at de.ibm.com> Signed-off-by: Gonglei <arei.gonglei at huawei.com> --- drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index 6f40a42..4de4740 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs.c @@ -498,7 +4...

...ower the priority of virtio-crypto's algorithm, make it's higher than sofeware implimentations but lower than the hardware ones. Suggested-by: Christian Borntraeger <borntraeger at de.ibm.com> Signed-off-by: Gonglei <arei.gonglei at huawei.com> --- drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index 6f40a42..4de4740 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs.c @@ -498,7 +4...

On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > Hi, > >> >> On 12/15/2016 03:03 AM, Gonglei wrote: >> [...] >>> + >>> +static struct crypto_alg virtio_crypto_algs[] = { { >>> + .cra_name = "cbc(aes)", >>> + .cra_driver_name = "virtio_crypto_aes_cbc", >>> + .cra_priority = 501, >> >> >> This is still higher than the hardware-accelerators (like intel aesni or the >> s390...

On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > Hi, > >> >> On 12/15/2016 03:03 AM, Gonglei wrote: >> [...] >>> + >>> +static struct crypto_alg virtio_crypto_algs[] = { { >>> + .cra_name = "cbc(aes)", >>> + .cra_driver_name = "virtio_crypto_aes_cbc", >>> + .cra_priority = 501, >> >> >> This is still higher than the hardware-accelerators (like intel aesni or the >> s390...

...engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue any type of crypto_async_request. > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> This is going the wrong way. We do not want to expose any of the base types such as crypto_alg, crypto_async_request to end-users and that includes drivers. Only core API code should touch these base types. Cheers, -- Email: Herbert Xu <herbert at gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

...engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue any type of crypto_async_request. > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> This is going the wrong way. We do not want to expose any of the base types such as crypto_alg, crypto_async_request to end-users and that includes drivers. Only core API code should touch these base types. Cheers, -- Email: Herbert Xu <herbert at gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

...n 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > >> Hi, > >> > >>> > >>> On 12/15/2016 03:03 AM, Gonglei wrote: > >>> [...] > >>>> + > >>>> +static struct crypto_alg virtio_crypto_algs[] = { { > >>>> + .cra_name = "cbc(aes)", > >>>> + .cra_driver_name = "virtio_crypto_aes_cbc", > >>>> + .cra_priority = 501, > >>> > >>> > >>> This is still higher than the hardwar...

...n 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > >> Hi, > >> > >>> > >>> On 12/15/2016 03:03 AM, Gonglei wrote: > >>> [...] > >>>> + > >>>> +static struct crypto_alg virtio_crypto_algs[] = { { > >>>> + .cra_name = "cbc(aes)", > >>>> + .cra_driver_name = "virtio_crypto_aes_cbc", > >>>> + .cra_priority = 501, > >>> > >>> > >>> This is still higher than the hardwar...

Hi, > > On 12/15/2016 03:03 AM, Gonglei wrote: > [...] > > + > > +static struct crypto_alg virtio_crypto_algs[] = { { > > + .cra_name = "cbc(aes)", > > + .cra_driver_name = "virtio_crypto_aes_cbc", > > + .cra_priority = 501, > > > This is still higher than the hardware-accelerators (like intel aesni or the > s390 cpacf functions or the...

On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: >> Hi, >> >>> >>> On 12/15/2016 03:03 AM, Gonglei wrote: >>> [...] >>>> + >>>> +static struct crypto_alg virtio_crypto_algs[] = { { >>>> + .cra_name = "cbc(aes)", >>>> + .cra_driver_name = "virtio_crypto_aes_cbc", >>>> + .cra_priority = 501, >>> >>> >>> This is still higher than the hardware-accelerators (like intel aes...

...software > implimentations but lower than the hardware ones. implementations > > Suggested-by: Christian Borntraeger <borntraeger at de.ibm.com> > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > --- > drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c > index 6f40a42..4de4740 100644 > --- a/drivers/crypto/virtio/virtio_crypto_algs.c > +++ b/drivers/crypto/virtio/vir...

...lower than the hardware ones. Suggested-by: Christian Borntraeger <borntraeger at de.ibm.com> Signed-off-by: Gonglei <arei.gonglei at huawei.com> Acked-by: Christian Borntraeger <borntraeger at de.ibm.com> --- v2: fix three typos. [Christian] --- drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index 6f40a42..4de4740 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs.c @@ -498,7 +4...

...queue hash and ablkcipher request. > > This patch permit it to enqueue any type of crypto_async_request. > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> > > This is going the wrong way. We do not want to expose any of the > base types such as crypto_alg, crypto_async_request to end-users > and that includes drivers. Only core API code should touch these > base types. > Hello It's you that was suggesting using crypto_async_request: https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1474434.html "The only wart with...

...lower than the hardware ones. Suggested-by: Christian Borntraeger <borntraeger at de.ibm.com> Signed-off-by: Gonglei <arei.gonglei at huawei.com> Acked-by: Christian Borntraeger <borntraeger at de.ibm.com> --- v2: fix three typos. [Christian] --- drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index 6f40a42..4de4740 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs.c @@ -498,7 +4...

...i.com> Signed-off-by: Longpeng(Mike) <longpeng2 at huawei.com> Link: https://lore.kernel.org/r/20200602070501.2023-3-longpeng2 at huawei.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Sasha Levin <sashal at kernel.org> --- drivers/crypto/virtio/virtio_crypto_algs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index e2231a1a05a1..772d2b3137c6 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs...

...Cc: Baolin Wang <baolin.wang at linaro.org> Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Gonglei <arei.gonglei at huawei.com> --- drivers/crypto/virtio/Kconfig | 1 + drivers/crypto/virtio/virtio_crypto_algs.c | 52 ++++++++++++------- drivers/crypto/virtio/virtio_crypto_common.h | 16 ++++++ drivers/crypto/virtio/virtio_crypto_core.c | 74 ++++++++++++++++++++++++++-- 4 files changed, 121 insertions(+), 22 deletions(-) diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig in...

...Cc: Baolin Wang <baolin.wang at linaro.org> Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Gonglei <arei.gonglei at huawei.com> --- drivers/crypto/virtio/Kconfig | 1 + drivers/crypto/virtio/virtio_crypto_algs.c | 52 ++++++++++++------- drivers/crypto/virtio/virtio_crypto_common.h | 16 ++++++ drivers/crypto/virtio/virtio_crypto_core.c | 74 ++++++++++++++++++++++++++-- 4 files changed, 121 insertions(+), 22 deletions(-) diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig in...

..."Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Gonglei <arei.gonglei at huawei.com> Cc: virtualization at lists.linux-foundation.org Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org> --- drivers/crypto/virtio/virtio_crypto_algs.c | 187 ++++++++++---------- drivers/crypto/virtio/virtio_crypto_common.h | 2 +- 2 files changed, 92 insertions(+), 97 deletions(-) diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index 82b316b2f537..4b71e80951b7 100644 --- a/drivers/cryp...