search for: createwincoffobjectwrit

...typedefs? 5. For the following bit (and a few others in the same function): + for (i = Sections.begin(), j = Asm.begin(); + (i != Sections.end()) && (j != Asm.end()); + i++, j++) { http://llvm.org//docs/CodingStandards.html#ll_end 6. +namespace llvm { MCObjectWriter * createWinCOFFObjectWriter (raw_ostream & OS); } If you need a function to be visible across files, use a header; shortcuts like this make the code more difficult to read. -Eli

...> + for (i = Sections.begin(), j = Asm.begin(); > + (i != Sections.end()) && (j != Asm.end()); > + i++, j++) { > > http://llvm.org//docs/CodingStandards.html#ll_end > > I will recode those statements. > 6. > +namespace llvm { MCObjectWriter * createWinCOFFObjectWriter > (raw_ostream & OS); } > > If you need a function to be visible across files, use a header; > shortcuts like this make the code more difficult to read. > > On this one, it didn't seem appropriate to include WinCOFFObjectWriters header into X86AsmBackend, it also seems t...

Hi guys, I have attached my patch to support generating win32 COFF object files. I would have posted earlier, but my system drive crashed and I had to rebuild my system; Luckily, my source code was on a secondary drive. I think this would be a good beginning for ongoing support of the COFF object file format and was hoping for some feedback as to whether it was commit worthy or what was needed to

...d2night at gmail.com> >To: Eli Friedman <eli.friedman at gmail.com> >Cc: LLVM Dev <llvmdev at cs.uiuc.edu> >Sent: Thu, May 20, 2010 11:43:30 AM >Subject: Re: [LLVMdev] Win32 COFF Support > > > > >>>6. >>>>+namespace llvm { MCObjectWriter * createWinCOFFObjectWriter >>>>(raw_ostream & OS); } >> >>>>If you need a function to be visible across files, use a header; >>>>shortcuts like this make the code more difficult to read. >> >> > >On this one, it didn't seem appropriate to include WinCOFFO...