search for: createrecord

The attached patch removes Record::createRecord(...) and its uses from trunk, and includes previous code style fixes. On Dec 12, 2010, at 21:52, Garrison Venn wrote: > ... > >> >> Another random question: why is createRecord better than using "new Record"? If createRecord is better, it would be good to make the...

...rences(...) need a context containing a RecordKeeper for their evaluation. A cursory glance for the uses of Record::setName(...) seems to imply that adding a RecordKeeper& argument would not be an issue. I'll keep on looking for other mechanisms. > > Another random question: why is createRecord better than using "new Record"? If createRecord is better, it would be good to make the Record ctor private so the code doesn't evolve into sometimes using one and sometimes using the other. This was another syntactic hack. I personally prefer the factory approach, but I cannot as i...

...per. This looks like great progress to me, applied in r121659. That said, it is suboptimal for Record to have to have a RecordKeeper& in it. I haven't looked at the code in a long time, is it feasible to detangle that out of record, or is it not worth it? Another random question: why is createRecord better than using "new Record"? If createRecord is better, it would be good to make the Record ctor private so the code doesn't evolve into sometimes using one and sometimes using the other. Some minor coding style things: + RecordKeeper &getRecords() const { + return(Track...

Hey Chris, The following patch removes all global references to a RecordKeeper instance for the tblgen utility. This effort was motivated by the FIXME remark, in TableGen.cpp. Although a few files were touched, the main change was to Record.h. The patch takes the simple approach of adding a RecordKeeper reference to TGParser, and any needed emitter helper classes. In addition, since some of

...ext containing a RecordKeeper > for their evaluation. A cursory glance for the uses of Record::setName(...) seems to imply that adding a > RecordKeeper& argument would not be an issue. I'll keep on looking for other mechanisms. > >> >> Another random question: why is createRecord better than using "new Record"? If createRecord is better, it would be good to make the Record ctor private so the code doesn't evolve into sometimes using one and sometimes using the other. > > This was another syntactic hack. I personally prefer the factory approach, but I c...

...lation. kernel32: Clear the extra memory in LocalReAlloc16(h, bigger_size, LMEM_ZEROINIT). Misha Koshelev (44): msi/tests: automation: Add tests for Session::EvaluateCondition. msi: automation: Implement Session::EvaluateCondition. msi/tests: automation: Test for Installer::CreateRecord error. msi: automation: Implement Installer::CreateRecord. msi/tests: automation: Test invoking methods as properties & vice versa. msi: automation: Return DISP_E_MEMBERNOTFOUND if flags are incorrect. msi: automation: Implement Record::FieldCount. msi/tests: autom...

...nterface. oleview: Remove many casts. winnt.h: Add defines for SLIST_HEADER. msi: Add a test showing MsiGetProperty returns correct values. msi: Factor out code to calculate column offsets. msi: Add the generated typelib to the resources. msi: Test the dispid for CreateRecord. ole32: Add a few more tests for transacted storage. widl: Implement dispinterfaces derived from an interface. msi: Add a test for the version method. msi: Register the typelib. msiexec: Catch the -Embedding flag and print out a message. msi: Split process_handle...

...table column info. msi: Add a NULL terminator to file->dest after reallocation. msi: Fix a handle leak in the record tests. msi: Close the original record before copying new data into it. msi: Stub out a few more Installer object methods. msi: Refactor the Installer.CreateRecord method into InstallerImpl_CreateRecord. msi: Refactor the Installer.OpenPackage method into InstallerImpl_OpenPackage. msi: Refactor Installer.OpenProduct and Installer.OpenDatabase into respective functions. msi: Refactor the Installer.SummaryInformation method to InstallerImpl_S...