search for: createprinterpass

...avid Greene wrote: > On Sunday 14 March 2010 18:32:35 Chris Lattner wrote: > > This is much better than the first iteration but still has many issues. I believe I've addressed all your points with this patch except I didn't use StringRef. It doesn't appear to be useful since createPrinterPass will be sent a const std::string & and will feed a constant std::string & in the create*PrinterPass interfaces. Any additional feedback from anyone? -Dave -------------- next part -------------- A non-text attachment was scrubbed... Name:...

...;> On Sunday 14 March 2010 18:32:35 Chris Lattner wrote: >>> This is much better than the first iteration but still has many issues. > > I believe I've addressed all your points with this patch except I didn't use > StringRef. It doesn't appear to be useful since createPrinterPass will > be sent a const std::string & and will feed a constant std::string & > in the create*PrinterPass interfaces. > > Any additional feedback from anyone? This is looking much better, thanks. I'd still prefer using StringRef instead of std::string here because it cleans...

...> On Sunday 14 March 2010 18:32:35 Chris Lattner wrote: > > > This is much better than the first iteration but still has many issues. > > I believe I've addressed all your points with this patch except I didn't > use StringRef. It doesn't appear to be useful since createPrinterPass will > be sent a const std::string & and will feed a constant std::string & in the > create*PrinterPass interfaces. > > Any additional feedback from anyone? Ping? -Dave

...hris Lattner wrote: > > > > This is much better than the first iteration but still has many > > > > issues. > > > > I believe I've addressed all your points with this patch except I didn't > > use StringRef. It doesn't appear to be useful since createPrinterPass > > will be sent a const std::string & and will feed a constant std::string & > > in the create*PrinterPass interfaces. > > > > Any additional feedback from anyone? > > Ping? Ping? -Dave

...MachineFunctionPrinterPass.h includes <string> somewhere along > the line. This is much better than the first iteration but still has many issues. There is no need to keep cc'ing cfe-dev on these patches which have nothing to do with clang. Please rename the getPrinterPass method to createPrinterPass to indicate that the result returns a new pass, not returning an existing one. Please make it take a StringRef, not an std::string and eliminate the <string> #include from Pass.h. MachineFunctionPrinterPass.h doesn't need to #include MachineFunctionPass.h, just use a forward declaration...

...35 Chris Lattner wrote: > This is much better than the first iteration but still has many issues. > There is no need to keep cc'ing cfe-dev on these patches which have nothing > to do with clang. There's a clang patch in this set. > Please rename the getPrinterPass method to createPrinterPass to indicate > that the result returns a new pass, not returning an existing one. Please Ok. > make it take a StringRef, not an std::string and eliminate the <string> > #include from Pass.h. Ok. > MachineFunctionPrinterPass.h doesn't need to #include > MachineFunctionPa...

...efore-all, etc. The filename was constructed by massaging the pass name to comply with file system naming conventions and prepending a monotonically increasing integer (with suitable leading zeros) plus "bef" or "aft" to indicate sequencing. The only awkward part was modifying createPrinterPass to accept a filename, which had to be done because otherwise you end up having to keep each stream open from the time you setup the pass pipeline until the printing pass actually runs. -Troy ________________________________ From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of m...

...dich/ParallelAssert/llvm-objects/tools/opt/Debug+Asserts/PrintSCC.o /n/fs/scratch/tpondich/ParallelAssert/llvm-objects/tools/opt/Debug+Asserts/opt.o \ -lLLVM-2.9svn -lpthread -lmalloc -lm Undefined first referenced symbol in file llvm::LoopPass::createPrinterPass(llvm::raw_ostream&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const/n/fs/scratch/tpondich/ParallelAssert/llvm-objects/tools/opt/Debug+Asserts/opt.o llvm::createBasicAliasAnalysisPass() /n/fs/scratch/tpondich/ParallelAssert/llvm-objects/...

...e the end of the anon namespace up. It might also be better to just > make this take a list of strings, which would allow you to collapse these > to support -print-before=all and -print-after=all. Interesting idea. I'll think about it for a follow-on patch. > +Pass *BasicBlockPass::createPrinterPass(raw_ostream &O, > + const std::string &Banner) const { > + return createPrintFunctionPass(Banner, &O); > +} > + > > This will disrupt the pass structure. The printer should be a > BasicBlockPass. However, BasicBlockPass is pr...

...Module LLVMHello.so ld: 0706-027 The -R $ORIGIN flag is ignored. ld: 0711-317 ERROR: Undefined symbol: llvm::Pass::getPassName() const ld: 0711-317 ERROR: Undefined symbol: llvm::Pass::print(llvm::raw_ostream&, llvm::Module const*) const ld: 0711-317 ERROR: Undefined symbol: llvm::FunctionPass::createPrinterPass(llvm::raw_ostream&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const ld: 0711-317 ERROR: Undefined symbol: llvm::FunctionPass::assignPassManager(llvm::PMStack&, llvm::PassManagerType) ld: 0711-317 ERROR: Undefined symbol: llvm::Pass:...

On Friday 12 March 2010 08:13:05 Kalle Raiskila wrote: > David Greene wrote: > > Here's a rework using PassManager as Chris suggested. Comments? > > Tried this second patch with the svn version 97812 (the one the patch is > made against), but it doesn't compile: > "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&" >

David Greene wrote: > Here's a rework using PassManager as Chris suggested. Comments? Tried this second patch with the svn version 97812 (the one the patch is made against), but it doesn't compile: "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&" token" Seems raw_ostream is forward declared but not defined (adding a missing #include

Hi All, I am trying to build llvm on AIX. I installed all the required packages including gcc, g++, etc ./configure also went fine. but i tried to run gmake, i got the following error: llvm[1]: Compiling MemoryBuffer.cpp for Release+Asserts build llvm[1]: Compiling MemoryObject.cpp for Release+Asserts build llvm[1]: Compiling Mutex.cpp for Release+Asserts build llvm[1]: Compiling Path.cpp for

Hello, Just an update on that. I am personally using -git-commit-after-all *as-is* extremely frequently (combined with "git filter-branch" and "opt -S -instnamer" it is extremely useful). I unfortunately won't have time to write a better implementation of that, and I agree "git fast-import" seems the way to go. If anybody is motivated enough to do so, feel free.