Displaying 6 results from an estimated 6 matches for "create_v2v_directory".
2023 Jun 29
1
[v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard
...to %d:root" file uid;
+ Unix.chown file uid 0
(* Get the local user that libvirt uses to run qemu when we are
* running as root. This is returned as an optional string
@@ -205,8 +199,8 @@ let error_if_no_ssh_agent () =
(* Create the directory containing inX and outX sockets. *)
let create_v2v_directory () =
let d = Mkdtemp.temp_dir "v2v." in
- chown_for_libvirt_rhbz_1045069 d;
On_exit.rm_rf d;
+ chown_for_libvirt_rhbz_1045069 d;
d
(* Wait for a file to appear until a timeout. *)
2023 Jun 29
1
[v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard
...und the 'then' clause?
> (* Get the local user that libvirt uses to run qemu when we are
> * running as root. This is returned as an optional string
> @@ -205,8 +199,8 @@ let error_if_no_ssh_agent () =
> (* Create the directory containing inX and outX sockets. *)
> let create_v2v_directory () =
> let d = Mkdtemp.temp_dir "v2v." in
> - chown_for_libvirt_rhbz_1045069 d;
> On_exit.rm_rf d;
> + chown_for_libvirt_rhbz_1045069 d;
> d
Yes, as you explain in the commit message this hunk is needed (and
dependent) because the chown might now fail.
Rich.
-...
2023 Jun 29
1
[v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard
...pe).
>
>> (* Get the local user that libvirt uses to run qemu when we are
>> * running as root. This is returned as an optional string
>> @@ -205,8 +199,8 @@ let error_if_no_ssh_agent () =
>> (* Create the directory containing inX and outX sockets. *)
>> let create_v2v_directory () =
>> let d = Mkdtemp.temp_dir "v2v." in
>> - chown_for_libvirt_rhbz_1045069 d;
>> On_exit.rm_rf d;
>> + chown_for_libvirt_rhbz_1045069 d;
>> d
>
> Yes, as you explain in the commit message this hunk is needed (and
> dependent) because...
2023 Jun 29
1
[v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard
...(* Get the local user that libvirt uses to run qemu when we are
> >> * running as root. This is returned as an optional string
> >> @@ -205,8 +199,8 @@ let error_if_no_ssh_agent () =
> >> (* Create the directory containing inX and outX sockets. *)
> >> let create_v2v_directory () =
> >> let d = Mkdtemp.temp_dir "v2v." in
> >> - chown_for_libvirt_rhbz_1045069 d;
> >> On_exit.rm_rf d;
> >> + chown_for_libvirt_rhbz_1045069 d;
> >> d
> >
> > Yes, as you explain in the commit message this hunk is n...
2023 Jun 29
1
[v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard
...local user that libvirt uses to run qemu when we are
>>>> * running as root. This is returned as an optional string
>>>> @@ -205,8 +199,8 @@ let error_if_no_ssh_agent () =
>>>> (* Create the directory containing inX and outX sockets. *)
>>>> let create_v2v_directory () =
>>>> let d = Mkdtemp.temp_dir "v2v." in
>>>> - chown_for_libvirt_rhbz_1045069 d;
>>>> On_exit.rm_rf d;
>>>> + chown_for_libvirt_rhbz_1045069 d;
>>>> d
>>>
>>> Yes, as you explain in the commit me...
2023 Jun 29
3
[v2v PATCH v2 0/3] improve UX when running as root and we can't chown
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024
v1 was here:
<https://listman.redhat.com/archives/libguestfs/2023-June/031910.html>.
Make any "chown_for_libvirt_rhbz_1045069" failure a hard one; that way
the user gets to see more direct and more uniform error messages (namely
that we couldn't connect to libvirt).
Document those connection problems, and a simple