search for: create_transf

...ization. The import fail with: nbdkit: python[1]: error: /home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py: open: error: Traceback (most recent call last):    File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 109, in open     transfer = create_transfer(connection, disk, host)    File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 539, in create_transfer     "transfer %s was paused by system" % transfer.id)  RuntimeError: transfer 32b97384-ac8b-40d5-b423-26d31faabe32 was paused by system I could...

...t; > > nbdkit: python[1]: error: /home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py: open: error: Traceback (most recent call last): > > File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 109, in open > > transfer = create_transfer(connection, disk, host) > > File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 539, in create_transfer > > "transfer %s was paused by system" % transfer.id) > > RuntimeError: transfer 32b97384-ac8b-40d5-b423-26d31faabe32...

...fail with: > > nbdkit: python[1]: error: /home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py: open: error: Traceback (most recent call last): >    File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 109, in open >     transfer = create_transfer(connection, disk, host) >    File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 539, in create_transfer >     "transfer %s was paused by system" % transfer.id) >  RuntimeError: transfer 32b97384-ac8b-40d5-b423-26d31faabe32 was paused by...

...s/2019-November/msg00060.html Nir Soffer (11): rhv-upload: Cancel transfer if finalize failed rhv-upload: Keep disk_id in handle rhv-upload: Show disk id in error message rhv-upload: Don't keep transfer_service in handle rhv-upload: Get host before creating disk rhv-upload: Extract create_transfer() function rhv-upload: Show transfer id in error message rhv-upload: Extract imageio helpers rhv-upload: Extract get_options() helper rhv-upload: Extract optimize_http() helper rhv-upload: Clean up username and password v2v/rhv-upload-plugin.py | 325 ++++++++++++++++++++++------------...

...t; > > nbdkit: python[1]: error: /home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py: open: error: Traceback (most recent call last): > > File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 109, in open > > transfer = create_transfer(connection, disk, host) > > File "/home/nsoffer/src/virt-v2v/tmp/rhvupload.1DgXyh/rhv-upload-plugin.py", line 539, in create_transfer > > "transfer %s was paused by system" % transfer.id) > > RuntimeError: transfer 32b97384-ac8b-40d5-b423-26d31faabe32...

Fix NameError introduced by inocomplete change to extract create_transfer() by extracting cancel_transfer() function. Finally extract finallize_transfer() function, dealing with the poorly documented and over complicated oVirt SDK. Tested with: libguestfs-1.40.2-4.fc30.x86_64 nbdkit-1.12.8-1.fc30.x86_64 Tested flows: - Successful import - Error in close() - by injec...

...http = optimize_http(http, host, options) > except: > - transfer_service.cancel() > + cancel_transfer(connection, transfer) > raise > > debug("imageio features: flush=%(can_flush)r trim=%(can_trim)r " > @@ -531,6 +531,16 @@ def create_transfer(connection, disk, host): > > return transfer > > +def cancel_transfer(connection, transfer): > + """ > + Cancel a transfer, removing the transfer disk. > + """ > + debug("canceling transfer %s" % transfer.id) > +...

...age, we should use the estimated + # size, based on qemu-img measure of the overlay. initial_size = params['disk_size'], provisioned_size = params['disk_size'], # XXX Ignores params['output_sparse']. @@ -497,11 +500,16 @@ def create_transfer(connection, disk, host): system_service = connection.system_service() transfers_service = system_service.image_transfers_service() + extra = {} + if transfer_supports_format(): + extra["format"] = types.DiskFormat.RAW + transfer = transfers_service.add(...

...gt; rhv-upload: Cancel transfer if finalize failed > > rhv-upload: Keep disk_id in handle > > rhv-upload: Show disk id in error message > > rhv-upload: Don't keep transfer_service in handle > > rhv-upload: Get host before creating disk > > rhv-upload: Extract create_transfer() function > > rhv-upload: Show transfer id in error message > > rhv-upload: Extract imageio helpers > > rhv-upload: Extract get_options() helper > > rhv-upload: Extract optimize_http() helper > > rhv-upload: Clean up username and password > > > > I&...

...rhv-upload: Don't keep disk_service in handle rhv-upload: Extract create_disk() function rhv-upload: Try to remove disk on timeout rhv-upload: Keep disk_id in handle rhv-upload: Don't keep transfer_service in handle rhv-upload: Get host before creating disk rhv-upload: Extract create_transfer() function rhv-upload: Extract imageio helpers rhv-upload: Extract get_options() helper rhv-upload: Extract optimize_http() helper rhv-upload: Clean up username and password v2v/rhv-upload-plugin.py | 550 +++++++++++++++++++++------------------ 1 file changed, 295 insertions(+), 255 de...

...isk_service in handle > rhv-upload: Extract create_disk() function > rhv-upload: Try to remove disk on timeout > rhv-upload: Keep disk_id in handle > rhv-upload: Don't keep transfer_service in handle > rhv-upload: Get host before creating disk > rhv-upload: Extract create_transfer() function > rhv-upload: Extract imageio helpers > rhv-upload: Extract get_options() helper > rhv-upload: Extract optimize_http() helper > rhv-upload: Clean up username and password > > v2v/rhv-upload-plugin.py | 550 +++++++++++++++++++++------------------ > 1 file...

..._options(http, destination_url) http = optimize_http(http, host, options) except: - transfer_service.cancel() + cancel_transfer(connection, transfer) raise debug("imageio features: flush=%(can_flush)r trim=%(can_trim)r " @@ -531,6 +531,16 @@ def create_transfer(connection, disk, host): return transfer +def cancel_transfer(connection, transfer): + """ + Cancel a transfer, removing the transfer disk. + """ + debug("canceling transfer %s" % transfer.id) + transfer_service = (connection.system_...

...age, we should use the estimated + # size, based on qemu-img measure of the overlay. initial_size = params['disk_size'], provisioned_size = params['disk_size'], # XXX Ignores params['output_sparse']. @@ -489,11 +492,16 @@ def create_transfer(connection, disk, host): system_service = connection.system_service() transfers_service = system_service.image_transfers_service() + extra = {} + if transfer_supports_format(): + extra["format"] = types.DiskFormat.RAW + transfer = transfers_service.add(...

...t; >Nir Soffer (11): > rhv-upload: Cancel transfer if finalize failed > rhv-upload: Keep disk_id in handle > rhv-upload: Show disk id in error message > rhv-upload: Don't keep transfer_service in handle > rhv-upload: Get host before creating disk > rhv-upload: Extract create_transfer() function > rhv-upload: Show transfer id in error message > rhv-upload: Extract imageio helpers > rhv-upload: Extract get_options() helper > rhv-upload: Extract optimize_http() helper > rhv-upload: Clean up username and password > I'm not sure which one of these is ca...

...failed > >> > rhv-upload: Keep disk_id in handle > >> > rhv-upload: Show disk id in error message > >> > rhv-upload: Don't keep transfer_service in handle > >> > rhv-upload: Get host before creating disk > >> > rhv-upload: Extract create_transfer() function > >> > rhv-upload: Show transfer id in error message > >> > rhv-upload: Extract imageio helpers > >> > rhv-upload: Extract get_options() helper > >> > rhv-upload: Extract optimize_http() helper > >> > rhv-upload: Clean up...

...cel transfer if finalize failed >> > rhv-upload: Keep disk_id in handle >> > rhv-upload: Show disk id in error message >> > rhv-upload: Don't keep transfer_service in handle >> > rhv-upload: Get host before creating disk >> > rhv-upload: Extract create_transfer() function >> > rhv-upload: Show transfer id in error message >> > rhv-upload: Extract imageio helpers >> > rhv-upload: Extract get_options() helper >> > rhv-upload: Extract optimize_http() helper >> > rhv-upload: Clean up username and password &g...

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

...> > rhv-upload: Keep disk_id in handle >> >> > rhv-upload: Show disk id in error message >> >> > rhv-upload: Don't keep transfer_service in handle >> >> > rhv-upload: Get host before creating disk >> >> > rhv-upload: Extract create_transfer() function >> >> > rhv-upload: Show transfer id in error message >> >> > rhv-upload: Extract imageio helpers >> >> > rhv-upload: Extract get_options() helper >> >> > rhv-upload: Extract optimize_http() helper >> >> >...

Add support for qcow2 disk format, enabled by imageio NBD backend in RHV 4.3. To use this feature manually, you can run virt-v2v with "-of qcow2". Here is example run: Source disk: $ qemu-img info /var/tmp/fedora-30.img image: /var/tmp/fedora-30.img file format: raw virtual size: 6 GiB (6442450944 bytes) disk size: 1.15 GiB virt-v2v: $ ./run virt-v2v \ -v \ -i disk

...rtsdk4.types as types +# Version 2 supports the buffer protocol, improving performance. +API_VERSION = 2 + # Timeout to wait for oVirt disks to change status, or the transfer # object to finish initializing [seconds]. timeout = 5 * 60 @@ -114,67 +119,61 @@ def open(readonly): transfer = create_transfer(connection, disk, host) try: - destination_url = parse_transfer_url(transfer) - http = create_http(destination_url) - options = get_options(http, destination_url) - http = optimize_http(http, host, options) + # ImageioClient uses transfer_url if possible, a...