search for: create_nbdkit_module

On Mon, Mar 23, 2020 at 12:28:12PM +0000, Richard W.M. Jones wrote: > From: Yifan Gu <gyf304@gmail.com> > > The create_nbdkit_module function is intended to be exported, therefore > the static keyword is not needed and prevents building on MSYS2. > --- > plugins/python/python.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/plugins/python/python.c b/plugins/python/python.c > index...

.../.. -I../../include -I../../common/utils -I/usr/include/python3.7m -g -O2 -MT nbdkit_python_plugin_la-python.lo -MD -MP -MF .deps/nbdkit_python_plugin_la-python.Tpo -c python.c -DDLL_EXPORT -DPIC -o .libs/nbdkit_python_plugin_la-python.o python.c:228:1: error: external linkage required for symbol ‘create_nbdkit_module’ because of ‘dllexport’ attribute 228 | create_nbdkit_module (void) | ^~~~~~~~~~~~~~~~~~~~ make[3]: *** [Makefile:638: nbdkit_python_plugin_la-python.lo] Error 1 make[3]: Leaving directory '/c/Users/yifangu/Documents/devel/nbdkit/plugins/python' make[2]: *** [Makefile:505: all-recur...

From: Yifan Gu <gyf304@gmail.com> The create_nbdkit_module function is intended to be exported, therefore the static keyword is not needed and prevents building on MSYS2. --- plugins/python/python.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/python/python.c b/plugins/python/python.c index a1a0438b..adc1aaa5 100644 --- a/pl...

...plugins/python/python.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/plugins/python/python.c b/plugins/python/python.c > index d65ac45..69cf4e9 100644 > --- a/plugins/python/python.c > +++ b/plugins/python/python.c > @@ -231,6 +231,33 @@ create_nbdkit_module (void) > nbdkit_error ("could not create the nbdkit API module"); > exit (EXIT_FAILURE); > } > + > + /* Constants corresponding to various flags. */ > + PyModule_AddIntConstant (m, "THREAD_MODEL_SERIALIZE_CONNECTIONS", > +...

I pushed a few of the msys2 patches upstream. I changed the way that $(SHARED_LDFLAGS) works so it's more to my liking, and the others were pushed unchanged. Three patches remain which I'm posting on the mailing list for proper review. Rich.

...; 1 file changed, 27 insertions(+) > > > > > > diff --git a/plugins/python/python.c b/plugins/python/python.c > > > index d65ac45..69cf4e9 100644 > > > --- a/plugins/python/python.c > > > +++ b/plugins/python/python.c > > > @@ -231,6 +231,33 @@ create_nbdkit_module (void) > > > nbdkit_error ("could not create the nbdkit API module"); > > > exit (EXIT_FAILURE); > > > } > > > + > > > + /* Constants corresponding to various flags. */ > > > + PyModule_AddIntConstant (m, "THREAD_MO...

...et available for future use. --- plugins/python/python.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/plugins/python/python.c b/plugins/python/python.c index d65ac45..69cf4e9 100644 --- a/plugins/python/python.c +++ b/plugins/python/python.c @@ -231,6 +231,33 @@ create_nbdkit_module (void) nbdkit_error ("could not create the nbdkit API module"); exit (EXIT_FAILURE); } + + /* Constants corresponding to various flags. */ + PyModule_AddIntConstant (m, "THREAD_MODEL_SERIALIZE_CONNECTIONS", + NBDKIT_THREAD_MODEL_SERIALIZE...

...+++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/plugins/python/python.c b/plugins/python/python.c > > index d65ac45..69cf4e9 100644 > > --- a/plugins/python/python.c > > +++ b/plugins/python/python.c > > @@ -231,6 +231,33 @@ create_nbdkit_module (void) > > nbdkit_error ("could not create the nbdkit API module"); > > exit (EXIT_FAILURE); > > } > > + > > + /* Constants corresponding to various flags. */ > > + PyModule_AddIntConstant (m, "THREAD_MODEL_SERIALIZE_CONNECTIONS&quot...

This is working for me now, although possibly only on Python 3.9. Dan suggested PyEval_InitThreads but that was deprecated in Python 3.7. Rich.

...check_python_failure (const char *callback) return 0; } -#if PY_MAJOR_VERSION >= 3 static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "nbdkit", @@ -234,25 +221,18 @@ static struct PyModuleDef moduledef = { NULL, NULL }; -#endif static PyMODINIT_FUNC create_nbdkit_module (void) { PyObject *m; -#if PY_MAJOR_VERSION >= 3 m = PyModule_Create (&moduledef); -#else - m = Py_InitModule ("nbdkit", NbdkitMethods); -#endif if (m == NULL) { nbdkit_error ("could not create the nbdkit API module"); exit (EXIT_FAILURE); } -#if...

This patch proposes to drop support for Python 2 in nbdkit. Rather than abruptly drop it everywhere, my proposal is that we point people to nbdkit 1.14 (the current stable version) if they want to continue with Python 2 plugins, while gently reminding them of the upcoming Python 2.7 end of life announcement. Libnbd never supported Python 2. Libguestfs in theory supports Python 2 but I dropped

And fill out most of the missing bits of the API. Rich.

v1: https://www.redhat.com/archives/libguestfs/2019-November/msg00153.html v2: - Fix implementation of can_cache. - Add implementation of can_fua. - Add a very thorough test suite which tests every command + flag combination.

v3 was here: https://www.redhat.com/archives/libguestfs/2019-November/msg00209.html In v4: - Rebase on top of current master. Includes various fixes and updates required because of Nir's patches that went into master. - Fix api_version() -> API_VERSION in patch 2 noted previously on the mailing list. Rich.

v2 was here: https://www.redhat.com/archives/libguestfs/2019-November/msg00163.html I pushed patch 1 (with spelling fix), patch 4 and patch 5 since those were previously ACKed on the list. Differences in v3: - Add error checking to PyModule_AddIntConstant. - Use API_VERSION constant instead of function. - Add max API version supported to --dump-plugin output. - Print API_VERSION selected by