search for: create_libvirt_xml

...s already supported in gnome-boxes and virt-manager (at least). The discussion happened here: https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html So let's add the support to local and libvirt outputs. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- v2v/create_libvirt_xml.ml | 109 ++++++++++++++++++++++++++++++++++++- v2v/create_libvirt_xml.mli | 1 + v2v/output_libvirt.ml | 4 +- v2v/output_local.ml | 4 +- 4 files changed, 113 insertions(+), 5 deletions(-) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index 55e83e8bc1b9..1...

When writing the libosinfo metadata in the libvirt XML, use the newly added (in osinfo-db) ID for Windows Server 2019; sadly, this version of Windows has the same version as Windows Server 2016, so distinguish it by looking at its product name. --- v2v/create_libvirt_xml.ml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index a8dc1f2f0..dbc24315f 100644 --- a/v2v/create_libvirt_xml.ml +++ b/v2v/create_libvirt_xml.ml @@ -124,6 +124,11 @@ let get_osinfo_id = function | { i_type = "windows";...

...Particularly in the libosinfo project which has already got the canonical naming scheme! Anyway that's water under the bridge now so ... > So let's add the support to local and libvirt outputs. > > Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > --- > v2v/create_libvirt_xml.ml | 109 ++++++++++++++++++++++++++++++++++++- > v2v/create_libvirt_xml.mli | 1 + > v2v/output_libvirt.ml | 4 +- > v2v/output_local.ml | 4 +- > 4 files changed, 113 insertions(+), 5 deletions(-) > > diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvir...

On Wed, Apr 05, 2017 at 02:43:11PM +0100, Richard W.M. Jones wrote: > When outputting libvirt XML, create virtio-rng, a memory balloon > device, and a pvpanic device, if the guest supports it. > --- > v2v/create_libvirt_xml.ml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml > index fc7196595..58f720ac3 100644 > --- a/v2v/create_libvirt_xml.ml > +++ b/v2v/create_libvirt_xml.ml > @@ -338,6 +338,25 @@ let create_libv...

...e discussion happened here: https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html So let's add the support to local and libvirt outputs. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- v2: - Added support for SLED - Fixed test-v2v-i-ova test output v2v/create_libvirt_xml.ml | 119 ++++++++++++++++++++++++++++++++++++- v2v/create_libvirt_xml.mli | 1 + v2v/output_libvirt.ml | 4 +- v2v/output_local.ml | 4 +- v2v/test-v2v-i-ova.xml | 5 ++ 5 files changed, 128 insertions(+), 5 deletions(-) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create...

CentOS 8 is represented with a simpler osinfo ID without a minor version. --- v2v/create_libvirt_xml.ml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index dbc24315..002ce2b8 100644 --- a/v2v/create_libvirt_xml.ml +++ b/v2v/create_libvirt_xml.ml @@ -43,9 +43,14 @@ let get_osinfo_id = function i_major_version =...

Support also a "socket" listen type with no explicitly specified socket (which will be generated by libvirt). Updates commit a4adf48915c0e3e7f4e8b7bbdbb5ac622da1ac58. Related to: RHBZ#1378022 --- v2v/create_libvirt_xml.ml | 4 +++- v2v/parse_libvirt_xml.ml | 4 ++-- v2v/types.ml | 5 +++-- v2v/types.mli | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index 19e0a52..c276109 100644 --- a/v2v/create_libvirt_xml.ml...

...nd of functions, so no tests are added. If there is a place where tests would fit nicely, feel free to let me know. >> So let's add the support to local and libvirt outputs. >> >> Signed-off-by: Martin Kletzander <mkletzan@redhat.com> >> --- >> v2v/create_libvirt_xml.ml | 109 ++++++++++++++++++++++++++++++++++++- >> v2v/create_libvirt_xml.mli | 1 + >> v2v/output_libvirt.ml | 4 +- >> v2v/output_local.ml | 4 +- >> 4 files changed, 113 insertions(+), 5 deletions(-) >> >> diff --git a/v2v/create_libvirt_xml...

Version 1 was here: https://listman.redhat.com/archives/libguestfs/2023-February/thread.html#30694 I made a few changes in v2 but overall decided to keep the now unused gcaps_arch_min_version capability. This doesn't preclude removing it in future if we think it's never going to be useful. I changed patch 1 so that to remove the long comment about how the field is used, anticipating the

When outputting libvirt XML, create virtio-rng, a memory balloon device, and a pvpanic device, if the guest supports it. --- v2v/create_libvirt_xml.ml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index fc7196595..58f720ac3 100644 --- a/v2v/create_libvirt_xml.ml +++ b/v2v/create_libvirt_xml.ml @@ -338,6 +338,25 @@ let create_libvirt_xml ?pool source target_buses g...

Avoids the libvirt error: error: XML error: CPU vendor specified without CPU model --- v2v/create_libvirt_xml.ml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index 582419f00..fbe90eeaa 100644 --- a/v2v/create_libvirt_xml.ml +++ b/v2v/create_libvirt_xml.ml @@ -51,15 +51,17 @@ let create_libvirt_xml ?pool source...

...lly detect for us, then libvirt live migration is able to tell qemu to drop cached data at the right time even if the backing is NFS. It also had a significant performance impact. In some synthetic benchmarks it could show 2 or 3 times slower performance. Thanks: Ming Xie, Peter Krempa. --- v2v/create_libvirt_xml.ml | 1 - 1 file changed, 1 deletion(-) diff --git a/v2v/create_libvirt_xml.ml b/v2v/create_libvirt_xml.ml index 05553c4f7d..5a1fba0fd6 100644 --- a/v2v/create_libvirt_xml.ml +++ b/v2v/create_libvirt_xml.ml @@ -336,7 +336,6 @@ let create_libvirt_xml ?pool source targets target_buses guestcaps...

...append_child child = function | PCData _ | Comment _ -> assert false | Element e -> e.e_children <- e.e_children @ [child] @@ -33,15 +69,48 @@ let append_attr attr = function | PCData _ | Comment _ -> assert false | Element e -> e.e_attrs <- e.e_attrs @ [attr] -let create_libvirt_xml ?pool source targets guestcaps = +let create_libvirt_xml ?pool source targets guestcaps target_features = let memory_k = source.s_memory /^ 1024L in + (* We have the machine features of the guest when it was on the + * source hypervisor (source.s_features). We have the acpi flag + * whic...

...non-x86 architectures). In this patch I removed the code to force Q35, since any guest which is using secure boot will be new enough that it'll be using Q35 anyway after this patch (on x86). --- v2v/convert_linux.ml | 20 ++++++++++++++++++++ v2v/convert_windows.ml | 10 ++++++++++ v2v/create_libvirt_xml.ml | 21 ++++++++++++++------- v2v/create_ovf.ml | 2 ++ v2v/output_glance.ml | 5 +++++ v2v/output_qemu.ml | 14 ++++++++------ v2v/test-v2v-i-ova.xml | 2 +- v2v/types.ml | 8 ++++++++ v2v/types.mli | 6 ++++-- 9 files changed, 72 insertions(+)...

...actually be broken by this patch. Did you try: ‘make -C test-data check && make -C v2v check’? > >>So let's add the support to local and libvirt outputs. > >> > >>Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > >>--- > >> v2v/create_libvirt_xml.ml | 109 ++++++++++++++++++++++++++++++++++++- > >> v2v/create_libvirt_xml.mli | 1 + > >> v2v/output_libvirt.ml | 4 +- > >> v2v/output_local.ml | 4 +- > >> 4 files changed, 113 insertions(+), 5 deletions(-) > >> > >>diff --git...

...backing is NFS. It also had a significant performance impact. In some synthetic benchmarks it could show 2 or 3 times slower performance. Thanks: Ming Xie, Peter Krempa. --- tests/test-v2v-cdrom.expected | 2 +- tests/test-v2v-floppy.expected | 2 +- tests/test-v2v-i-ova.xml | 2 +- v2v/create_libvirt_xml.ml | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/test-v2v-cdrom.expected b/tests/test-v2v-cdrom.expected index e18ea6f28b..34d2bf5961 100644 --- a/tests/test-v2v-cdrom.expected +++ b/tests/test-v2v-cdrom.expected @@ -1,5 +1,5 @@ <disk type='file' d...

...e boot we still have to force the machine type to Q35. In a future version this forcing can be removed since any guest which is using secure boot will be new enough that it'll be using Q35 anyway (on x86). --- v2v/convert_linux.ml | 7 +++++++ v2v/convert_windows.ml | 7 +++++++ v2v/create_libvirt_xml.ml | 37 +++++++++++++++++++++++++------------ v2v/create_ovf.ml | 2 ++ v2v/output_glance.ml | 5 +++++ v2v/output_qemu.ml | 30 +++++++++++++++++++----------- v2v/test-v2v-i-ova.xml | 2 +- v2v/types.ml | 8 ++++++++ v2v/types.mli | 6 ++++-- 9...

...s patch I removed the code to force Q35, since any guest which > is using secure boot will be new enough that it'll be using Q35 anyway > after this patch (on x86). > --- > v2v/convert_linux.ml | 20 ++++++++++++++++++++ > v2v/convert_windows.ml | 10 ++++++++++ > v2v/create_libvirt_xml.ml | 21 ++++++++++++++------- > v2v/create_ovf.ml | 2 ++ > v2v/output_glance.ml | 5 +++++ > v2v/output_qemu.ml | 14 ++++++++------ > v2v/test-v2v-i-ova.xml | 2 +- > v2v/types.ml | 8 ++++++++ > v2v/types.mli | 6 ++++-- >...

Yaniv pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1438794 that virt-v2v both doesn't install the virtio-rng driver for Windows, and doesn't give the guest a virtio-rng PCI device either. There are two problems here: Firstly the Windows virtio-rng driver isn't included in the exploded tree (/usr/share/virtio-win) so it doesn't get copied into the guest. The solution

...;& make -C v2v check’? > good point, probably not after the patch. will do. >> >>So let's add the support to local and libvirt outputs. >> >> >> >>Signed-off-by: Martin Kletzander <mkletzan@redhat.com> >> >>--- >> >> v2v/create_libvirt_xml.ml | 109 ++++++++++++++++++++++++++++++++++++- >> >> v2v/create_libvirt_xml.mli | 1 + >> >> v2v/output_libvirt.ml | 4 +- >> >> v2v/output_local.ml | 4 +- >> >> 4 files changed, 113 insertions(+), 5 deletions(-) >> >> &gt...