search for: create_guest

...3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/LibVirt.pm b/lib/Sys/VirtV2V/Target/LibVirt.pm index e21a21f..cb9961d 100644 --- a/lib/Sys/VirtV2V/Target/LibVirt.pm +++ b/lib/Sys/VirtV2V/Target/LibVirt.pm @@ -298,7 +298,7 @@ Create the guest in the target sub create_guest { my $self = shift; - my ($dom, $guestcaps) = @_; + my ($desc, $dom, $guestcaps) = @_; my $vmm = $self->{vmm}; diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm index 65800cd..7c96f0e 100644 --- a/lib/Sys/VirtV2V/Target/RHEV.pm +++ b/lib/Sys/VirtV2...

...lib/Sys/VirtConvert/Connection/LibVirtTarget.pm b/lib/Sys/VirtConvert/Connection/LibVirtTarget.pm index a74f9df..b77ce1d 100644 --- a/lib/Sys/VirtConvert/Connection/LibVirtTarget.pm +++ b/lib/Sys/VirtConvert/Connection/LibVirtTarget.pm @@ -269,7 +269,7 @@ sub guest_exists return 1; } -=item create_guest(desc, meta, config, guestcaps, output_name) +=item create_guest(g, root, meta, config, guestcaps, output_name) Create the guest in the target @@ -278,7 +278,7 @@ Create the guest in the target sub create_guest { my $self = shift; - my ($desc, $meta, $config, $guestcaps, $output_name)...

...ib/Sys/VirtV2V/Target/RHEV.pm | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm index 867923b..9dd9013 100644 --- a/lib/Sys/VirtV2V/Target/RHEV.pm +++ b/lib/Sys/VirtV2V/Target/RHEV.pm @@ -562,7 +562,7 @@ sub create_guest # Generate a creation date my $vmcreation = _format_time(gmtime()); - my $osuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); + my $vmuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); my $ovf = new XML::DOM::Parser->parse(<<EOF); <ovf:Envelope...

...=> party } page.insert_html :after, "party-#{party.id}", :partial => ''guest_form'', :locals => { :guest => party.guests.build } end end _guest_form.rhtml is: <tr> <% remote_form_for :guest, guest, :url => { :action => ''create_guest'' } do |f| %> <%= f.hidden_field :party_id %> <td><%= f.text_field :first_name %></td> <td><%= f.text_field :last_name %> <%= submit_tag %></td> <% end %> </tr> Unfortunately, when the form is submitted, para...

...}; + + if ($@) { + if ($@->code == Sys::Virt::Error::ERR_NO_DOMAIN) { + return 0; + } + + die(user_message(__x("Error checking for domain: {error}", + error => $@->stringify()))); + } + + return 1; +} + =item create_guest(dom) Create the guest in the target diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm index 574b022..218cf63 100644 --- a/lib/Sys/VirtV2V/Target/RHEV.pm +++ b/lib/Sys/VirtV2V/Target/RHEV.pm @@ -618,6 +618,17 @@ sub get_volume die("Cannot retrieve an existing...

If a volume is not an exact multiple of 512 bytes, qemu-img will report its size rounded down to a 512 byte boundary. However, when copying, the file is still read until EOF, which will return more data than was expected. This change prevents that causing a failure in itself. The situation is still not resolved, however, as there are still situations where this will cause a failure. For example,

...Target/RHEV.pm | 19 ++++++++++--------- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm index 911e5c6..f14c54f 100644 --- a/lib/Sys/VirtV2V/Target/RHEV.pm +++ b/lib/Sys/VirtV2V/Target/RHEV.pm @@ -543,10 +543,7 @@ sub create_guest $memsize = int($memsize / 1024); # Generate a creation date - my $now = gmtime(); - my $vmcreation = sprintf("%02d/%02d/%d %02d:%02d:%02d", - $now->mday(), $now->mon() + 1, $now->year() + 1900, - $now->h...

These 2 patches remove devices which can prevent a guest from starting after conversion if they aren't supported by the target. This solution isn't ideal. We would preferrably query the target for supported models and update if necessary, however there's no API for this yet. Matthew Booth (2): Remove converted SCSI controllers Remove sound cards when outputting to libvirt

...return 1; +} + +=item get_volume (name) + +Get a reference to an existing volume. See L<create_volume> for return value. + +=cut + +sub get_volume +{ + my $self = shift; + my ($name) = @_; + + return Sys::VirtV2V::Target::LibVirt::Vol->_get($self->{pool}, $name); +} + +=item create_guest(dom) + +Create the guest in the target + +=cut + +sub create_guest +{ + my $self = shift; + my ($dom, $guestcaps) = @_; + + my $vmm = $self->{vmm}; + + _configure_capabilities($vmm, $dom, $guestcaps); + + $vmm->define_domain($dom->toString()); +} + +# Configure guest accordi...

...39;Converting guest') } $guestcaps = Sys::VirtConvert::Converter->convert($g, $config, $root, $meta, \%options); + # Create the guest + if (defined($verbose)) { logmsg NOTICE, __x('Creating guest') } $target->create_guest($g, $root, $meta, $config, $guestcaps, $output_name); }; -- 1.8.1.4

...9;rhev'); my $os; my $guestcaps; @@ -390,11 +382,11 @@ eval { # can result in failure to umount RHEV export's temporary mount point. if ($@) { my $err = $@; - close_guest_handle(); + $g->close(); die($err); } -close_guest_handle(); +$g->close(); $target->create_guest($os, $dom, $guestcaps); @@ -418,58 +410,10 @@ END { ############################################################################### ## Helper functions -sub close_guest_handle -{ - # Config may cache the guestfs handle, preventing cleanup below - $config = undef; - - if (defined($g))...

...$vol->get_path(), $size, + $is_sparse, $is_block, + $transfer); } =item guest_exists(name) @@ -317,7 +239,7 @@ sub guest_exists return 1; } -=item create_guest(dom) +=item create_guest(desc, dom, guestcaps) Create the guest in the target diff --git a/lib/Sys/VirtV2V/Connection/LibVirtXML.pm b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm similarity index 57% rename from lib/Sys/VirtV2V/Connection/LibVirtXML.pm rename to lib/Sys/VirtV2V/Connection/Li...

This is a new conversion module to convert SUSE Linux and openSUSE guests. The converter is based on the RedHat module, and should offer the same functionality on both SUSE and RedHat hosts. There are a few additional messages in this module, such as reporting of packages when installing through zypper or the local virt-v2v repo. These messages don't necessarily flow unless verbose switches