search for: create_drive_rbd

Note this patch requires a non-upstream qemu patch that I've been experimenting with. See qemu-devel list. Rich.

This series improves ceph rbd support in libguestfs. It uses the servers list, adds support for a custom username, and starts to add support for custom secret.

On Tuesday 11 March 2014 23:13:46 Richard W.M. Jones wrote: > diff --git a/src/drives.c b/src/drives.c > index 2c85b52..68e37f7 100644 > --- a/src/drives.c > +++ b/src/drives.c > @@ -115,7 +115,8 @@ static struct drive * > create_drive_file (guestfs_h *g, const char *path, > bool readonly, const char *format, > const char *iface,

Miscellaneous fixes to: - Handling of Ceph drives now works end-to-end (RHBZ#1026688). - In particular, you can now use rbd:/// URIs in guestfish (and they work). - Parse Ceph & NBD network drives from libvirt XML correctly, so that existing domains with Ceph/NBD drives can be added (eg. using guestfish -d option). - Add more testing of the above.

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

...return NULL; } + if (data->query != NULL) { + error (g, _("nbd: you cannot specify a query string with this protocol")); + return NULL; + } if (data->nr_servers != 1) { error (g, _("nbd: you must specify exactly one server")); @@ -268,6 +285,11 @@ create_drive_rbd (guestfs_h *g, { size_t i; + if (data->query != NULL) { + error (g, _("rbd: you cannot specify a query string with this protocol")); + return NULL; + } + for (i = 0; i < data->nr_servers; ++i) { if (data->servers[i].transport != drive_transport_none &...

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.