Displaying 17 results from an estimated 17 matches for "create_drive_non_fil".
Did you mean:
create_drive_non_file
2014 Mar 12
3
Re: [PATCH v2 03/18] New API parameter: Add discard parameter to guestfs_add_drive_opts.
On Tuesday 11 March 2014 23:13:46 Richard W.M. Jones wrote:
> diff --git a/src/drives.c b/src/drives.c
> index 2c85b52..68e37f7 100644
> --- a/src/drives.c
> +++ b/src/drives.c
> @@ -115,7 +115,8 @@ static struct drive *
> create_drive_file (guestfs_h *g, const char *path,
> bool readonly, const char *format,
> const char *iface,
2013 Apr 05
3
[PATCH] Add support for SSH (Secure Shell) block device.
Note this patch requires a non-upstream qemu patch that I've been
experimenting with. See qemu-devel list.
Rich.
2013 Nov 06
3
Re: Problem using virt-sysprep with RBD images
...86_64: -drive
file=rbd:ibvirt-pool/server-clone-test:mon_host=192.168.0.40\:6789\;192.168.0.35\:6789\;192.168.0.2\:6789:auth_supported=none,cache=writeback,id=hd0,if=none:
error opening pool ibvirt-pool
Since "ibvirt-pool" doesn't exist. :)
So this says to me that the function "create_drive_non_file" is consuming
that first slash somewhere. Perhaps "safe_strdup"? I'm not sure where
"safe_strdup" is to confirm, but it looks like other functions use the
"safe_stardup" function.
With that in mind, I didn't want to have to reinvent create_drive_non_fi...
2013 May 07
7
[PATCH 0/5] rbd improvements
This series improves ceph rbd support in libguestfs. It uses the servers
list, adds support for a custom username, and starts to add support for
custom secret.
2013 Nov 06
2
Re: Problem using virt-sysprep with RBD images
Hello Richard,
Thanks for the reply.
Indeed this behaviour exists in 1.25.6.
Grepping through the source [1], there are a number of files in
"./po/*.po[t]?" that contain this message, but I think it's ./src/drives.c
where the fail condition is actually detected / set.
On line 300 there is an if statement that checks the first character is a
slash:
if (exportname[0] !=
2013 Nov 06
0
Re: Problem using virt-sysprep with RBD images
...virt-pool/server-clone-test:mon_host=192.168.0.40\:6789\;192.168.0.35\:6789\;192.168.0.2\:6789:auth_supported=none,cache=writeback,id=hd0,if=none:
> error opening pool ibvirt-pool
>
> Since "ibvirt-pool" doesn't exist. :)
>
> So this says to me that the function "create_drive_non_file" is consuming
> that first slash somewhere.
Unfortunately this code is rather intricate (and intricately broken),
but the problem is likely to be here:
src/drives.c:
/* Skip the mandatory leading '/' character on exportname. */
return safe_asprintf (g, "rbd:%s:mon_h...
2013 Nov 06
1
Re: Problem using virt-sysprep with RBD images
...test:mon_host=192.168.0.40\:6789\;192.168.0.35\:6789\;192.168.0.2\:6789:auth_supported=none,cache=writeback,id=hd0,if=none:
> > error opening pool ibvirt-pool
> >
> > Since "ibvirt-pool" doesn't exist. :)
> >
> > So this says to me that the function "create_drive_non_file" is consuming
> > that first slash somewhere.
>
> Unfortunately this code is rather intricate (and intricately broken),
> but the problem is likely to be here:
>
> src/drives.c:
> /* Skip the mandatory leading '/' character on exportname. */
> retur...
2018 Aug 09
0
Using SPDK as QEMU's rootfs disk && A patch for libguestfs to support SPDK
...f (data->nr_servers != 1) {
+ error (g, _("spdk: you must specify exactly one server"));
+ return NULL;
+ }
+
+ if (data->servers[0].transport != drive_transport_unix) {
+ error (g, _("spdk: only unix transport is supported"));
+ return NULL;
+ }
+
+ return create_drive_non_file (g, data);
+}
+
+bool
+guestfs_int_has_spdk_drive (guestfs_h *g)
+{
+ size_t i;
+ struct drive *drv;
+ ITER_DRIVES(g, i, drv) {
+ if (drv->src.protocol == drive_protocol_spdk) {
+ return true;
+ }
+ }
+ return false;
+}
+
/**
* Create the special F</dev/null> drive.
*...
2020 Feb 10
0
Re: [RFC] lib: allow to specify physical/logical block size for disks
...drv->discard = data->discard;
> drv->copyonread = data->copyonread;
> + drv->pblocksize = data->pblocksize;
> + drv->lblocksize = data->lblocksize;
>
> if (data->readonly) {
> if (create_overlay (g, drv) == -1) {
> @@ -150,6 +154,8 @@ create_drive_non_file (guestfs_h *g,
> drv->cachemode = data->cachemode ? safe_strdup (g, data->cachemode) : NULL;
> drv->discard = data->discard;
> drv->copyonread = data->copyonread;
> + drv->pblocksize = data->pblocksize;
> + drv->lblocksize = data->lblocksi...
2020 Feb 07
8
[RFC] lib: allow to specify physical/logical block size for disks
...p (g, data->cachemode) : NULL;
drv->discard = data->discard;
drv->copyonread = data->copyonread;
+ drv->pblocksize = data->pblocksize;
+ drv->lblocksize = data->lblocksize;
if (data->readonly) {
if (create_overlay (g, drv) == -1) {
@@ -150,6 +154,8 @@ create_drive_non_file (guestfs_h *g,
drv->cachemode = data->cachemode ? safe_strdup (g, data->cachemode) : NULL;
drv->discard = data->discard;
drv->copyonread = data->copyonread;
+ drv->pblocksize = data->pblocksize;
+ drv->lblocksize = data->lblocksize;
if (data->rea...
2015 Feb 02
1
RFC: Handle query strings for http and https (RHBZ#1092583)
...s.c
index 34bf63d..3668e29 100644
--- a/src/drives.c
+++ b/src/drives.c
@@ -63,6 +63,7 @@ struct drive_create_data {
const char *cachemode;
enum discard discard;
bool copyonread;
+ const char *query;
};
COMPILE_REGEXP (re_hostname_port, "(.*):(\\d+)$", 0)
@@ -144,6 +145,7 @@ create_drive_non_file (guestfs_h *g,
drv->src.username = data->username ? safe_strdup (g, data->username) : NULL;
drv->src.secret = data->secret ? safe_strdup (g, data->secret) : NULL;
drv->src.format = data->format ? safe_strdup (g, data->format) : NULL;
+ drv->src.query = data-...
2014 Mar 10
5
[PATCH 0/3] Add discard support.
These patches contain the beginnings of discard (a.k.a. trim or unmap)
support. This will allow us to change virt-sparsify to work on disk
images in-place (instead of using slow & inefficient copying).
The approach used is to add an optional 'discard' parameter to
add-drive. It has 3 possible settings:
- 'disable' : the default, no discard is done
- 'besteffort' :
2020 Feb 11
2
[PATCH v2] lib: add support for disks with 4096 bytes sector size
...>cachemode = data->cachemode ? safe_strdup (g, data->cachemode) : NULL;
drv->discard = data->discard;
drv->copyonread = data->copyonread;
+ drv->blocksize = data->blocksize;
if (data->readonly) {
if (create_overlay (g, drv) == -1) {
@@ -150,6 +152,7 @@ create_drive_non_file (guestfs_h *g,
drv->cachemode = data->cachemode ? safe_strdup (g, data->cachemode) : NULL;
drv->discard = data->discard;
drv->copyonread = data->copyonread;
+ drv->blocksize = data->blocksize;
if (data->readonly) {
if (create_overlay (g, drv) == -1...
2020 Feb 10
1
[PATCH] lib: allow to specify physical/logical block size for disks
...>cachemode = data->cachemode ? safe_strdup (g, data->cachemode) : NULL;
drv->discard = data->discard;
drv->copyonread = data->copyonread;
+ drv->blocksize = data->blocksize;
if (data->readonly) {
if (create_overlay (g, drv) == -1) {
@@ -150,6 +152,7 @@ create_drive_non_file (guestfs_h *g,
drv->cachemode = data->cachemode ? safe_strdup (g, data->cachemode) : NULL;
drv->discard = data->discard;
drv->copyonread = data->copyonread;
+ drv->blocksize = data->blocksize;
if (data->readonly) {
if (create_overlay (g, drv) == -1...
2014 Jan 16
3
[PATCH 0/2] Don't use snapshot=on
QEMU upstream has broken snapshot=on ... again.
These two patches stop using it entirely. Instead we run
'qemu-img create' to create overlay disks as required.
Note that the libvirt and UML backends were already doing this: The
libvirt backend because <transient/> has never worked, and the UML
backend was running uml_mkcow because the UML-equivalent syntax of
snapshot=on was
2014 Mar 11
21
[PATCH v2 00/18] Add discard support.
This still isn't working at the moment. See:
http://marc.info/?t=139457409300003&r=1&w=2
This set of patches:
- Adds new APIs to support discard in libguestfs.
- Adds discard support to virt-format.
- Adds discard support to virt-sysprep.
- Implements virt-sparsify --in-place.
Rich.
2014 Mar 12
12
[PATCH v3 00/10] Add discard support.
This set of patches:
- Adds new APIs to support discard in libguestfs.
- Adds discard support to virt-format.
- Adds discard support to virt-sysprep.
- Implements virt-sparsify --in-place.
This is now working, after fixing the rather stupid bug in fstrim.
I've pushed the ones which were ACKed previously + the fstrim fix.
Rich.