search for: create_directory_path

Hello, I'm totally new to this list, so I hope I don't break all the rules. :) I've looked through the archives (and google), and I really can't find the answer to my question. I'm trying out the 'detect-renamed'-patch, and I've encountered some odd behavior. I've applied the patch to both rsync-2.6.9 and rsync-3.0.0pre7, and it's the same behavior.

...NT; } else { + dry_missing_dir = NULL; const char *dn = file->dirname ? file->dirname : "."; if (parent_dirname != dn && strcmp(parent_dirname, dn) != 0) { if (relative_paths && !implied_dirs - && do_stat(dn, &sx.st) < 0 - && create_directory_path(fname) < 0) { - rsyserr(FERROR_XFER, errno, - "recv_generator: mkdir %s failed", - full_fname(dn)); + && do_stat(dn, &sx.st) < 0) { + if (dry_run) + goto parent_is_dry_missing; + if (create_directory_path(fname) < 0) { + rsyserr(FERROR_XFER...

...roto.h@@/main/original/1 Tue Apr 9 14:03:22 2002 --- proto.h Tue Apr 9 15:21:58 2002 *************** *** 233,239 **** pid_t local_child(int argc, char **argv,int *f_in,int *f_out); void out_of_memory(char *str); void overflow(char *str); ! int set_modtime(char *fname, time_t modtime); int create_directory_path(char *fname); int copy_file(char *source, char *dest, mode_t mode); int robust_unlink(char *fname); --- 233,239 ---- pid_t local_child(int argc, char **argv,int *f_in,int *f_out); void out_of_memory(char *str); void overflow(char *str); ! int set_modtime(char *fname,time_t modtime,time_t...

...es parent directories will already exist - * because their information should have been previously - * transferred, but that may not be the case with -R */ - if (fd2 == -1 && relative_paths && errno == ENOENT && - create_directory_path(fnametmp, orig_umask) == 0) { - strlcpy(fnametmp, template, sizeof fnametmp); + strlcpy(template, fnametmp, sizeof template); + + /* we initially set the perms without the + * setuid/setgid bits to ensure that there is no race +...

...argv(char **cmd); -NORETURN void out_of_memory(char *str); -NORETURN void overflow_exit(char *str); +NORETURN void out_of_memory(char *str) NORETURN2; +NORETURN void overflow_exit(char *str) NORETURN2; int set_modtime(char *fname, time_t modtime, mode_t mode); int mkdir_defmode(char *fname); int create_directory_path(char *fname); --- rsync-2.6.9/rsync.h.orig 2006-10-24 05:31:30.000000000 +0200 +++ rsync-2.6.9/rsync.h 2006-11-21 21:32:09.000000000 +0100 @@ -667,7 +667,16 @@ #endif #define UNUSED(x) x __attribute__((__unused__)) +#if __GNUC__ > 2 #define NORETURN __attribute__((__noreturn__)) +#define NO...

...} /* in most cases parent directories will already exist because their information should have been previously transferred, but that may not be the case with -R */ if (fd2 == -1 && relative_paths && errno == ENOENT && create_directory_path(fnametmp, orig_umask) == 0) { strlcpy(fnametmp, template, sizeof(fnametmp)); fd2 = do_mkstemp(fnametmp, file->mode & INITACCESSPERMS); } if (fd2 == -1) { rprintf(FERROR,"cannot create %s : %s\n",fnametmp,strerror(errno...

https://bugzilla.samba.org/show_bug.cgi?id=2831 ------- Additional Comments From wayned@samba.org 2005-06-30 10:00 ------- Created an attachment (id=1292) --> (https://bugzilla.samba.org/attachment.cgi?id=1292&action=view) Ignore EEXIST on second mkdir() call -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because:

...n(fnametmp,write_flags, file->mode & INITACCESSPERMS); /* in most cases parent directories will already exist @@ -436,7 +446,7 @@ transferred, but that may not be the case with -R */ if (fd2 == -1 && relative_paths && errno == ENOENT && create_directory_path(fnametmp) == 0) { - fd2 = do_open(fnametmp,O_WRONLY|O_CREAT|O_EXCL, + fd2 = do_open(fnametmp,write_flags, file->mode & INITACCESSPERMS); } if (fd2 == -1) {

Sorry, my question was whether or not this issue has been resolved. Thanks Hello, I am having problems with rsync: recv_generator: mkdir "dirname" No such file or directory (2) stat dirname No such file or directory Which is the same problem reported in the link below: http://www.mail-archive.com/rsync@lists.samba.org/msg16446.html rsync

...p, file->mode & INITACCESSPERMS); + fd2 = do_mkstemp(fnametmp); /* in most cases parent directories will already exist * because their information should have been previously @@ -432,7 +432,7 @@ if (fd2 == -1 && relative_paths && errno == ENOENT && create_directory_path(fnametmp, orig_umask) == 0) { strlcpy(fnametmp, template, sizeof fnametmp); - fd2 = do_mkstemp(fnametmp, file->mode & INITACCESSPERMS); + fd2 = do_mkstemp(fnametmp); } if (fd2 == -1) { rprintf(FERROR, "mkstemp %s failed: %s\n", Index: syscall.c ===================...

...58:09 2004 > +++ rsync-2.6.2/proto.h Fri Jul 23 15:16:17 2004 > @@ -242,6 +242,7 @@ > void print_child_argv(char **cmd); > void out_of_memory(char *str); > void overflow(char *str); > +void update_atime(char *fname); > int set_modtime(char *fname, time_t modtime); > int create_directory_path(char *fname, int base_umask); > int copy_file(char *source, char *dest, mode_t mode); > diff -u rsync-2.6.2.orig/util.c rsync-2.6.2/util.c > --- rsync-2.6.2.orig/util.c Tue Apr 27 16:59:37 2004 > +++ rsync-2.6.2/util.c Fri Jul 23 16:53:06 2004 > @@ -1135,3 +1135,40 @@ > return...

All callers of robust_rename() call copy_file() if EXDEV is received. This patch moves the copy_file() call into robust_rename(). Patch Summary: -12 +1 backup.c -15 +2 rsync.c -9 +33 util.c -------------- next part -------------- patchwork diff util.c --- util.c 2004-02-17 09:58:44.000000000 -0500 +++ util.c 2004-02-17 10:21:22.000000000 -0500 @@ -355,16 +355,40 @@

...out_of_memory(const char *str); > NORETURN void overflow_exit(const char *str); > -int set_modtime(const char *fname, time_t modtime, mode_t mode); > +int set_modtime(const char *fname, time_t modtime, mode_t mode, > uint32 fileflags); > int mkdir_defmode(char *fname); > int create_directory_path(char *fname); > int full_write(int desc, const char *ptr, size_t len); > diff -up a/rsync.1 b/rsync.1 > --- a/rsync.1 > +++ b/rsync.1 > @@ -413,6 +413,7 @@ to the detailed description below for a > \-K, \-\-keep\-dirlinks treat symlinked dir on receiver as > dir &g...

...t;%s\" to make room for directory: %s\n", @@ -321,6 +327,8 @@ } statret = -1; } + if (backup_only) + return; if (statret != 0 && do_mkdir(fname,file->mode) != 0 && errno != EEXIST) { if (!(relative_paths && errno==ENOENT && create_directory_path(fname, orig_umask)==0 && @@ -357,6 +365,8 @@ * right place -- no further action * required. */ if (strcmp(lnk,file->link) == 0) { + if (backup_only) + return; set_perms(fname,file,&st,1); return; } @@ -364,8 +374,12 @@ /* Not a symlink,...

...h 27 Mar 2004 09:44:34 -0000 1.185 +++ proto.h 10 Apr 2004 23:28:35 -0000 @@ -244,7 +244,7 @@ void print_child_argv(char **cmd); void out_of_memory(char *str); void overflow(char *str); -int set_modtime(char *fname, time_t modtime); +int set_times(char *fname, time_t modtime, time_t atime); int create_directory_path(char *fname, int base_umask); int copy_file(char *source, char *dest, mode_t mode); int robust_unlink(char *fname); @@ -268,7 +268,7 @@ int unsafe_symlink(const char *dest, const char *src); char *timestring(time_t t); int msleep(int t); -int cmp_modtime(time_t file1, time_t file2); +int cmp_t...

...++ rsync-2.6.6_patch/proto.h 2005-11-23 23:51:54.000000000 +0100 @@ -266,7 +266,7 @@ void print_child_argv(char **cmd); void out_of_memory(char *str); void overflow_exit(char *str); -int set_modtime(char *fname, time_t modtime); +int set_modtime(char *fname, time_t modtime, time_t acctime); int create_directory_path(char *fname, int base_umask); int full_write(int desc, char *ptr, size_t len); int copy_file(char *source, char *dest, mode_t mode); diff -uNr rsync-2.6.6/rsync.1 rsync-2.6.6_patch/rsync.1 --- rsync-2.6.6/rsync.1 2005-07-28 21:31:08.000000000 +0200 +++ rsync-2.6.6_patch/rsync.1 2006-01-11 15:56:0...

...h 14 Apr 2004 23:33:30 -0000 1.188 +++ proto.h 20 Apr 2004 21:06:18 -0000 @@ -243,7 +243,7 @@ void print_child_argv(char **cmd); void out_of_memory(char *str); void overflow(char *str); -int set_modtime(char *fname, time_t modtime); +int set_times(char *fname, time_t modtime, time_t atime); int create_directory_path(char *fname, int base_umask); int copy_file(char *source, char *dest, mode_t mode); int robust_unlink(char *fname); @@ -267,7 +267,7 @@ int unsafe_symlink(const char *dest, const char *src); char *timestring(time_t t); int msleep(int t); -int cmp_modtime(time_t file1, time_t file2); +int cmp_t...