Displaying 5 results from an estimated 5 matches for "cpu32_to_l".
Did you mean:
cpu32_to_le
2018 Mar 27
2
murmurhash3 test failures on big-endian systems
...gt; additional change fixes the build on s390x (and does not break it on
> x864_64):
>
> --- b/src/lib/murmurhash3.c
> +++ b/src/lib/murmurhash3.c
> @@ -23,7 +23,7 @@
>
> static inline uint32_t getblock32(const uint32_t *p, int i)
> {
> - return p[i];
> + return cpu32_to_le(p[i]);
? or perhaps le32_to_cpu, although it should be the same in the end.
> }
>
> //-----------------------------------------------------------------------------
> @@ -105,7 +105,7 @@
>
> static inline uint64_t getblock64(const uint64_t *p, int i)
> {
> - return...
2018 Mar 27
2
murmurhash3 test failures on big-endian systems
Hi,
On 12:55 Mon 26 Mar , Josef 'Jeff' Sipek wrote:
> On Mon, Mar 26, 2018 at 15:57:01 +0300, Apollon Oikonomopoulos wrote:
> ...
> > I'd be happy to test the patch, thanks!
>
> Ok, try the attached patch. (It is a first pass at the issue, so it may not
> be the final diff that'll end up getting committed. It'd be good to know if
> it actually
2018 Mar 27
0
murmurhash3 test failures on big-endian systems
...teger expecting little-endian storage. Applying this
additional change fixes the build on s390x (and does not break it on
x864_64):
--- b/src/lib/murmurhash3.c
+++ b/src/lib/murmurhash3.c
@@ -23,7 +23,7 @@
static inline uint32_t getblock32(const uint32_t *p, int i)
{
- return p[i];
+ return cpu32_to_le(p[i]);
}
//-----------------------------------------------------------------------------
@@ -105,7 +105,7 @@
static inline uint64_t getblock64(const uint64_t *p, int i)
{
- return p[i];
+ return cpu64_to_le(p[i]);
}
Regards,
Apollon
2018 Mar 27
0
murmurhash3 test failures on big-endian systems
...d does not break it on
> > x864_64):
> >
> > --- b/src/lib/murmurhash3.c
> > +++ b/src/lib/murmurhash3.c
> > @@ -23,7 +23,7 @@
> >
> > static inline uint32_t getblock32(const uint32_t *p, int i)
> > {
> > - return p[i];
> > + return cpu32_to_le(p[i]);
>
> ? or perhaps le32_to_cpu, although it should be the same in the end.
Right.
I'm going get the changes reviewed & committed. I'll ping you when there is
a commit with the "official" fix.
Thanks,
Jeff.
> > }
> >
> > //--------------...
2018 Mar 28
1
murmurhash3 test failures on big-endian systems
...gt; > >
> > > --- b/src/lib/murmurhash3.c
> > > +++ b/src/lib/murmurhash3.c
> > > @@ -23,7 +23,7 @@
> > >
> > > static inline uint32_t getblock32(const uint32_t *p, int i)
> > > {
> > > - return p[i];
> > > + return cpu32_to_le(p[i]);
> >
> > ? or perhaps le32_to_cpu, although it should be the same in the end.
>
> Right.
>
> I'm going get the changes reviewed & committed. I'll ping you when there is
> a commit with the "official" fix.
Ok, there are two commits:
3549...