search for: cpplint

...upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we might be interested in enabling: - cpplint (code style checker based on cpplint.py <https://github.com/google/styleguide>) - cppcheck (C++ linter based on cppcheck <http://cppcheck.sourceforge.net/>) Note that cpplint assumes google code style, but I think it can potentially be replaced it with clang-format with configurable co...

...up before... but have we considered just adopting the Google style guidlines and maybe modifying it in some places? They have a nice script for c++ which will check for many things. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py

...Arcanist ( >> https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This >> will enforce the check when `arc diff` is run (reviewers wouldn't see the >> warnings though). >> >> There are two linters we might be interested in enabling: >> - cpplint (code style checker based on cpplint.py >> <https://github.com/google/styleguide>) >> - cppcheck (C++ linter based on cppcheck <http://cppcheck.sourceforge.net/>) >> >> Note that cpplint assumes google code style, but I think it can potentially >> be repla...

...pressions and python hacks, built up w/o any overarching design or cohesion over years. I await the day we can kill it off and use a real Clang-based tool instead. > > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml > > http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > -------------- next part -------------- An HTML attachment was scrubbed... URL: &...

On 11/14, Mehdi Amini via llvm-dev wrote: > Ideally I’d even really like to have a both checking for revision on > phab, clang-formatting them, and post a comment when there is a > mismatch :) I'd like that! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: Digital signature URL:

...pect to have similar concerns and suggestions for your patch, > Hi Chris, Thanks for the reply. Indeed, some of your comments to safecode patch apply here. Codingstyle: I'll try to cleanup as much as I can today. Do you have any lint-like tool that checks for llvm coding style (similar to cpplint <http://google-styleguide.googlecode.com/svn/trunk/cpplint/>)? Documentation: everything is in the wiki. The main pages are: http://code.google.com/p/address-sanitizer/wiki/AddressSanitizer http://code.google.com/p/address-sanitizer/wiki/AddressSanitizerAlgorithm "who is going to maint...

On Jun 21, 2011, at 8:05 AM, Kostya Serebryany wrote: > Hi, > What would be our next steps in getting ASan into the LLVM trunk? > I'd like to do it in two steps, first for the LLVM part with minimal tests and then for the run-time library and all tests. > The current ASan's source repository will probably stay the primary home for the run-time library and tests as we plan

...for your patch, >> > > Hi Chris, > > Thanks for the reply. > Indeed, some of your comments to safecode patch apply here. > > Codingstyle: I'll try to cleanup as much as I can today. > Do you have any lint-like tool that checks for llvm coding style (similar > to cpplint <http://google-styleguide.googlecode.com/svn/trunk/cpplint/>)? > I don't know of any effective ones. Kostya, maybe you can send the code by myself and/or Nick to help walk through it for style issues? Documentation: everything is in the wiki. The main pages are: > http://code.goog...

...t;> Hi Chris, >> >> Thanks for the reply. >> Indeed, some of your comments to safecode patch apply here. >> >> Codingstyle: I'll try to cleanup as much as I can today. >> Do you have any lint-like tool that checks for llvm coding style (similar >> to cpplint <http://google-styleguide.googlecode.com/svn/trunk/cpplint/> >> )? >> > > I don't know of any effective ones. Kostya, maybe you can send the code by > myself and/or Nick to help walk through it for style issues? > > Documentation: everything is in the wiki. The...

...the run-time is ~5 KLOC. http://code.google.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan The Apple-specific part may make some Apple experts cry (or maybe not). The code uses google's coding style, which is similar, but not equivalent to the LLVM's one. We check it using cpplint before commits. LLVM license is used. The tests are ~2.5 KLOC; most of the tests require the clang compiler with -faddress-sanitizer switch. If possible, I'd prefer not to review the patch in a usual way (too big), but instead have the comments to the files in http://code.google.com/p/...

...ogle.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan > > The Apple-specific part may make some Apple experts cry (or maybe > not). > > The code uses google's coding style, which is similar, but not > equivalent > > to the LLVM's one. We check it using cpplint before commits. > > I personally would like to see it be in LLVM style, but the rest of > compiler-rt isn't really that way, so I don't think this is a blocker. > > Unless anyone objects, I think we should just bring the code in as is > so that ASAN works, and if people wa...

...> KLOC. http://code.google.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan >    The Apple-specific part may make some Apple experts cry (or maybe not). >    The code uses google's coding style, which is similar, but not equivalent > to the LLVM's one. We check it using cpplint before commits. I personally would like to see it be in LLVM style, but the rest of compiler-rt isn't really that way, so I don't think this is a blocker. Unless anyone objects, I think we should just bring the code in as is so that ASAN works, and if people want to do more thorough revie...

...ource/browse/#svn%2Ftrunk%2Fasan >> >    The Apple-specific part may make some Apple experts cry (or maybe >> > not). >> >    The code uses google's coding style, which is similar, but not >> > equivalent >> > to the LLVM's one. We check it using cpplint before commits. >> >> I personally would like to see it be in LLVM style, but the rest of >> compiler-rt isn't really that way, so I don't think this is a blocker. >> >> Unless anyone objects, I think we should just bring the code in as is >> so that ASAN...

...ttp://code.google.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan >> ? ?The Apple-specific part may make some Apple experts cry (or maybe not). >> ? ?The code uses google's coding style, which is similar, but not equivalent >> to the LLVM's one. We check it using cpplint before commits. > > I personally would like to see it be in LLVM style, but the rest of > compiler-rt isn't really that way, so I don't think this is a blocker. > > Unless anyone objects, I think we should just bring the code in as is > so that ASAN works, and if people...

...--- lint/cpp_lint.py (revision 249819) +++ lint/cpp_lint.py (working copy) @@ -6,6 +6,7 @@ # TODO: add unittests for the verifier functions: # http://docs.python.org/library/unittest.html . +from __future__ import print_function import common_lint import re import sys @@ -86,7 +87,7 @@ def CppLintMain(filenames): all_lint = common_lint.RunLintOverAllFiles(CppLint(), filenames) for lint in all_lint: - print '%s:%d:%s' % (lint[0], lint[1], lint[2]) + print('%s:%d:%s' % (lint[0], lint[1], lint[2])) return 0 Index: shuffle_fuzz.py ==============================...