search for: cow_can_fua

...t nbdkit_next_ops *next_ops, void *nxdata, void *handle) { @@ -316,6 +322,7 @@ static struct nbdkit_filter filter = { .can_write = cow_can_write, .can_flush = cow_can_flush, .can_trim = cow_can_trim, + .can_extents = cow_can_extents, .can_fua = cow_can_fua, .pread = cow_pread, .pwrite = cow_pwrite, -- 2.20.1

...ze; - if (old_bm_size < new_bm_size) - memset (&bitmap[old_bm_size], 0, new_bm_size-old_bm_size); - - nbdkit_debug ("cow: bitmap resized to %zu bytes", new_bm_size); if (ftruncate (fd, new_size) == -1) { nbdkit_error ("ftruncate: %m"); @@ -263,30 +242,14 @@ cow_can_fua (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle) static bool blk_is_allocated (uint64_t blknum) { - uint64_t bm_offset = blknum / 8; - uint64_t bm_bit = blknum % 8; - - if (bm_offset >= bm_size) { - nbdkit_debug ("blk_is_allocated: block number is out of range");...

...ze; - if (old_bm_size < new_bm_size) - memset (&bitmap[old_bm_size], 0, new_bm_size-old_bm_size); - - nbdkit_debug ("cow: bitmap resized to %zu bytes", new_bm_size); if (ftruncate (fd, new_size) == -1) { nbdkit_error ("ftruncate: %m"); @@ -263,30 +244,14 @@ cow_can_fua (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle) static bool blk_is_allocated (uint64_t blknum) { - uint64_t bm_offset = blknum / 8; - uint64_t bm_bit = blknum % 8; - - if (bm_offset >= bm_size) { - nbdkit_debug ("blk_is_allocated: block number is out of range");...

...ze; - if (old_bm_size < new_bm_size) - memset (&bitmap[old_bm_size], 0, new_bm_size-old_bm_size); - - nbdkit_debug ("cow: bitmap resized to %zu bytes", new_bm_size); if (ftruncate (fd, new_size) == -1) { nbdkit_error ("ftruncate: %m"); @@ -263,30 +244,14 @@ cow_can_fua (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle) static bool blk_is_allocated (uint64_t blknum) { - uint64_t bm_offset = blknum / 8; - uint64_t bm_bit = blknum % 8; - - if (bm_offset >= bm_size) { - nbdkit_debug ("blk_is_allocated: block number is out of range");...

I have some patches I'm working on to fix the cache filter. However this is a prelude. It should be simply pure refactoring. All tests pass still. Rich.

v2: https://www.redhat.com/archives/libguestfs/2018-December/msg00039.html v2 -> v3: - Fix all the issues raised in Eric's review. - Precompute some numbers to make the calculations easier. - Calculations now use bitshifts and masks in preference to division and modulo. - Clear existing bits before setting (which fixes a bug in the cache filter). Rich.

This is exactly the same as v1: https://www.redhat.com/archives/libguestfs/2018-December/msg00004.html except that it now frees the bitmap on unload (which the old code did not - there was always a memory leak). Rich.

Since v1: - rework .can_cache to be tri-state, with default of no advertisement (ripple effect through other patches) - add a lot more patches in order to round out filter support And in the meantime, Rich pushed NBD_CMD_CACHE support into libnbd, so in theory we now have a way to test cache commands through the entire stack. Eric Blake (24): server: Internal hooks for implementing

I'm not sure exactly which version we're up to, but let's say it's version 4. I'm a lot happier with this version: - all filters have been reviewed and changed where I think that's necessary - can_extents is properly defined and implemented now - NBD protocol is followed - I believe it addresses all previous review points where possible The "only" thing

After more than a month since v2 [1], I've finally got my FUA support series polished. This is all of my outstanding patches, even though some of them were originally posted in separate threads from the original FUA post [2], [3] [1] https://www.redhat.com/archives/libguestfs/2018-January/msg00113.html [2] https://www.redhat.com/archives/libguestfs/2018-January/msg00219.html [3]

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.

This is a cover letter to a series of patches being proposed in tandem to four different projects: - nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag - qemu: Implement the flag for both clients and server - libnbd: Implement the flag for clients - nbdkit: Implement the flag for servers, including the nbd passthrough client If you want to test the patches together, I've pushed a