search for: core_udp_connect

...SUCCESS) { - Print(L"%s: udp->Configure() unsuccessful (%d)", f, status); + Print(L"%s: udp->Configure() unsuccessful (%d)\n", f, status); if (!efi_net_def_addr && (status == EFI_INVALID_PARAMETER)) efi_net_def_addr = 2; } @@ -158,6 +158,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; +retry: if (efi_net_def_addr) { udata.UseDefaultAddress = TRUE; } else { @@ -170,6 +171,11 @@ void core_udp_connect(struct pxe_pvt_inode *...

Signed-off-by: Julien Viard de Galbert <jviarddegalbert at online.net> --- efi/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efi/udp.c b/efi/udp.c index 1088f47..b0f13ad 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -163,7 +163,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, } else { udata.UseDefaultAddress = FALSE; memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); - memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); + memcpy(&udata.SubnetMask, &IPInfo.netma...

On Sat, Nov 9, 2013 at 9:22 AM, Jason Matthews <jason.david.matthews at gmail.com> wrote: > The setup I was using was in a chassis. Slot 8 of the chassis is the client > machine. It goes through Switch 1 (a Brocade switch) to the top of rack > (BNT). The mirror is in the chassis switch. Slot 3 of the same chassis is > connected to the mirror port in Switch 1. > > client =

...and take it >>>> for a spin? core_udp_open() should bind to the local IP address and obtain a local UDP port allocation. core_udp_close() should release the UDP port allocation. core_udp_sendto() knows the remote IP address and remote UDP port and must calculate the GatewayAddress. core_udp_connect() is passed the remote IP address and UDP port, calculates the GatewayAddress and stores all three for core_udp_send(). core_udp_send() should only copy the local/remote IP address/UDP port and GatewayAddress, then set the other flags/values as needed. Now to get core_udp_connect() to calculate/s...

...has been received, start with DhcpAck packet since it is the most complete. This requires a minimum of changes to the packet except that it contains NULL server ip so populate server from ProxyOffer packet. The information is loaded into pkt_v4 and then parsed. In efi/udp.c: Both updates are in core_udp_connect and core_udp_sendto functions. 1. Disable UseDefaultAddress, which is not complete. 2. Set StationAddress and SubnetMask to correct values from IPInfo struct because both fields are not necessarily populated. Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> --- diffstat results: pxe...

...ore_udp_open() should bind to the local IP address and obtain a local >> UDP port allocation. core_udp_close() should release the UDP port >> allocation. >> >> core_udp_sendto() knows the remote IP address and remote UDP port and >> must calculate the GatewayAddress. core_udp_connect() is passed the >> remote IP address and UDP port, calculates the GatewayAddress and >> stores all three for core_udp_send(). core_udp_send() should only >> copy the local/remote IP address/UDP port and GatewayAddress, then set >> the other flags/values as needed. >>...

...ou tried 5.10 in your environment on a BIOS machine to see whether > that works and which port numbers it uses? > > -- > Matt Fleming, Intel Open Source Technology Center > Hi Matt, I think I've found the problem. In /core/fs/pxe/tftp.c in function tftp_open: First you do a core_udp_connect to port 69 (TFTP) at line 264. -> source port = x After that you sent the filerequest at line 265 You receive the fileinfo and also the used port (y) for the transfer in line 273 Than you perform a core_udp_disconnect at line 286 Now you perform a new core_udp_connect to port y which set the sou...

...ber, host-byte order > + * @param:socket, the open socket White space change > + * @param:ip, the source ip address White space change, plus 'source ' > + * @param:port, the source port number, host-byte order White space change, plus 'source ' > */ > -void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, > - uint16_t port) > +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t src_ip, > + uint16_t src_port) Changed 'ip' and 'port' in 'src_ip' and 'src_port'. However: 'src_ip' and ...

...pported efi. > core_udp_open() should bind to the local IP address and obtain a local > UDP port allocation. core_udp_close() should release the UDP port > allocation. > > core_udp_sendto() knows the remote IP address and remote UDP port and > must calculate the GatewayAddress. core_udp_connect() is passed the > remote IP address and UDP port, calculates the GatewayAddress and > stores all three for core_udp_send(). core_udp_send() should only > copy the local/remote IP address/UDP port and GatewayAddress, then set > the other flags/values as needed. > > Now to get core...

...dback.In addition to the previous modifications: pxe.c: Changed to use ProxyOffer Packet and added client ip from PxeReply into temp packet for parsing. Left all existing cached packets untouched. udp.c: UseDefaultAddress is enabled/disabled based on whether it is a remote or local subnet in core_udp_connect and core_udp_sendto functions. Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> --- diffstat results: pxe.c | 17 +++++++++++++++-- udp.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 61 insertions(+), 4 deletions(-) -------------- next part ----------...

...ss to TRUE uses invalid StationAddress and SubnetMask values. This is in a network with a local TFTP/MTFTP server. If the server is local, on the same subnet, UseDefaultAddress is set to false and the client ip and subnetmask are loaded, otherwise set UseDefaultAddress to TRUE. This is added to core_udp_connect and core_udp_sendto. Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> --- Diffstat: udp.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 50 insertions(+), 2 deletions(-) --- udp.c 2015-07-06 07:22:04.000000000 -0700 +++ efi/udp.c 2015-07-08 12:13:...

...art with DhcpAck packet since it is the > most complete. This requires a minimum of changes to the packet except that > it contains NULL server ip so populate server from ProxyOffer packet. The > information is loaded into pkt_v4 and then parsed. > > In efi/udp.c: Both updates are in core_udp_connect and core_udp_sendto > functions. > > 1. Disable UseDefaultAddress, which is not complete. Were you able to do a packet capture? Why is it incomplete on your systems? > 2. Set StationAddress and SubnetMask to correct values from IPInfo struct > because both fields are not necessari...

...d to the local IP address and obtain a local > >> UDP port allocation. core_udp_close() should release the UDP port > >> allocation. > >> > >> core_udp_sendto() knows the remote IP address and remote UDP port and > >> must calculate the GatewayAddress. core_udp_connect() is passed the > >> remote IP address and UDP port, calculates the GatewayAddress and > >> stores all three for core_udp_send(). core_udp_send() should only > >> copy the local/remote IP address/UDP port and GatewayAddress, then set > >> the other flags/values...

On Tue, 25 Jun, at 01:51:52PM, Michael Szerencsits wrote: > Hi Matt, > > I think I've found the problem. Thanks for doing this analysis. > In /core/fs/pxe/tftp.c in function tftp_open: > First you do a core_udp_connect to port 69 (TFTP) at line 264. -> source port = x > After that you sent the filerequest at line 265 > You receive the fileinfo and also the used port (y) for the transfer in line 273 > Than you perform a core_udp_disconnect at line 286 > Now you perform a new core_udp_connect to port...

...a spin? > > core_udp_open() should bind to the local IP address and obtain a local > UDP port allocation. core_udp_close() should release the UDP port > allocation. > > core_udp_sendto() knows the remote IP address and remote UDP port and > must calculate the GatewayAddress. core_udp_connect() is passed the > remote IP address and UDP port, calculates the GatewayAddress and > stores all three for core_udp_send(). core_udp_send() should only > copy the local/remote IP address/UDP port and GatewayAddress, then set > the other flags/values as needed. > > Now to get core...

Hello, I tried to boot the new syslinux.efi (32bit) from the released syslinux 6 via PXE. In a wireshark trace I can see that the syslinux.efi was loaded successfully via TFTP. Then the client try to load ldlinux.e32. I see the request and also the acknoledgement in the trace. After that the client try to load the file, but the source port is changed to tftp request port + 1. For example:

On Fri, Nov 8, 2013 at 5:08 PM, Jason Matthews <jason.david.matthews at gmail.com> wrote: > I attempted the patch, but had to add a declaration to get it to compile. I > also added the gateway like before. Here's a link to the modified diff I > used and the pcaps from tftpserver and mirrored port from boot to reset. > > http://ge.tt/136167y/v/0 > > I'm also not

...MAC filter in the NIC. This should be uncessary as we're not capturinig. > +/** > + * Establish a connection on an open socket > + * > + * @param:socket, the open socket > + * @param:ip, the ip address > + * @param:port, the port number, host-byte order > + */ > +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, > + uint16_t port) > +{ > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); > + memcpy(&udata.RemoteA...

...&udata, NULL, NULL, NULL); + if (status != EFI_SUCCESS) + Print(L"Failed to get UDP mode data: %d\n", status); + else + socket->net.efi.localport = udata.StationPort; + return 0; bail: @@ -89,7 +100,6 @@ void core_udp_close(struct pxe_pvt_inode *socket) void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, uint16_t port) { - EFI_UDP4_CONFIG_DATA udata; EFI_STATUS status; EFI_UDP4 *udp; @@ -113,20 +123,6 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, return; } - /* - * If this is the first time con...

I did change both instances of txdata->GatewayAddress, but I think something may be wrong in my toolchain. If I extract syslinux.zip and attempt to make from there (without modifying any files), the cached DHCP packet isn't read on the same subnet. I receive "Succeed to download NBP file." twice before anything from syslinux is loaded, so I believe the duplicate request for