search for: core_temp

...m) } static int -nv40_temp_get(struct nvkm_therm *therm) +nv40_temp_get(struct nvkm_therm *therm, int *temp) { struct nvkm_device *device = therm->subdev.device; struct nvbios_therm_sensor *sensor = &therm->bios_sensor; @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) core_temp = core_temp + sensor->offset_num / sensor->offset_den; core_temp = core_temp + sensor->offset_constant - 8; - /* reserve negative temperatures for errors */ - if (core_temp < 0) - core_temp = 0; - - return core_temp; + *temp = core_temp; + return 0; } static int diff --git a/dr...

...emp_get(struct nvkm_therm *therm, int *temp) > > { > > struct nvkm_device *device = therm->subdev.device; > > struct nvbios_therm_sensor *sensor = &therm->bios_sensor; > > @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) > > core_temp = core_temp + sensor->offset_num / sensor->offset_den; > > core_temp = core_temp + sensor->offset_constant - 8; > > > > - /* reserve negative temperatures for errors */ > > - if (core_temp < 0) > > - core_temp = 0; > &gt...

...p_get(struct nvkm_therm *therm) > +nv40_temp_get(struct nvkm_therm *therm, int *val) > { > struct nvkm_device *device = therm->subdev.device; > struct nvbios_therm_sensor *sensor = &therm->bios_sensor; > @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) > core_temp = core_temp + sensor->offset_num / sensor->offset_den; > core_temp = core_temp + sensor->offset_constant - 8; > > - /* reserve negative temperatures for errors */ > - if (core_temp < 0) > - core_temp = 0; > - > - return core_temp; > + *val = core_temp; >...

...p_get(struct nvkm_therm *therm) > +nv40_temp_get(struct nvkm_therm *therm, int *val) > { > struct nvkm_device *device = therm->subdev.device; > struct nvbios_therm_sensor *sensor = &therm->bios_sensor; > @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) > core_temp = core_temp + sensor->offset_num / sensor->offset_den; > core_temp = core_temp + sensor->offset_constant - 8; > > - /* reserve negative temperatures for errors */ > - if (core_temp < 0) > - core_temp = 0; > - > - return core_temp; > + *val = core_temp; >...

...rm) } static int -nv40_temp_get(struct nvkm_therm *therm) +nv40_temp_get(struct nvkm_therm *therm, int *val) { struct nvkm_device *device = therm->subdev.device; struct nvbios_therm_sensor *sensor = &therm->bios_sensor; @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) core_temp = core_temp + sensor->offset_num / sensor->offset_den; core_temp = core_temp + sensor->offset_constant - 8; - /* reserve negative temperatures for errors */ - if (core_temp < 0) - core_temp = 0; - - return core_temp; + *val = core_temp; + return 0; } static int diff --git a/drm...

...struct nvkm_therm *therm, int *val) >>> { >>> struct nvkm_device *device = therm->subdev.device; >>> struct nvbios_therm_sensor *sensor = &therm->bios_sensor; >>> @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) >>> core_temp = core_temp + sensor->offset_num / sensor->offset_den; >>> core_temp = core_temp + sensor->offset_constant - 8; >>> >>> - /* reserve negative temperatures for errors */ >>> - if (core_temp < 0) >>> - core_temp = 0; &...

...herm *therm) > +nv40_temp_get(struct nvkm_therm *therm, int *temp) > { > struct nvkm_device *device = therm->subdev.device; > struct nvbios_therm_sensor *sensor = &therm->bios_sensor; > @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) > core_temp = core_temp + sensor->offset_num / sensor->offset_den; > core_temp = core_temp + sensor->offset_constant - 8; > > - /* reserve negative temperatures for errors */ > - if (core_temp < 0) > - core_temp = 0; > - > - return core_t...

...rm) } static int -nv40_temp_get(struct nvkm_therm *therm) +nv40_temp_get(struct nvkm_therm *therm, int *val) { struct nvkm_device *device = therm->subdev.device; struct nvbios_therm_sensor *sensor = &therm->bios_sensor; @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) core_temp = core_temp + sensor->offset_num / sensor->offset_den; core_temp = core_temp + sensor->offset_constant - 8; - /* reserve negative temperatures for errors */ - if (core_temp < 0) - core_temp = 0; - - return core_temp; + *val = core_temp; + return 0; } static int diff --git a/drm...

...*therm, int *temp) > > > { > > > struct nvkm_device *device = therm->subdev.device; > > > struct nvbios_therm_sensor *sensor = &therm->bios_sensor; > > > @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) > > > core_temp = core_temp + sensor->offset_num / sensor->offset_den; > > > core_temp = core_temp + sensor->offset_constant - 8; > > > > > > - /* reserve negative temperatures for errors */ > > > - if (core_temp < 0) > > > -...

...> +nv40_temp_get(struct nvkm_therm *therm, int *val) >> { >> struct nvkm_device *device = therm->subdev.device; >> struct nvbios_therm_sensor *sensor = &therm->bios_sensor; >> @@ -95,11 +95,8 @@ nv40_temp_get(struct nvkm_therm *therm) >> core_temp = core_temp + sensor->offset_num / sensor->offset_den; >> core_temp = core_temp + sensor->offset_constant - 8; >> >> - /* reserve negative temperatures for errors */ >> - if (core_temp < 0) >> - core_temp = 0; >> - >> -...

We should simply return errors while the GPU is turned off, because the sensors aren't accessable and setting any kind of value doesn't make any sense. Fixes sensors values reported by "sensors" Before: nouveau-pci-0100 Adapter: PCI adapter GPU core: +0.60 V (min = +0.60 V, max = +1.20 V) temp1: -0.0°C (high = +95.0°C, hyst = +3.0°C) (crit

Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of new gp1xx temperature sensor") added support for reading finer-grain temperatures, but continued to report temperatures in 1 degree Celsius increments via nvkm_therm_temp_get(). Rather than altering nvkm_therm_temp_get() to report finer-grain temperatures, which would be inconvenient for other users of the

Last update here: https://lists.freedesktop.org/archives/nouveau/2017-September/028848.html Basically big cleanup, reordering, simplifications and some renaming to make the code easier to read and to review. I also moved some bugfixes to the front so they can be merged prior the other patches. There was also a bug related to the therm daemon triggering a pstate change leading to PMU lockups,

Just wanted to post updated versions of my last series/patches. Reviews welcomed. It would be also nice if we agree on features I should focus upstreaming, so that this work can be better splitted or reordered. Sadly most of my patches depend on the rather big clk subdev rework and I think those patches shows best, why I think this rework is actually needed and makes things much easier to add