search for: coquelin

On Tue, Jul 04, 2023 at 10:43:07AM +0200, Maxime Coquelin wrote: > > > On 7/3/23 23:45, Michael S. Tsirkin wrote: > > On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote: > > > > > > On 7/3/23 08:44, Jason Wang wrote: > > > > On Sun, Jul 2, 2023 at 9:37?PM Michael S. Tsirkin <mst at redhat.com...

...reater than #vcpu, enable #vcpu queue pairs. Cc: Hannes Frederic Sowa <hannes at redhat.com> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Neil Horman <nhorman at redhat.com> Cc: Jeremy Eder <jeder at redhat.com> Cc: Marko Myllynen <myllynen at redhat.com> Cc: Maxime Coquelin <maxime.coquelin at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d4ac7a6..a21d93a 100644 --- a/drivers/n...

...reater than #vcpu, enable #vcpu queue pairs. Cc: Hannes Frederic Sowa <hannes at redhat.com> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Neil Horman <nhorman at redhat.com> Cc: Jeremy Eder <jeder at redhat.com> Cc: Marko Myllynen <myllynen at redhat.com> Cc: Maxime Coquelin <maxime.coquelin at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d4ac7a6..a21d93a 100644 --- a/drivers/n...

...l series from Jason Wang relaxing control queue polling [1] to function reliably. [1]: https://lore.kernel.org/lkml/CACGkMEtgrxN3PPwsDo4oOsnsSLJfEmBEZ0WvjGRr3whU+QasUg at mail.gmail.com/T/ RFC -> v1 changes: ================== - Fail device init if it does not support VERSION_1 (Jason) Maxime Coquelin (2): vduse: validate block features only with block devices vduse: enable Virtio-net device type drivers/vdpa/vdpa_user/vduse_dev.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) -- 2.41.0

...l series from Jason Wang relaxing control queue polling [1] to function reliably. [1]: https://lore.kernel.org/lkml/CACGkMEtgrxN3PPwsDo4oOsnsSLJfEmBEZ0WvjGRr3whU+QasUg at mail.gmail.com/T/ RFC -> v1 changes: ================== - Fail device init if it does not support VERSION_1 (Jason) Maxime Coquelin (2): vduse: validate block features only with block devices vduse: enable Virtio-net device type drivers/vdpa/vdpa_user/vduse_dev.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) -- 2.41.0

On 7/3/23 23:45, Michael S. Tsirkin wrote: > On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote: >> >> On 7/3/23 08:44, Jason Wang wrote: >>> On Sun, Jul 2, 2023 at 9:37?PM Michael S. Tsirkin <mst at redhat.com> wrote: >>>> >>>> On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: >>>>> This small series enabl...

On 7/3/23 08:44, Jason Wang wrote: > On Sun, Jul 2, 2023 at 9:37?PM Michael S. Tsirkin <mst at redhat.com> wrote: >> >> On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: >>> This small series enables virtio-net device type in VDUSE. >>> With it, basic operation have been tested, both with >>> virtio-vdpa and vhost-vdpa using DPDK Vhost library series >>> adding VDUSE support using split rings layout (merged in >>>...

On Tue, Jul 04, 2023 at 06:40:45PM +0200, Maxime Coquelin wrote: > Virtio-net driver control queue implementation is not safe > when used with VDUSE. If the VDUSE application does not > reply to control queue messages, it currently ends up > hanging the kernel thread sending this command. > > Some work is on-going to make the control qu...

...). [1]: https://lore.kernel.org/lkml/CACGkMEtgrxN3PPwsDo4oOsnsSLJfEmBEZ0WvjGRr3whU+QasUg at mail.gmail.com/T/ v1 -> v2 changes: ================= - Add a patch to disable CVQ (Michael) RFC -> v1 changes: ================== - Fail device init if it does not support VERSION_1 (Jason) Maxime Coquelin (3): vduse: validate block features only with block devices vduse: enable Virtio-net device type vduse: Temporarily disable control queue features drivers/vdpa/vdpa_user/vduse_dev.c | 36 ++++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-) -- 2.41.0

On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote: > > On 7/3/23 08:44, Jason Wang wrote: > > On Sun, Jul 2, 2023 at 9:37?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: > > > > This small series enables virtio-net...

...reply to control queue messages, it currently ends up hanging the kernel thread sending this command. Some work is on-going to make the control queue implementation robust with VDUSE. Until it is completed, let's disable control virtqueue and features that depend on it. Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com> --- drivers/vdpa/vdpa_user/vduse_dev.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index 1271c9796517..04367a53802b 100644 --- a/drivers/vdpa/vdpa_user/vduse...

...t;] sock_sendmsg+0x8f/0xa0 [<0>] __sys_sendto+0xfc/0x170 [<0>] __x64_sys_sendto+0x20/0x30 [<0>] do_syscall_64+0x59/0x90 [<0>] entry_SYSCALL_64_after_hwframe+0x72/0xdc Once fixed on DPDK side (you can use my vduse_v1 branch [0] for testing), it works fine: Tested-by: Maxime Coquelin <maxime.coquelin at redhat.com> For the potential missing interrupt with non-compliant devices, I guess it could be handled with the hardening work as same thing could happen if the VDUSE application crashed for example. Regards, Maxime [0]: > Thanks > > Changes since V1: > -...

On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: > This small series enables virtio-net device type in VDUSE. > With it, basic operation have been tested, both with > virtio-vdpa and vhost-vdpa using DPDK Vhost library series > adding VDUSE support using split rings layout (merged in > DPDK v23.07-rc1). > > Control qu...

On Sun, Jul 2, 2023 at 9:37?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: > > This small series enables virtio-net device type in VDUSE. > > With it, basic operation have been tested, both with > > virtio-vdpa and vhost-vdpa using DPDK Vhost library series > > adding VDUSE support using split rings layout (merged in > > DPDK v23.07-rc...

...Cc: Hannes Frederic Sowa <hannes at redhat.com> >> Cc: Michael S. Tsirkin <mst at redhat.com> >> Cc: Neil Horman <nhorman at redhat.com> >> Cc: Jeremy Eder <jeder at redhat.com> >> Cc: Marko Myllynen <myllynen at redhat.com> >> Cc: Maxime Coquelin <maxime.coquelin at redhat.com> >> Signed-off-by: Jason Wang <jasowang at redhat.com> > > OK at some level but all uses of num_online_cpus() > like this are racy versus hotplug. > I know we already have this bug but shouldn't we fix it > before we add more? Th...

...Cc: Hannes Frederic Sowa <hannes at redhat.com> >> Cc: Michael S. Tsirkin <mst at redhat.com> >> Cc: Neil Horman <nhorman at redhat.com> >> Cc: Jeremy Eder <jeder at redhat.com> >> Cc: Marko Myllynen <myllynen at redhat.com> >> Cc: Maxime Coquelin <maxime.coquelin at redhat.com> >> Signed-off-by: Jason Wang <jasowang at redhat.com> > > OK at some level but all uses of num_online_cpus() > like this are racy versus hotplug. > I know we already have this bug but shouldn't we fix it > before we add more? Th...

On Fri, Jul 21, 2023 at 04:58:04PM +0200, Maxime Coquelin wrote: > > > On 7/21/23 16:45, Michael S. Tsirkin wrote: > > On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote: > > > > > > > > > On 7/20/23 23:02, Michael S. Tsirkin wrote: > > > > On Thu, Jul 20, 2023 at 01:26:20PM -0700, Sha...

On 8/29/23 19:05, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2023 at 03:34:06PM +0200, Maxime Coquelin wrote: >> >> >> On 8/11/23 00:00, Jakub Kicinski wrote: >>> On Thu, 10 Aug 2023 17:42:11 -0400 Michael S. Tsirkin wrote: >>>>> Directly into the stack? I thought VDUSE is vDPA in user space, >>>>> meaning to get to the kernel the packet has t...

On 7/21/23 16:45, Michael S. Tsirkin wrote: > On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote: >> >> >> On 7/20/23 23:02, Michael S. Tsirkin wrote: >>> On Thu, Jul 20, 2023 at 01:26:20PM -0700, Shannon Nelson wrote: >>>> On 7/20/23 1:38 AM, Jason Wang wrote: >>>>> >>>>> Adding cond_resched() to the command waiting lo...

...ue pairs. > > Cc: Hannes Frederic Sowa <hannes at redhat.com> > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Neil Horman <nhorman at redhat.com> > Cc: Jeremy Eder <jeder at redhat.com> > Cc: Marko Myllynen <myllynen at redhat.com> > Cc: Maxime Coquelin <maxime.coquelin at redhat.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> OK at some level but all uses of num_online_cpus() like this are racy versus hotplug. I know we already have this bug but shouldn't we fix it before we add more? > --- > drivers/net/vir...