search for: copy_sysappend_string

Hello, The description of SYSAPPEND for the DMI information states that the spaces are replaced by underscores, but this replacement does not occur in 6.03. There's small bug present in triplicata in com32/elflink/ldlinux/readconfig.c:copy_sysappend_string(), com32/menu/readconfig.c:copy_sysappend_string(), and core/sysappend.c:copy_and_mangle() prevent proper replacement of spaces by underscore. Here's a patch which fix this (only tested via BIOS PXELINUX) diff -pruN syslinux-6.03.orig/com32/elflink/ldlinux/readconfig.c syslinux-6.03.d mi/com3...

...| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/com32/elflink/ldlinux/readconfig.c b/com32/elflink/ldlinux/readconfig.c index 381b43f..dcdf91b 100644 --- a/com32/elflink/ldlinux/readconfig.c +++ b/com32/elflink/ldlinux/readconfig.c @@ -330,7 +330,7 @@ static char *copy_sysappend_string(char *dst, const char *src) char c; while ((c = *src++)) { - if (c <= ' ' || c == '\x7f') { + if (c <= ' ' && c == '\x7f') { if (!was_space) *dst++ = '_'; was_space = true; diff --git a/com32/menu/readconfig.c b/com32/...

On Tue, Jun 30, 2015 at 4:29 PM, poma <pomidorabelisima at gmail.com> wrote: > "A real serial port that can reliably operate at 115200 8n1 may be > necessary." > > Gene, is there something special in "A real serial port" usage, compared to emulated? I should restate: A serial port that responds on BIOS IO port 3F8h that can reliably operate at 115200 8n1 may

...015 01:35 AM, poma via Syslinux wrote: > > diff --git a/com32/elflink/ldlinux/readconfig.c b/com32/elflink/ldlinux/readconfig.c > index 381b43f..dcdf91b 100644 > --- a/com32/elflink/ldlinux/readconfig.c > +++ b/com32/elflink/ldlinux/readconfig.c > @@ -330,7 +330,7 @@ static char *copy_sysappend_string(char *dst, const char *src) > char c; > > while ((c = *src++)) { > - if (c <= ' ' || c == '\x7f') { > + if (c <= ' ' && c == '\x7f') { > if (!was_space) > *dst++ = '_'; > was_space = true; I th...

Hi, Ady wrote: > IMHO, the adequate way to solve the problem is finding why vesamenu.c32 > triggers a problem when it is compiled with gcc v.5+. I agree. Currently i am riddling why copy_sysappend_string() should be invoked at all. txt/syslinux.cfg.txt obviously describes the .cfg interface of readconfig.c:record() as "SYSAPPEND" and its flag values. Rawhide-Live-Xfce-628.iso from http://goo.gl/Gm4ffO has no such directive. So probably it's about the change in core/sysappend.c functi...

...return (unsigned char)c <= ' ' || (unsigned char)c == '\x7f'; } int my_isxdigit(char c); diff --git a/com32/menu/readconfig.c b/com32/menu/readconfig.c index b7814be..a433fad 100644 --- a/com32/menu/readconfig.c +++ b/com32/menu/readconfig.c @@ -299,7 +299,7 @@ static char *copy_sysappend_string(char *dst, const char *src) char c; while ((c = *src++)) { - if (c <= ' ' || c == '\x7f') { + if (my_isspace(c)) { if (!was_space) *dst++ = '_'; was_space = true;

On 02.07.2015 11:10, Thomas Schmitt wrote: > Hi, > > poma wrote: >> - if (c <= ' ' || c == '\x7f') { >> + if (c <= ' ' && c == '\x7f') { > > As Geert Stappers pointed out (and can be verified by a > simple test program), the reinstated term > (c <= ' ' && c == '\x7f') >

...return (unsigned char)c <= ' ' || (unsigned char)c == '\x7f'; } int my_isxdigit(char c); diff --git a/com32/menu/readconfig.c b/com32/menu/readconfig.c index 257b042..a433fad 100644 --- a/com32/menu/readconfig.c +++ b/com32/menu/readconfig.c @@ -299,7 +299,7 @@ static char *copy_sysappend_string(char *dst, const char *src) char c; while ((c = *src++)) { - if (c <= ' ' || c == '\x7f') { + if (my_isspace(c)) { if (!was_space) *dst++ = '_'; was_space = true;

Hi, hpa wrote: > On PowerPC (I think) "unsigned char" is the default. In any case it seems a good idea to interpret the character more explicitely. To my experience, one signdness change causes a little tree of consequential signedness changes or questionable cast operations. How about the following instead ? if ((c >= 0 && c <= ' ') || c == '\x7f')