Displaying 4 results from an estimated 4 matches for "copy_and_mangle".
2014 Nov 05
0
SYSAPPEND not replacing spaces
...D for the DMI information states that the spaces are replaced by underscores, but this replacement does not occur in 6.03. There's small bug present in triplicata in com32/elflink/ldlinux/readconfig.c:copy_sysappend_string(), com32/menu/readconfig.c:copy_sysappend_string(), and core/sysappend.c:copy_and_mangle() prevent proper replacement of spaces by underscore.
Here's a patch which fix this (only tested via BIOS PXELINUX)
diff -pruN syslinux-6.03.orig/com32/elflink/ldlinux/readconfig.c syslinux-6.03.d
mi/com32/elflink/ldlinux/readconfig.c
--- syslinux-6.03.orig/com32/elflink/ldlinux/readconfig.c...
2015 Jul 01
5
boot... round 2
...\x7f') {
+ if (c <= ' ' && c == '\x7f') {
if (!was_space)
*dst++ = '_';
was_space = true;
diff --git a/core/sysappend.c b/core/sysappend.c
index 758703e..5c3f650 100644
--- a/core/sysappend.c
+++ b/core/sysappend.c
@@ -35,7 +35,7 @@ static char *copy_and_mangle(char *dst, const char *src)
char c;
while ((c = *src++)) {
- if (c <= ' ' || c == '\x7f') {
+ if (c <= ' ' && c == '\x7f') {
if (!was_space)
*dst++ = '_';
was_space = true;
--
2.4.5
2015 Jul 02
2
boot... round 2
...should
be invoked at all. txt/syslinux.cfg.txt obviously describes
the .cfg interface of readconfig.c:record() as "SYSAPPEND"
and its flag values.
Rawhide-Live-Xfce-628.iso from http://goo.gl/Gm4ffO has no
such directive.
So probably it's about the change in core/sysappend.c
function copy_and_mangle() which might be called underneath
execute() of com32/elflink/ldlinux/execute.c.
But this still does not explain why gcc versions are
decisive for success. For that we'd need to find some code
of undefined behavior, where the compiler would be free
to produce different outcome.
hpa wrote:
&g...
2015 Jun 30
4
boot... round 2
On Tue, Jun 30, 2015 at 4:29 PM, poma <pomidorabelisima at gmail.com> wrote:
> "A real serial port that can reliably operate at 115200 8n1 may be
> necessary."
>
> Gene, is there something special in "A real serial port" usage, compared to emulated?
I should restate: A serial port that responds on BIOS IO port 3F8h
that can reliably operate at 115200 8n1 may