search for: convert_from_xrgb8888

...+static u32 convert_xrgb8888_to_abgr2101010(u32 pix) +{ + pix = ((pix & 0x00FF0000) >> 14) | + ((pix & 0x0000FF00) << 4) | + ((pix & 0x000000FF) << 22); + return GENMASK(31, 30) /* set alpha bits */ | pix | ((pix >> 8) & 0x00300C03); +} + /* * convert_from_xrgb8888 - convert one pixel from xrgb8888 to the desired format * @color: input color, in xrgb8888 format @@ -242,6 +250,8 @@ static u32 convert_from_xrgb8888(u32 color, u32 format) return convert_xrgb8888_to_xrgb2101010(color); case DRM_FORMAT_ARGB2101010: return convert_xrgb8888_to_argb2101010(...

...> + ((pix & 0x000000FF) << 22); > + return GENMASK(31, 30) /* set alpha bits */ | pix | ((pix >> 8) & 0x00300C03); > +} Maybe we can move this format conversion helper and the others in the driver to drivers/gpu/drm/drm_format_helper.c ? > + > /* > * convert_from_xrgb8888 - convert one pixel from xrgb8888 to the desired format > * @color: input color, in xrgb8888 format > @@ -242,6 +250,8 @@ static u32 convert_from_xrgb8888(u32 color, u32 format) > return convert_xrgb8888_to_xrgb2101010(color); > case DRM_FORMAT_ARGB2101010: > return convert...

...in a separate module, so you can't call its functions from the main drm module, where drm_panic is. In my drm_log series, https://patchwork.freedesktop.org/series/136789/ I moved this to drm_draw.c, and maybe drm_format_helper could re-use that ? > >> + >> /* >> * convert_from_xrgb8888 - convert one pixel from xrgb8888 to the desired format >> * @color: input color, in xrgb8888 format >> @@ -242,6 +250,8 @@ static u32 convert_from_xrgb8888(u32 color, u32 format) >> return convert_xrgb8888_to_xrgb2101010(color); >> case DRM_FORMAT_ARGB2101010: &gt...

This series adds basic drm_panic support for nouveau. Patches 1 Add ABGR2101010 support in drm_panic. Patch 2 registers nouveau to drm_panic, and handle tiling. I've tested on a GTX1650 (Turing) and GF 8800 GT (Tesla), while running Gnome/Wayland desktop, and in VT. It should work on other nv50+ cards, but I didn't test them. To test it, you need to build your kernel with