search for: control_work_handler

...t i2c_piix4 soundcore pvpanic btrfs qxl xor raid6_pq drm_kms_helper ttm drm 8139too virtio_pci virtio_rini [ 2.201004] CPU: 0 PID: 71 Comm: kworker/0:2 Not tainted 3.18.0-0.rc1.git0.1.fc22.x86_64 #1 [ 2.201004] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 2.201004] Workqueue: events control_work_handler [virtio_console] [ 2.201004] task: ffff88003a83f5c0 ti: ffff88003a98c000 task.ti: ffff88003a98c000 [ 2.201004] RIP: 0010:[<ffffffffa0210032>] [<ffffffffa0210032>] virtio_device_ready.part.12+0x4/0x6 [virtio_console] [ 2.201004] RSP: 0018:ffff88003a98fd18 EFLAGS: 00010202 [...

...t i2c_piix4 soundcore pvpanic btrfs qxl xor raid6_pq drm_kms_helper ttm drm 8139too virtio_pci virtio_rini [ 2.201004] CPU: 0 PID: 71 Comm: kworker/0:2 Not tainted 3.18.0-0.rc1.git0.1.fc22.x86_64 #1 [ 2.201004] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 2.201004] Workqueue: events control_work_handler [virtio_console] [ 2.201004] task: ffff88003a83f5c0 ti: ffff88003a98c000 task.ti: ffff88003a98c000 [ 2.201004] RIP: 0010:[<ffffffffa0210032>] [<ffffffffa0210032>] virtio_device_ready.part.12+0x4/0x6 [virtio_console] [ 2.201004] RSP: 0018:ffff88003a98fd18 EFLAGS: 00010202 [...

The in-vq operations were protected by a lock, but the out-vq operations were not. This caused panics / errors as described in patch 2. Fix that. The first patch renames the existing cvq_lock to c_ivq_lock to match c_ivq. The second patch introduces the c_ovq_lock for the c_ovq. Please apply. I also believe this is a candidate for stable. v2: * Use spin_lock instead of spin_lock_irq.

The in-vq operations were protected by a lock, but the out-vq operations were not. This caused panics / errors as described in patch 2. Fix that. The first patch renames the existing cvq_lock to c_ivq_lock to match c_ivq. The second patch introduces the c_ovq_lock for the c_ovq. Please apply. I also believe this is a candidate for stable. v2: * Use spin_lock instead of spin_lock_irq.

Hello, The first patch here fixes the race seen by Miche. He hasn't yet reported back if this fixes the races he saw, but Joy Pu from Red Hat tested this patch with hot-plugging/unplugging ports in a loop. Before this patch, he saw some freezes as well as sysfs warnings. After applying the patch, all was well. The second patch can be folded into the series fixing S4 for virtio-console. It

Hello, The first patch here fixes the race seen by Miche. He hasn't yet reported back if this fixes the races he saw, but Joy Pu from Red Hat tested this patch with hot-plugging/unplugging ports in a loop. Before this patch, he saw some freezes as well as sysfs warnings. After applying the patch, all was well. The second patch can be folded into the series fixing S4 for virtio-console. It

The in-vq operations were protected by a lock, but the out-vq operations were not. This caused panics / errors as described in patch 2. Fix that. The first patch renames the existing cvq_lock to c_ivq_lock to match c_ivq. The second patch introduces the c_ovq_lock for the c_ovq. Please apply. I also believe this is a candidate for stable. Amit Shah (2): virtio: console: rename cvq_lock

The in-vq operations were protected by a lock, but the out-vq operations were not. This caused panics / errors as described in patch 2. Fix that. The first patch renames the existing cvq_lock to c_ivq_lock to match c_ivq. The second patch introduces the c_ovq_lock for the c_ovq. Please apply. I also believe this is a candidate for stable. Amit Shah (2): virtio: console: rename cvq_lock

...m_mirror dm_region_hash dm_log dm_mod [last unloaded: virtio_console] [ 81.517019] CPU: 0 PID: 785 Comm: kworker/0:2 Kdump: loaded Not tainted 4.18.0-167.el8.x86_64 #1 [ 81.518639] Hardware name: Red Hat KVM, BIOS 1.12.0-5.scrmod+el8.2.0+5159+d8aa4d83 04/01/2014 [ 81.520205] Workqueue: events control_work_handler [virtio_console] [ 81.521354] RIP: 0010:__pv_queued_spin_unlock_slowpath+0xc0/0xd0 [ 81.522450] Code: 07 00 48 63 7a 10 e8 bf 64 f5 ff 66 90 c3 8b 05 e6 cf d6 01 85 c0 74 01 c3 8b 17 48 89 fe 48 c7 c7 38 4b 29 91 e8 3a 6c fa ff <0f> 0b c3 0f 0b 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00...

...1] SMP [ 0.444004] Modules linked in: virtio_pci virtio_console 9pnet_virtio virtio_ring virtio 9p 9pnet fscache [ 0.444004] CPU: 0 PID: 71 Comm: kworker/0:3 Not tainted 3.13.7-200.fc20.x86_64 #1 [ 0.444004] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 0.444004] Workqueue: events control_work_handler [virtio_console] [ 0.444004] task: ffff88007bc04500 ti: ffff88007bcca000 task.ti: ffff88007bcca000 [ 0.444004] RIP: 0010:[<ffffffff81d69c60>] [<ffffffff81d69c60>] hvc_console_setup+0x0/0x24 [ 0.444004] RSP: 0018:ffff88007bccbd40 EFLAGS: 00010246 [ 0.444004] RAX: 0000000000...

...1] SMP [ 0.444004] Modules linked in: virtio_pci virtio_console 9pnet_virtio virtio_ring virtio 9p 9pnet fscache [ 0.444004] CPU: 0 PID: 71 Comm: kworker/0:3 Not tainted 3.13.7-200.fc20.x86_64 #1 [ 0.444004] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 0.444004] Workqueue: events control_work_handler [virtio_console] [ 0.444004] task: ffff88007bc04500 ti: ffff88007bcca000 task.ti: ffff88007bcca000 [ 0.444004] RIP: 0010:[<ffffffff81d69c60>] [<ffffffff81d69c60>] hvc_console_setup+0x0/0x24 [ 0.444004] RSP: 0018:ffff88007bccbd40 EFLAGS: 00010246 [ 0.444004] RAX: 0000000000...

...s/char/virtio_console.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 8e3c46d..72d396c 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1466,6 +1466,7 @@ static void control_work_handler(struct work_struct *work) portdev = container_of(work, struct ports_device, control_work); vq = portdev->c_ivq; + start: spin_lock(&portdev->cvq_lock); while ((buf = virtqueue_get_buf(vq, &len))) { spin_unlock(&portdev->cvq_lock); @@ -1483,6 +1484,10 @@ static void...

...s/char/virtio_console.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 8e3c46d..72d396c 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1466,6 +1466,7 @@ static void control_work_handler(struct work_struct *work) portdev = container_of(work, struct ports_device, control_work); vq = portdev->c_ivq; + start: spin_lock(&portdev->cvq_lock); while ((buf = virtqueue_get_buf(vq, &len))) { spin_unlock(&portdev->cvq_lock); @@ -1483,6 +1484,10 @@ static void...

...vers/char/virtio_console.c index fae2dbb..def736d 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -2040,12 +2040,13 @@ static int virtcons_probe(struct virtio_device *vdev) virtio_device_ready(portdev->vdev); + INIT_WORK(&portdev->control_work, &control_work_handler); + if (multiport) { unsigned int nr_added_bufs; spin_lock_init(&portdev->c_ivq_lock); spin_lock_init(&portdev->c_ovq_lock); - INIT_WORK(&portdev->control_work, &control_work_handler); nr_added_bufs = fill_queue(portdev->c_ivq, &portdev-&g...

...vers/char/virtio_console.c index fae2dbb..def736d 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -2040,12 +2040,13 @@ static int virtcons_probe(struct virtio_device *vdev) virtio_device_ready(portdev->vdev); + INIT_WORK(&portdev->control_work, &control_work_handler); + if (multiport) { unsigned int nr_added_bufs; spin_lock_init(&portdev->c_ivq_lock); spin_lock_init(&portdev->c_ovq_lock); - INIT_WORK(&portdev->control_work, &control_work_handler); nr_added_bufs = fill_queue(portdev->c_ivq, &portdev-&g...

...cread(vdev, struct virtio_console_config, rows, &rows); @@ -2040,6 +2052,7 @@ static int virtcons_probe(struct virtio_device *vdev) virtio_device_ready(portdev->vdev); + INIT_WORK(&portdev->config_work, &config_work_handler); INIT_WORK(&portdev->control_work, &control_work_handler); if (multiport) { @@ -2114,6 +2127,8 @@ static void virtcons_remove(struct virtio_device *vdev) /* Finish up work that's lined up */ if (use_multiport(portdev)) cancel_work_sync(&portdev->control_work); + else + cancel_work_sync(&portdev->config_work); list_for_ea...

...cread(vdev, struct virtio_console_config, rows, &rows); @@ -2040,6 +2052,7 @@ static int virtcons_probe(struct virtio_device *vdev) virtio_device_ready(portdev->vdev); + INIT_WORK(&portdev->config_work, &config_work_handler); INIT_WORK(&portdev->control_work, &control_work_handler); if (multiport) { @@ -2114,6 +2127,8 @@ static void virtcons_remove(struct virtio_device *vdev) /* Finish up work that's lined up */ if (use_multiport(portdev)) cancel_work_sync(&portdev->control_work); + else + cancel_work_sync(&portdev->config_work); list_for_ea...

...kd grace sunrpc qxl drm_kms_helper ttm drm virtio_blk i2c_core virtio_pci ata_generic virtio_ring virtio pata_acpi > [ 1.840169] CPU: 2 PID: 266 Comm: kworker/2:2 Not tainted 3.17.0+ #1 > [ 1.840169] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > [ 1.840169] Workqueue: events control_work_handler [virtio_console] > [ 1.840169] task: ffff8800364bc840 ti: ffff880078490000 task.ti: ffff880078490000 > [ 1.840169] RIP: 0010:[<ffffffffa01d92c6>] [<ffffffffa01d92c6>] virtio_device_ready.part.12+0x4/0x6 [virtio_console] > [ 1.840169] RSP: 0018:ffff880078493c78 EFLAGS...

...ude/linux/virtio_config.h:125! [ 0.831266] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC [ 0.831266] Modules linked in: [ 0.831266] CPU: 1 PID: 30 Comm: kworker/1:1 Not tainted 3.18.0-rc4 #120 [ 0.831266] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 0.831266] Workqueue: events control_work_handler [ 0.831266] task: ffff88003cd98000 ti: ffff88003cd94000 task.ti: ffff88003cd94000 [ 0.831266] RIP: 0010:[<ffffffff81445004>] [<ffffffff81445004>] add_port+0x264/0x410 [ 0.831266] RSP: 0000:ffff88003cd97c78 EFLAGS: 00010202 [ 0.831266] RAX: 0000000000000007 RBX: ffff88003...

virtio spec 0.9.X requires DRIVER_OK to be set before VQs are used, but some drivers use VQs before probe function returns. Since DRIVER_OK is set after probe, this violates the spec. Even though under virtio 1.0 transitional devices support this behaviour, we want to make it possible for those early callers to become spec compliant and eventually support non-transitional devices. Add API for