search for: content_cb

We were seeing 100% failure rates transferring 10G disk images from ESX on a particular setup. We also weren't spotting the transfer failure, and dying with a strange error from libguestfs. These 2 patches fix the error check which should have made it obvious what was failing, and the underlying error.

...$url = _get_vol_url($self->{_v2v_server}, $vmdk, $datastore); + } + } + + else { + $self->report_error($r); + } } $self->{_v2v_received} = 0; - $r = $self->get($url, + my $r = $self->get($url, ':content_cb' => sub { $self->handle_data(@_); }, ':read_size_hint' => 64 * 1024); @@ -160,6 +181,17 @@ sub get_volume $self->report_error($r); } +sub _get_vol_url +{ + my ($server, $vmdk, $datastore) = @_; + + my $url = URI->new("https://&quo...

...2V/Transfer/ESX.pm +++ b/lib/Sys/VirtV2V/Transfer/ESX.pm @@ -140,6 +140,7 @@ sub get_volume "{error}", error => $@->stringify()))); } + $self->{_v2v_received} = 0; my $r = $self->SUPER::get($url, ':content_cb' => sub { $self->handle_data(@_); }, ':read_size_hint' => 64 * 1024); @@ -150,10 +151,18 @@ sub get_volume die($died) if (defined($died)); # Close the volume file descriptor - close($self->{_v2v_volfh}); + clos...

The following patches are where I'm currently at with ESX support. I can now import a domain from ESX along with its storage. Note that I'm not yet doing any conversion. In fact, I've never even tested past the import stage (I just had an exit in there). The meat is really in the 4th patch. The rename of MetadataReader->Connection was because the Connection is now really providing

With this patchset I have successfully[1] imported a RHEL 5 guest directly from ESX with the following command line: virt-v2v -ic 'esx://yellow.marston/?no_verify=1' -op transfer RHEL5-64 Login details are stored in ~/.netrc Note that this is the only guest I've tested against. I haven't for example, checked that I haven't broken Xen imports. Matt [1] With the exception of

...atastore); - } - } + $self->_verify_certificate($conn, $uri->host) unless ($self->{noverify}); - else { - $self->report_error($r); - } - } - - $self->{_v2v_received} = 0; - my $r = $self->get($url, - ':content_cb' => sub { $self->handle_data(@_); }, - ':read_size_hint' => 64 * 1024); - - if ($r->is_success) { - # It reports success even if one of the callbacks died - my $died = $r->header('X-Died'); - die($died) if (defined($died)...