search for: containsnoduplicateinst

Hi, Thanks for the pointers. My patch now calls the attribute "noduplicate", and updates CodeMetrics to have another field: bool notDuplicatable; Which semantically is "containsIndirectBr || containsNoDuplicateInst". I didn't repurpose containsIndirectBr because I felt what I'm looking for is sufficiently different (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). I still need to ensure InlineCost is correct; patch will be incoming tomorrow morning. All us...

...mes Molloy <James.Molloy at arm.com> wrote: > Hi, > > Thanks for the pointers. My patch now calls the attribute "noduplicate", > and updates CodeMetrics to have another field: > > bool notDuplicatable; > > Which semantically is "containsIndirectBr || containsNoDuplicateInst". I > didn't repurpose containsIndirectBr because I felt what I'm looking for > is sufficiently different (indirectbr inhibits inlining, whereas > noduplicate does not, if there is one call site). I'm pretty sure that it's fine to inline indirectbr if there is a singl...

...; wrote: > > > Hi, > > > > Thanks for the pointers. My patch now calls the attribute "noduplicate", > > and updates CodeMetrics to have another field: > > > > bool notDuplicatable; > > > > Which semantically is "containsIndirectBr || containsNoDuplicateInst". I > > didn't repurpose containsIndirectBr because I felt what I'm looking for > > is sufficiently different (indirectbr inhibits inlining, whereas > > noduplicate does not, if there is one call site). > > I'm pretty sure that it's fine to inline indire...

...; > > Hi, > > > > Thanks for the pointers. My patch now calls the attribute > > "noduplicate", and updates CodeMetrics to have another field: > > > > bool notDuplicatable; > > > > Which semantically is "containsIndirectBr || > > containsNoDuplicateInst". I didn't repurpose containsIndirectBr > > because I felt what I'm looking for is sufficiently different > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > I'm pretty sure that it's fine to inline indirectbr if...

...t; > Thanks for the pointers. My patch now calls the attribute > > > "noduplicate", and updates CodeMetrics to have another field: > > > > > > bool notDuplicatable; > > > > > > Which semantically is "containsIndirectBr || > > > containsNoDuplicateInst". I didn't repurpose containsIndirectBr > > > because I felt what I'm looking for is sufficiently different > > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > > > I'm pretty sure that it's fine to inl...

...> Thanks for the pointers. My patch now calls the attribute > > > "noduplicate", and updates CodeMetrics to have another field: > > > > > > bool notDuplicatable; > > > > > > Which semantically is "containsIndirectBr || > > > containsNoDuplicateInst". I didn't repurpose containsIndirectBr > > > because I felt what I'm looking for is sufficiently different > > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > > > I'm pretty sure that it's fine to i...

On Dec 2, 2012, at 10:11 PM, Chris Lattner <clattner at apple.com> wrote: > 3) Please change random parts of the compiler to use CodeMetrics, instead of scattering random checks for this attribute throughout the code. Anything duplicating code and not using CodeMetrics is just plain incorrect. One problem that we may run into when using CodeMetrics is compile time. In many cases we

On Dec 1, 2012, at 11:49 PM, "Kuperstein, Michael M" <michael.m.kuperstein at intel.com> wrote: > I definitely support this. > > In fact we were about to send a very similar proposal. The main difference I can see between this proposal and ours was that we named the attribute "noduplicate". > I graciously defer to James on the bikeshade color issue. Yes,