search for: containsindirectbr

Hi, Thanks for the pointers. My patch now calls the attribute "noduplicate", and updates CodeMetrics to have another field: bool notDuplicatable; Which semantically is "containsIndirectBr || containsNoDuplicateInst". I didn't repurpose containsIndirectBr because I felt what I'm looking for is sufficiently different (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). I still need to ensure InlineCost is correct; patch will be incomin...

..., 2012, at 9:48 AM, James Molloy <James.Molloy at arm.com> wrote: > Hi, > > Thanks for the pointers. My patch now calls the attribute "noduplicate", > and updates CodeMetrics to have another field: > > bool notDuplicatable; > > Which semantically is "containsIndirectBr || containsNoDuplicateInst". I > didn't repurpose containsIndirectBr because I felt what I'm looking for > is sufficiently different (indirectbr inhibits inlining, whereas > noduplicate does not, if there is one call site). I'm pretty sure that it's fine to inline ind...

...s.Molloy at arm.com> wrote: > > > Hi, > > > > Thanks for the pointers. My patch now calls the attribute "noduplicate", > > and updates CodeMetrics to have another field: > > > > bool notDuplicatable; > > > > Which semantically is "containsIndirectBr || containsNoDuplicateInst". I > > didn't repurpose containsIndirectBr because I felt what I'm looking for > > is sufficiently different (indirectbr inhibits inlining, whereas > > noduplicate does not, if there is one call site). > > I'm pretty sure that it&...

...ning" has other naming implications in llvm related to function bodies, but calls to a noduplicate function should not be duplicated in any way (e.g. tail duplication, loop unrolling, etc). 2) please have the llvm/Analysis/CodeMetrics.h code consider them to be unduplicatable (generalizing the containsIndirectBr bit). 3) Please change random parts of the compiler to use CodeMetrics, instead of scattering random checks for this attribute throughout the code. Anything duplicating code and not using CodeMetrics is just plain incorrect. -Chris

....Molloy at arm.com> wrote: > > > Hi, > > > > Thanks for the pointers. My patch now calls the attribute > > "noduplicate", and updates CodeMetrics to have another field: > > > > bool notDuplicatable; > > > > Which semantically is "containsIndirectBr || > > containsNoDuplicateInst". I didn't repurpose containsIndirectBr > > because I felt what I'm looking for is sufficiently different > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > I'm pretty sure that...

...> > Hi, > > > > > > Thanks for the pointers. My patch now calls the attribute > > > "noduplicate", and updates CodeMetrics to have another field: > > > > > > bool notDuplicatable; > > > > > > Which semantically is "containsIndirectBr || > > > containsNoDuplicateInst". I didn't repurpose containsIndirectBr > > > because I felt what I'm looking for is sufficiently different > > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > > > I...

...> > Hi, > > > > > > Thanks for the pointers. My patch now calls the attribute > > > "noduplicate", and updates CodeMetrics to have another field: > > > > > > bool notDuplicatable; > > > > > > Which semantically is "containsIndirectBr || > > > containsNoDuplicateInst". I didn't repurpose containsIndirectBr > > > because I felt what I'm looking for is sufficiently different > > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > > >...

On Dec 2, 2012, at 10:11 PM, Chris Lattner <clattner at apple.com> wrote: > 3) Please change random parts of the compiler to use CodeMetrics, instead of scattering random checks for this attribute throughout the code. Anything duplicating code and not using CodeMetrics is just plain incorrect. One problem that we may run into when using CodeMetrics is compile time. In many cases we

I definitely support this. In fact we were about to send a very similar proposal. The main difference I can see between this proposal and ours was that we named the attribute "noduplicate". I graciously defer to James on the bikeshade color issue. Michael -----Original Message----- From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of James Molloy

Hi, OpenCL has a "barrier" function with very specific semantics, and there is currently no analogue to model this in LLVM. This has been touched on by the SPIR folks but I don't believe they put forward a proposal. The barrier function is a special function that ensures that all workitems executing a kernel have executed up to that point before execution on any workitem can