search for: contains_old_style_appliance

...@ -162,7 +152,7 @@ build_appliance (guestfs_h *g, > return 0; > } > > - /* Step (4). */ > + /* Step (2). */ The steps actually refer to the documentation. See in the same file, starting from " * Locate or build the appliance." Rich. > r = find_path (g, contains_old_style_appliance, NULL, &path); > if (r == -1) > return -1; > @@ -177,6 +167,16 @@ build_appliance (guestfs_h *g, > return 0; > } > > + /* Step (3). */ > + r = find_path (g, contains_supermin_appliance, NULL, &supermin_path); > + if (r == -1) > + return...

...+++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 33 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 2cf6374..d293c2b 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -48,7 +48,7 @@ static int dir_contains_files (guestfs_h *g, const char *dir, ...); static int contains_old_style_appliance (guestfs_h *g, const char *path, void *data); static int contains_fixed_appliance (guestfs_h *g, const char *path, void *data); static int contains_supermin_appliance (guestfs_h *g, const char *path, void *data); -static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, uid_t...

..., 3 insertions(+), 3 deletions(-) > > diff --git a/lib/appliance.c b/lib/appliance.c > index 66f91cb0a..42591e7d7 100644 > --- a/lib/appliance.c > +++ b/lib/appliance.c > @@ -222,7 +222,7 @@ search_appliance (guestfs_h *g, struct appliance_files *appliance) > static int > contains_old_style_appliance (guestfs_h *g, const char *path, void *data) > { > - return dir_contains_files (g, path, kernel_name, initrd_name, NULL); > + return dir_contains_files (g, path, kernel_name, initrd_name, (void *) NULL); > } > > static int > @@ -230,7 +230,7 @@ contains_fixed_appliance (...

Hi, this is a prototype of something I've around for some time. Basically it is about adding new appliances in addition to the main one currently used and kept up-to-date automatically: this way it is possible to create new appliances with extra packages, to be used in specific contexts (like virt-rescue, with more network/recovery tools) without filling the main appliance. It's still

This is the libguestfs companion patch to: https://www.redhat.com/archives/libguestfs/2013-September/msg00045.html Rich.

Various changes/fixes to use smaller stack frames. Rich.

...char **pelem); -static int dir_contains_file (const char *dir, const char *file); -static int dir_contains_files (const char *dir, ...); +static int dir_contains_file (guestfs_h *g, const char *dir, const char *file); +static int dir_contains_files (guestfs_h *g, const char *dir, ...); static int contains_old_style_appliance (guestfs_h *g, const char *path, void *data); static int contains_fixed_appliance (guestfs_h *g, const char *path, void *data); static int contains_supermin_appliance (guestfs_h *g, const char *path, void *data); @@ -170,13 +170,13 @@ build_appliance (guestfs_h *g, static int contains_old_style...

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and