search for: constructtypedi

This isn't a realistic/viable implementation, just a hacked up "can I make it produce the right output" kind of thing, but while I hammer out a few more details (like fixing MC to allow multiple sections with the same name but different comdat groups) I figured I'd throw it out there to have a bit of a chat about it. I've tested simple cases of a single type and they seem to

...RF 4 specification says that DW_AT_calling_convention is not a valid attribute for any of those three DWARF tags. Downstream object consumers that check to verify that a DWARF attr is appropriate for a given DWARF tag will appropriately flag an error. I conjecture that this part of the DwarfUnit::constructTypeDIe() function (circa line 958 in DwarfUnit.cpp) should be guarded with a target- or vendor-specific conditional if it is needed for a particular purpose. Otherwise, I propose that it be removed since it breaks compliance with the DWARF specification. ~ Todd Snider -------------- next part --------...

...0e42 7 clang 0x00000000016b8252 llvm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute) + 610 8 clang 0x00000000016b9337 llvm::DwarfUnit::constructMemberDIE(llvm::DIE&, llvm::DIDerivedType) + 135 9 clang 0x00000000016ba2ed llvm::DwarfUnit::constructTypeDIE(llvm::DIE&, llvm::DICompositeType) + 2221 10 clang 0x00000000016b7e9c llvm::DwarfUnit::getOrCreateTypeDIE(llvm::MDNode const*) + 412 11 clang 0x00000000016b80a9 llvm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute) + 185 12 clang 0x0000000...

...vm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute) >> + 610 >> 8 clang 0x00000000016b9337 >> llvm::DwarfUnit::constructMemberDIE(llvm::DIE&, llvm::DIDerivedType) + 135 >> 9 clang 0x00000000016ba2ed >> llvm::DwarfUnit::constructTypeDIE(llvm::DIE&, llvm::DICompositeType) + 2221 >> 10 clang 0x00000000016b7e9c >> llvm::DwarfUnit::getOrCreateTypeDIE(llvm::MDNode const*) + 412 >> 11 clang 0x00000000016b80a9 >> llvm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute...

...lvm::DIType, llvm::dwarf::Attribute) + >>>> 610 >>>> 8 clang 0x00000000016b9337 >>>> llvm::DwarfUnit::constructMemberDIE(llvm::DIE&, llvm::DIDerivedType) + 135 >>>> 9 clang 0x00000000016ba2ed >>>> llvm::DwarfUnit::constructTypeDIE(llvm::DIE&, llvm::DICompositeType) + 2221 >>>> 10 clang 0x00000000016b7e9c >>>> llvm::DwarfUnit::getOrCreateTypeDIE(llvm::MDNode const*) + 412 >>>> 11 clang 0x00000000016b80a9 >>>> llvm::DwarfUnit::addType(llvm::DIE&, llvm...

...RF 4 specification says that DW_AT_calling_convention is not a valid attribute for any of those three DWARF tags. Downstream object consumers that check to verify that a DWARF attr is appropriate for a given DWARF tag will appropriately flag an error. I conjecture that this part of the DwarfUnit::constructTypeDIe() function (circa line 958 in DwarfUnit.cpp) should be guarded with a target- or vendor-specific conditional if it is needed for a particular purpose. Otherwise, I propose that it be removed since it breaks compliance with the DWARF specification. ~ Todd Snider -------------- next part --------...

...LLVM metadata. LLVM metadata for types already contains linkage name in "identifier" field: https://llvm.org/docs/LangRef.html#dicompositetype So LLVM itself can identify types by name, the only remaining issue is to emit it to debuginfo. That should be two lines of code in : DwarfUnit::constructTypeDIE, something like: StringRef LinkageName = CTy->getIdentifier(); addString(Buffer, dwarf::DW_AT_linkage_name, LinkageName); Thanks, Roman -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180302/10e773f8/...