search for: construct_libvirt_xml_qemu_cmdlin

...truct_libvirt_xml_boot (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_seclabel (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_lifecycle (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_devices (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_qemu_cmdline (g, params, xo) == -1) - return -1; + if (construct_libvirt_xml_name (g, params, xo) == -1) + return -1; + if (construct_libvirt_xml_cpu (g, params, xo) == -1) + return -1; + if (construct_libvirt_xml_boot (g, params, xo) == -1) + return -1; + if (construct_libvirt_xm...

...;, "virbr0"); + } end_element (); + start_element ("model") { + attribute ("type", "virtio"); + } end_element (); + } end_element (); + } + } end_element (); /* </devices> */ return 0; @@ -1617,27 +1630,6 @@ construct_libvirt_xml_qemu_cmdline (guestfs_h *g, attribute ("value", tmpdir); } end_element (); - /* Workaround because libvirt user networking cannot specify "net=" - * parameter. - */ - if (g->enable_network) { - start_element ("qemu:arg") { - attribute (&q...

...m/show_bug.cgi?id=1184411 + * Instead we hack around it using <qemu:commandline> below. */ +#ifndef __aarch64__ start_element ("model") { string (cpu_model); } end_element (); +#endif } } end_element (); } @@ -1728,6 +1732,21 @@ construct_libvirt_xml_qemu_cmdline (guestfs_h *g, } } +#ifdef __aarch64__ + /* This is a temporary hack until RHBZ#1184411 is resolved. + * See comments above about cpu model and aarch64. + */ + const char *cpu_model = guestfs___get_cpu_model (params->data->is_kvm); + if (STRNEQ (cpu_model, &quo...

Possibly for post 1.40. Rich.

Use libvirt to set up the user network instead of a custom qemu argument. Note this requires a non-upstream patch being discussed on the libvirt mailing list at the moment. https://bugzilla.redhat.com/show_bug.cgi?id=1075520#c6 Rich.

This rounds off hotplugging support by allowing you to add and remove drives at any stage (before and after launch). Rich.

...start_element ("model") { - attribute ("type", "virtio"); - } end_element (); - } end_element (); - } - /* Libvirt adds some devices by default. Indicate to libvirt * that we don't want them. */ @@ -1693,6 +1669,27 @@ construct_libvirt_xml_qemu_cmdline (guestfs_h *g, attribute ("value", tmpdir); } end_element (); + /* Workaround because libvirt user networking cannot specify "net=" + * parameter. + */ + if (g->enable_network) { + start_element ("qemu:arg") { + attribute (&q...

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

Let's actually compile and test the patch this time, rather than trusting the RHEL 7.6 patch to apply directly to head ... Rich.

qemu in SLIRP mode offers DHCP services to the appliance. We don't use them, but use a fixed IP address intead. This changes the appliance to get its IP address using DHCP. Note: This is only used when the network is enabled. dhclient is somewhat slower, but the penalty (a few seconds) is only paid for network users. We could consider using the faster systemd dhcp client instead. ---

This is, I guess, version 3 of this patch series which adds disk labels and hotplugging (only hot-add implemented so far). The good news is .. it works! Rich.

v3: - Various changes to dhclient/dhcpcd as discussed on the mailing list.

...if (r == 1) { + start_element ("secret") { + attribute ("type", type); + attribute ("uuid", uuid); + } end_element (); + } } end_element (); } break; @@ -1657,6 +1699,174 @@ construct_libvirt_xml_qemu_cmdline (guestfs_h *g, } static int +construct_libvirt_xml_secret (guestfs_h *g, + const struct backend_libvirt_data *data, + const struct drive *drv, + xmlTextWriterPtr xo) +{ + start_element ("secret")...

v2: - Make virbr0 configurable. - Fix the tests.

Since v1: - Base64 decode the Ceph secret before passing it to libvirt. - Don't call virSecretFree (NULL) [libvirt bug?] - Small cleanups.

Link to version 1: https://www.redhat.com/archives/libguestfs/2013-February/thread.html#00122 Changes since version 1: - I've pushed two (of the three) code refactoring patches. The third one proved rather hard to move. - selinuxnorelabel option is no more. Instead there is a second internal API (internal_set_libvirt_selinux_norelabel_disks). - fixed bogus commit message -

...start_element ("target") { - attribute ("dev", &params->appliance_dev[5]); + attribute ("dev", "%s", &params->appliance_dev[5]); attribute ("bus", "scsi"); } end_element (); @@ -1798,18 +1735,18 @@ construct_libvirt_xml_qemu_cmdline (guestfs_h *g, start_element ("qemu:env") { attribute ("name", "TMPDIR"); - attribute ("value", tmpdir); + attribute ("value", "%s", tmpdir); } end_element (); /* The qemu command line arguments request...

Consolidate and extend the use of funky start_element() etc macros. Rich.

...e) { XMLERROR (-1, xmlTextWriterWriteAttribute (xo, BAD_CAST "cache", @@ -1265,7 +1312,7 @@ construct_libvirt_xml_appliance (guestfs_h *g, XMLERROR (-1, xmlTextWriterEndElement (xo)); /* We'd like to do this, but it's not supported by libvirt. - * See construct_libvirt_xml_qemu_cmdline for the workaround. + * See make_drive_priv for the workaround. * * XMLERROR (-1, xmlTextWriterStartElement (xo, BAD_CAST "transient")); * XMLERROR (-1, xmlTextWriterEndElement (xo)); @@ -1397,18 +1444,22 @@ ignore_errors (void *ignore, virErrorPtr ignore2) /* empty */...

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :