search for: construct_libvirt_xml_boot

Unfortunately I was not able to test this because I don't currently have access to a P9 machine. Rich.

...; + append_list ("cap-htm=off"); > #endif Which version of qemu was this introduced in? > diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c > index 48404ef93..53284fc08 100644 > --- a/lib/launch-libvirt.c > +++ b/lib/launch-libvirt.c > @@ -1181,6 +1181,16 @@ construct_libvirt_xml_boot (guestfs_h *g, > } > } > > +#ifdef __powerpc64__ > + start_element ("features") { > + start_element ("pseries") { > + start_element ("htm") { > + attribute ("state", "on"); > +...

...quot;); + attribute_ns ("xmlns", "qemu", NULL, + "http://libvirt.org/schemas/domain/qemu/1.0"); - if (construct_libvirt_xml_name (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_cpu (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_boot (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_seclabel (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_lifecycle (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_devices (g, params, xo) == -1) - return -1; - if (construct_libvirt_xml_...

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

...;%s", cpu_model); } end_element (); } } end_element (); } start_element ("vcpu") { - string_format ("%d", g->smp); + string ("%d", g->smp); } end_element (); start_element ("clock") { @@ -1162,7 +1099,7 @@ construct_libvirt_xml_boot (guestfs_h *g, start_element ("os") { start_element ("type") { #ifdef MACHINE_TYPE - attribute ("machine", MACHINE_TYPE); + attribute ("machine", "%s", MACHINE_TYPE); #endif string ("hvm"); } end_element ();...

...ot;); #endif append_list_format ("accel=%s", !force_tcg ? "kvm:tcg" : "tcg"); } end_list (); diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 48404ef93..53284fc08 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -1181,6 +1181,16 @@ construct_libvirt_xml_boot (guestfs_h *g, } } +#ifdef __powerpc64__ + start_element ("features") { + start_element ("pseries") { + start_element ("htm") { + attribute ("state", "on"); + } end_element (); + } end_element (); +...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/thread.html#00000 v2: - Make conditional on qemu >= 2.11.2 and libvirt >= 4.6.0. - Fix the libvirt XML to match what went upstream. Still untested. Rich.

...ot;); #endif append_list_format ("accel=%s", !force_tcg ? "kvm:tcg" : "tcg"); } end_list (); diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 48404ef93..1a074fd6c 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -1181,6 +1181,16 @@ construct_libvirt_xml_boot (guestfs_h *g, } } +#ifdef __powerpc64__ + if (guestfs_int_version_ge (&params->data->libvirt_version, 4, 6, 0)) { + start_element ("features") { + start_element ("htm") { + attribute ("state", "off"); +...

Of course I mean state=off (not <htm state=on>) ... Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2018-October/msg00047.html However it was broken in a few ways. First of all the documentation was broken because "/**" enhanced comments were not permitted on macros. This is fixed in the new 1/4 patch. Secondly we didn't use single_element() everywhere possible, which is fixed in the new 4/4 patch. Lastly I've

...- start_element ("vcpu") { - string_format ("%d", g->smp); - } end_element (); + single_element_format ("vcpu", "%d", g->smp); start_element ("clock") { attribute ("offset", "utc"); @@ -1158,24 +1150,13 @@ construct_libvirt_xml_boot (guestfs_h *g, string (params->data->uefi_code); } end_element (); - if (params->data->uefi_vars) { - start_element ("nvram") { - string (params->data->uefi_vars); - } end_element (); - } + if (params->data->uefi_vars) + single_element (...

...variables, on architectures where that is required. */ + if (guestfs___get_uefi (g, &data->uefi_code, &data->uefi_vars) == -1) + goto cleanup; + /* Misc backend settings. */ guestfs_push_error_handler (g, NULL, NULL); free (data->selinux_label); @@ -1145,6 +1151,20 @@ construct_libvirt_xml_boot (guestfs_h *g, string ("hvm"); } end_element (); + if (params->data->uefi_code) { + start_element ("loader") { + attribute ("readonly", "yes"); + attribute ("type", "pflash"); + string (params->data->uefi_...

Consolidate and extend the use of funky start_element() etc macros. Rich.

..._NODUP (guestfs_int_appliance_command_line (g, appliance_dev, flags)); diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c index f46782c..92f2922 100644 --- a/src/launch-libvirt.c +++ b/src/launch-libvirt.c @@ -1160,6 +1160,10 @@ construct_libvirt_xml_boot (guestfs_h *g, flags = 0; if (!params->data->is_kvm) flags |= APPLIANCE_COMMAND_LINE_IS_TCG; +#ifdef VALGRIND_DAEMON + if (guestfs_int_get_backend_setting_bool (g, "valgrind_daemon") > 0) + flags |= APPLIANCE_COMMAND_LINE_VALGRIND_DAEMON; +#endif cmdline = guest...

NOTE: Not for upstream, yet. This depends on 3 non-upstream patches. - The qemu rework in libguestfs, which in turn depends on what Pino is up to. - Support for '-L ?' in qemu: https://lists.gnu.org/archive/html/qemu-devel/2016-05/threads.html#02596 - Support for bios-fast.bin in qemu: https://lists.gnu.org/archive/html/qemu-devel/2016-05/threads.html#02408 This commit

This commit uses -bios bios-fast.bin if available, which basically stops SeaBIOS from trying to do PCI probing during boot, which is a waste of time when using the -kernel option. v1 -> v2: - Rebase on top of Pino's work. This still has 3 dependencies: - The qemu memoization work (v2). - Support for '-L ?' in qemu:

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

By passing root=UUID=... to supermin, we make the appliance boot process less sensitive to the non-deterministic process of scanning SCSI disks (of which much more to come). This patch should be tested alongside the supermin patch posted here: https://www.redhat.com/archives/libguestfs/2017-April/msg00174.html which in turn requires this supermin patch series:

Starting with 5.2.0, libvirt has a way to select the firmware by specifying its type, provided configuration files for the firmware are shipped. Currently we start the appliance as UEFI if any of the firmware are found, so instead we can try to just set the firmware type iff: - the libvirt autoselection works - the 'efi' firmware is available The only behaviour change is that the default

This is the libguestfs companion patch to: https://www.redhat.com/archives/libguestfs/2013-September/msg00045.html Rich.