Displaying 2 results from an estimated 2 matches for "consider_message".
2007 Sep 17
4
Xenstored: eliminate double free and fixes for memory leak
Please review. This patch fixes a few problems:
a. In handle_input(), which is called from main() in
xenstored_core.c, the conn->in is freed when there is no error, but
conn is freed when there is error. This is inconsistent. Moreover,
the conn is freed again upon exit from handle_input(), inside the
main.
b. Another problem is that perms_to_strings() returned a allocated
memory (via
2005 Aug 04
0
[PATCH 6/11] Xenstore watch rework
...* Not finished header yet? */
@@ -1267,13 +1337,17 @@
struct connection *i, *tmp;
list_for_each_entry_safe(i, tmp, &connections, list) {
- if (!i->blocked)
- continue;
-
- if (!transaction_covering_node(i->blocked)) {
- talloc_free(i->blocked);
- i->blocked = NULL;
- consider_message(i);
+ switch (i->state) {
+ case BLOCKED:
+ if (!transaction_covering_node(i->blocked_by)) {
+ talloc_free(i->blocked_by);
+ i->blocked_by = NULL;
+ i->state = OK;
+ consider_message(i);
+ }
+ break;
+ case OK:
+ break;
}
}
@@ -1294,7 +1368,8 @@
if (!n...