search for: conol

From: Aaron Conole <aconole at bytheb.org> The virtio committee recently ratified a change, VIRTIO-152, which defines the mtu field to be 'max' MTU, not simply desired MTU. This commit brings the virtio-net device in compliance with VIRTIO-152. Additionally, drop the max_mtu branch - it cannot be ta...

From: Aaron Conole <aconole at bytheb.org> The virtio committee recently ratified a change, VIRTIO-152, which defines the mtu field to be 'max' MTU, not simply desired MTU. This commit brings the virtio-net device in compliance with VIRTIO-152. Additionally, drop the max_mtu branch - it cannot be ta...

...e second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. v2: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c | 12 ++++++++++++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 15 insertions(+) -- 2.5.0

...e second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. v2: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c | 12 ++++++++++++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 15 insertions(+) -- 2.5.0

...ribed in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c | 7 +++++++ include/uapi/linux/virtio_net.h | 2 ++ 2 files changed, 9 insertions(+) -- 2.5.5

...ribed in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c | 7 +++++++ include/uapi/linux/virtio_net.h | 2 ++ 2 files changed, 9 insertions(+) -- 2.5.5

...ribed in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron Conole (2): virtio: Start the advised MTU feature support virtio_net: Read and use the advised MTU drivers/net/virtio_net.c | 15 ++++++++++++++- include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 17 insertions(+), 1 deletion(-) -- 2.5.0

...ribed in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron Conole (2): virtio: Start the advised MTU feature support virtio_net: Read and use the advised MTU drivers/net/virtio_net.c | 15 ++++++++++++++- include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 17 insertions(+), 1 deletion(-) -- 2.5.0

Hello. On 03/10/2016 05:28 PM, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a...

On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: > This commit adds the feature bit and associated mtu device entry for the > virtio network device. Future commits will make use of these bits to > support negotiated MTU. why split it out? Pls squash with the next patch. > Signed-off-by: Aaron Conole <aconole at redhat.com...

Hello. On 03/10/2016 05:28 PM, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a...

On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: > This commit adds the feature bit and associated mtu device entry for the > virtio network device. Future commits will make use of these bits to > support negotiated MTU. why split it out? Pls squash with the next patch. > Signed-off-by: Aaron Conole <aconole at redhat.com...

On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a...

On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a...

On Tue, 15 Mar 2016 17:04:12 -0400 Aaron Conole <aconole at redhat.com> wrote: > --- a/include/uapi/linux/virtio_net.h > +++ b/include/uapi/linux/virtio_net.h > @@ -55,6 +55,7 @@ > #define VIRTIO_NET_F_MQ 22 /* Device supports Receive Flow > * Steering */ > #define VIRTIO_NET_F_CTRL_MAC_ADDR 23 /* Set MAC addre...

On Tue, 15 Mar 2016 17:04:12 -0400 Aaron Conole <aconole at redhat.com> wrote: > --- a/include/uapi/linux/virtio_net.h > +++ b/include/uapi/linux/virtio_net.h > @@ -55,6 +55,7 @@ > #define VIRTIO_NET_F_MQ 22 /* Device supports Receive Flow > * Steering */ > #define VIRTIO_NET_F_CTRL_MAC_ADDR 23 /* Set MAC addre...

Hello. On 3/16/2016 12:04 AM, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a...

Hello. On 3/16/2016 12:04 AM, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a...

...dds the feature bit and associated mtu device entry for the virtio network device. When a virtio device comes up, it checks the feature bit for the VIRTIO_NET_F_MTU feature. If such feature bit is enabled, the driver will read the advised MTU and use it as the initial value. Signed-off-by: Aaron Conole <aconole at redhat.com> --- v2->v3: * Added a check for the MTU, and a bit clear for it being out of range. drivers/net/virtio_net.c | 10 ++++++++++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/v...

...dds the feature bit and associated mtu device entry for the virtio network device. When a virtio device comes up, it checks the feature bit for the VIRTIO_NET_F_MTU feature. If such feature bit is enabled, the driver will read the advised MTU and use it as the initial value. Signed-off-by: Aaron Conole <aconole at redhat.com> --- v2->v3: * Added a check for the MTU, and a bit clear for it being out of range. drivers/net/virtio_net.c | 10 ++++++++++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/v...