search for: connection_socket

Hi, I attached the changes I made to a vanilla libguestfs-1.22.6 in order to make it work in mingw/win32. Added is also the patch required to make QEMU compatible (add a command to QMP that lists the supported devices (the regilat way you do it print it to stderr, which is difficult to redirect in win32)). This is done on behalf of Intel Corp. Thanks, Or (oberon in irc)

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

This set of patches fixes virt-rescue rather cleanly. In particular the problems with handling ^C are completely fixed. Work still to be done before this can go upstream: - Shutdown doesn't work properly if you exit the shell. At the moment to exit you must do 'reboot -f'. Future improvements: - An escape sequence and escape commands that could be handled by virt-rescue,

This fixes the main issues in virt-rescue and is usable. There are some enhancements which could be made (in follow up work): - An escape sequence and escape commands that could be handled by virt-rescue, eg. to shut down the appliance, mount or unmount filesystems. - `virt-rescue -i' could be implemented cleanly by performing the right API calls before handing control to the

This supersedes the two previous patch series: https://www.redhat.com/archives/libguestfs/2017-March/msg00017.html https://www.redhat.com/archives/libguestfs/2017-March/msg00046.html Rich.

Version 3: - Tidies up the code further. - Implements correct handling of SIGTSTP and SIGCONT. - Adds: ^] s - sync filesystems - Adds: ^] z - suspend virt-rescue Rich.

...connection_ops ops = { */ struct connection * guestfs_int_new_conn_socket_listening (guestfs_h *g, - int daemon_accept_sock, - int console_sock) + int daemon_accept_sock, + int console_sock) { struct connection_socket *conn; @@ -419,8 +419,8 @@ guestfs_int_new_conn_socket_listening (guestfs_h *g, */ struct connection * guestfs_int_new_conn_socket_connected (guestfs_h *g, - int daemon_sock, - int console_sock) + int daemon_soc...

Various changes/fixes to use smaller stack frames. Rich.

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

...(cmd->outbuf.add_data) cmd->outbuf.add_data (cmd, buf, n); diff --git a/src/conn-socket.c b/src/conn-socket.c index 05177ca..5b6b80e 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -312,7 +312,7 @@ static int handle_log_message (guestfs_h *g, struct connection_socket *conn) { - char buf[BUFSIZ]; + CLEANUP_FREE char *buf = safe_malloc (g, BUFSIZ); ssize_t n; /* Carried over from ancient proto.c code. The comment there was: @@ -329,7 +329,7 @@ handle_log_message (guestfs_h *g, */ usleep (1000); - n = read (conn->console_sock, buf, sizeof...